You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2017/12/08 21:59:41 UTC
Review Request 64466: Added a test to check shared resources
accounting in quota enforcement.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64466/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
This test verifies that when enforcing quota limit, shared resources
that are part of a role's reserved-allocated resources are only
charged once even when they are offered multiple times.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp 862f4683da04d37d9fe9f471d6ec9cd7751f39ec
Diff: https://reviews.apache.org/r/64466/diff/1/
Testing
-------
make check and a dedicated test in #64466.
Thanks,
Meng Zhu
Re: Review Request 64466: Added a test to check shared resources
accounting in quota enforcement.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64466/#review193286
-----------------------------------------------------------
Can you add Yan Xu and Anindya Sinha as reviewers?
- Benjamin Mahler
On Dec. 8, 2017, 10:15 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64466/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 10:15 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that when enforcing quota limit, shared resources
> that are part of a role's reserved-allocated resources are only
> charged once even when they are offered multiple times.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 862f4683da04d37d9fe9f471d6ec9cd7751f39ec
>
>
> Diff: https://reviews.apache.org/r/64466/diff/2/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 64466: Added a test to check shared resources
accounting in quota enforcement.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64466/
-----------------------------------------------------------
(Updated Dec. 8, 2017, 2:15 p.m.)
Review request for mesos, Benjamin Mahler and Michael Park.
Repository: mesos
Description
-------
This test verifies that when enforcing quota limit, shared resources
that are part of a role's reserved-allocated resources are only
charged once even when they are offered multiple times.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp 862f4683da04d37d9fe9f471d6ec9cd7751f39ec
Diff: https://reviews.apache.org/r/64466/diff/2/
Changes: https://reviews.apache.org/r/64466/diff/1-2/
Testing (updated)
-------
make check.
Thanks,
Meng Zhu