You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/09 22:06:35 UTC

[GitHub] [airflow] mik-laj opened a new pull request #7672: [AIRFLOW-7021] Avoid multiple calls to conf.getboolean in _process_dags

mik-laj opened a new pull request #7672: [AIRFLOW-7021] Avoid multiple calls to conf.getboolean in _process_dags
URL: https://github.com/apache/airflow/pull/7672
 
 
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [X] Description above provides context of the change
   - [X] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [X] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj merged pull request #7672: [AIRFLOW-7021] Avoid multiple calls to conf.getboolean in _process_dags

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #7672: [AIRFLOW-7021] Avoid multiple calls to conf.getboolean in _process_dags
URL: https://github.com/apache/airflow/pull/7672
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj edited a comment on issue #7672: [AIRFLOW-7021] Avoid multiple calls to conf.getboolean in _process_dags

Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #7672: [AIRFLOW-7021] Avoid multiple calls to conf.getboolean in _process_dags
URL: https://github.com/apache/airflow/pull/7672#issuecomment-596838560
 
 
   Before:
   Time: 451.187 ms
   After:
   Time: 425.041 ms
   Diff:
   Time: -26 ms (-5%)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7672: [AIRFLOW-7021] Avoid multiple calls to conf.getboolean in _process_dags

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7672: [AIRFLOW-7021] Avoid multiple calls to conf.getboolean in _process_dags
URL: https://github.com/apache/airflow/pull/7672#issuecomment-596843146
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7672?src=pr&el=h1) Report
   > Merging [#7672](https://codecov.io/gh/apache/airflow/pull/7672?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5be3b31bda4e9ebd8d14cefae27f422edcc332b7?src=pr&el=desc) will **decrease** coverage by `0.16%`.
   > The diff coverage is `92.3%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7672/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7672?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7672      +/-   ##
   ==========================================
   - Coverage   86.84%   86.67%   -0.17%     
   ==========================================
     Files         897      900       +3     
     Lines       42806    43605     +799     
   ==========================================
   + Hits        37173    37796     +623     
   - Misses       5633     5809     +176
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7672?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7672/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `90.68% <92.3%> (+0.02%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7672/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7672/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/7672/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==) | `76.08% <0%> (ø)` | :arrow_up: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7672/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7672/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0%> (-25.26%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7672/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/providers/google/cloud/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/7672/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9kYXRhZmxvdy5weQ==) | `90.44% <0%> (-8.65%)` | :arrow_down: |
   | [airflow/providers/mysql/hooks/mysql.py](https://codecov.io/gh/apache/airflow/pull/7672/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvaG9va3MvbXlzcWwucHk=) | `92.7% <0%> (-0.07%)` | :arrow_down: |
   | ... and [6 more](https://codecov.io/gh/apache/airflow/pull/7672/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7672?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7672?src=pr&el=footer). Last update [5be3b31...98f1161](https://codecov.io/gh/apache/airflow/pull/7672?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7672: [AIRFLOW-7021] Avoid multiple calls to conf.getboolean in _process_dags

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7672: [AIRFLOW-7021] Avoid multiple calls to conf.getboolean in _process_dags
URL: https://github.com/apache/airflow/pull/7672#issuecomment-596843146
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7672?src=pr&el=h1) Report
   > Merging [#7672](https://codecov.io/gh/apache/airflow/pull/7672?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5be3b31bda4e9ebd8d14cefae27f422edcc332b7?src=pr&el=desc) will **decrease** coverage by `0.21%`.
   > The diff coverage is `92.3%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7672/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7672?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7672      +/-   ##
   ==========================================
   - Coverage   86.84%   86.62%   -0.22%     
   ==========================================
     Files         897      900       +3     
     Lines       42806    43605     +799     
   ==========================================
   + Hits        37173    37773     +600     
   - Misses       5633     5832     +199
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7672?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7672/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `90.53% <92.3%> (-0.12%)` | :arrow_down: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7672/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7672/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/7672/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==) | `30.43% <0%> (-45.66%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7672/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7672/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0%> (-25.26%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7672/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/providers/google/cloud/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/7672/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9kYXRhZmxvdy5weQ==) | `90.44% <0%> (-8.65%)` | :arrow_down: |
   | [airflow/providers/mysql/hooks/mysql.py](https://codecov.io/gh/apache/airflow/pull/7672/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvaG9va3MvbXlzcWwucHk=) | `92.7% <0%> (-0.07%)` | :arrow_down: |
   | ... and [6 more](https://codecov.io/gh/apache/airflow/pull/7672/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7672?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7672?src=pr&el=footer). Last update [5be3b31...98f1161](https://codecov.io/gh/apache/airflow/pull/7672?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #7672: [AIRFLOW-7021] Avoid multiple calls to conf.getboolean in _process_dags

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7672: [AIRFLOW-7021] Avoid multiple calls to conf.getboolean in _process_dags
URL: https://github.com/apache/airflow/pull/7672#issuecomment-596838560
 
 
   Before:
   Time: 451.187 ms
   After:
   Time: 425.041 ms
   Diff:
   Time: 26 ms (5%)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services