[GitHub] [cordova-common] raphinesse edited a comment on issue #172: getPreference broken in #133

[GitBox <gi...@apache.org>]

raphinesse edited a comment on issue #172:
URL: https://github.com/apache/cordova-common/issues/172#issuecomment-895853085


   Thanks for reporting this. So if I understand it correctly, the issue is the following:
   
   Given following `config.xml`:
   ```xml
   <platform name="android"></platform>
   
   <platform name="android">
      <preference name="Fullscreen" value="true" />
   </platform>
   ```
   
   Pre #133 we would have
   ```js
   config.getPreference('Fullscreen', 'android') === 'true'
   ```
   
   and post #133 we would have
   ```js
   config.getPreference('Fullscreen', 'android') === ''
   ```
   
   Is that correct?
   
   > This breaks various plugins that depend on this.
   
   Would you mind giving some specific example?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org