You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by kw...@apache.org on 2023/01/10 09:30:56 UTC

[sling-org-apache-sling-repoinit-parser] branch master updated: SLING-10281 add default implementation for new method

This is an automated email from the ASF dual-hosted git repository.

kwin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-repoinit-parser.git


The following commit(s) were added to refs/heads/master by this push:
     new 7035805  SLING-10281 add default implementation for new method
7035805 is described below

commit 7035805b4f2f67cde51120d2641708f1bbd1c9a3
Author: Konrad Windszus <kw...@apache.org>
AuthorDate: Tue Jan 10 10:30:50 2023 +0100

    SLING-10281 add default implementation for new method
    
    add deprecation tags to visit methods
---
 .../sling/repoinit/parser/operations/OperationVisitor.java    | 11 ++++++++++-
 .../sling/repoinit/parser/test/OperationToStringVisitor.java  |  6 +++---
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/apache/sling/repoinit/parser/operations/OperationVisitor.java b/src/main/java/org/apache/sling/repoinit/parser/operations/OperationVisitor.java
index 957d9db..5084565 100644
--- a/src/main/java/org/apache/sling/repoinit/parser/operations/OperationVisitor.java
+++ b/src/main/java/org/apache/sling/repoinit/parser/operations/OperationVisitor.java
@@ -29,14 +29,23 @@ public interface OperationVisitor {
     void visitDeleteServiceUser(DeleteServiceUser s);
     void visitSetAclPrincipal(SetAclPrincipals s);
     void visitSetAclPaths(SetAclPaths s);
+    /**
+     * From deprecated statement
+     * @deprecated new statement calls {@link #visitEnsureAclPrincipalBased(EnsureAclPrincipalBased)}
+     */
     @Deprecated
     void visitSetAclPrincipalBased(SetAclPrincipalBased s);
     default void visitEnsureAclPrincipalBased(EnsureAclPrincipalBased ensureAclPrincipalBased) { throw new UnsupportedOperationException(); }
     default void visitRemoveAcePrincipal(RemoveAcePrincipals s) { throw new UnsupportedOperationException(); }
     default void visitRemoveAcePaths(RemoveAcePaths s) { throw new UnsupportedOperationException(); }
     default void visitRemoveAcePrincipalBased(RemoveAcePrincipalBased s) { throw new UnsupportedOperationException(); }
+    /**
+     * From deprecated statement
+     * @deprecated new statement calls {@link #visitEnsureNodes(EnsureNodes)}
+     */
+    @Deprecated
     void visitCreatePath(CreatePath cp);
-    void visitEnsureNodes(EnsureNodes cn);
+    default void visitEnsureNodes(EnsureNodes en) { throw new UnsupportedOperationException(); }
     void visitRegisterNamespace(RegisterNamespace rn);
     void visitRegisterNodetypes(RegisterNodetypes b);
     void visitRegisterPrivilege(RegisterPrivilege rp);
diff --git a/src/test/java/org/apache/sling/repoinit/parser/test/OperationToStringVisitor.java b/src/test/java/org/apache/sling/repoinit/parser/test/OperationToStringVisitor.java
index 7ffabf1..98aed19 100644
--- a/src/test/java/org/apache/sling/repoinit/parser/test/OperationToStringVisitor.java
+++ b/src/test/java/org/apache/sling/repoinit/parser/test/OperationToStringVisitor.java
@@ -241,9 +241,9 @@ class OperationToStringVisitor implements OperationVisitor {
     }
 
     @Override
-    public void visitEnsureNodes(EnsureNodes cn) {
-        out.println(cn.toString());
-        List<PropertyLine> propLines = cn.getPropertyLines();
+    public void visitEnsureNodes(EnsureNodes en) {
+        out.println(en.toString());
+        List<PropertyLine> propLines = en.getPropertyLines();
         for(PropertyLine p : propLines) {
             out.print("  ");
             out.println(p);