You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/02/05 14:34:05 UTC
[GitHub] [ignite] ptupitsyn opened a new pull request #8760: IGNITE-10073 .NET: Disable jar files build output with ApacheIgniteNoLibs condition
ptupitsyn opened a new pull request #8760:
URL: https://github.com/apache/ignite/pull/8760
Use cases:
* Thin client (does not need jars)
* Custom deployment (classpath is handled manually)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn merged pull request #8760: IGNITE-10073 .NET: Document how to exclude jar files from build output
Posted by GitBox <gi...@apache.org>.
ptupitsyn merged pull request #8760:
URL: https://github.com/apache/ignite/pull/8760
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8760: IGNITE-10073 .NET: Document how to exclude jar files from build output
Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8760:
URL: https://github.com/apache/ignite/pull/8760#discussion_r572048456
##########
File path: docs/_docs/net-specific/net-deployment-options.adoc
##########
@@ -17,35 +17,47 @@
== Overview
Apache Ignite.NET consists of .NET assemblies and Java jar files. The .NET assemblies are referenced by your project and
-are copied to an output folder during the build automatically. The JAR files should be copied manually.
+are copied to an output folder during the build automatically. The JAR files can be handled automatically or manually, depending on the approach.
Ignite.NET discovers them via the `IgniteHome` or `JvmClasspath` settings.
This page introduces several most-commonly used deployment options of Ignite.NET nodes.
-== Full Binary Package Deployment
-
-* Copy the https://ignite.apache.org[whole Ignite distribution package, window=_blank] along with your application
-* Set the `IGNITE_HOME` environment variable or `IgniteConfiguration.IgniteHome` setting to point to that folder
-
== NuGet Deployment
-The post-build event is updated automatically during the Ignite.NET NuGet package installation to copy jar files to
-`Libs` folder in the output directory (see link:quick-start/dotnet[Getting Started]).
-Make sure to include that `Libs` folder when distributing your binaries.
+`Apache.Ignite` NuGet package includes a `lib` folder with all the required jar files. This folder has
+`<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>` build action, and is copied automatically to the output directory
Review comment:
```suggestion
`Apache.Ignite` NuGet package includes a `lib` folder with all the required jar files. This folder has the `<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>` build action, and is copied automatically to the output directory
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8760: IGNITE-10073 .NET: Document how to exclude jar files from build output
Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8760:
URL: https://github.com/apache/ignite/pull/8760#discussion_r572049287
##########
File path: docs/_docs/net-specific/net-deployment-options.adoc
##########
@@ -17,35 +17,47 @@
== Overview
Apache Ignite.NET consists of .NET assemblies and Java jar files. The .NET assemblies are referenced by your project and
-are copied to an output folder during the build automatically. The JAR files should be copied manually.
+are copied to an output folder during the build automatically. The JAR files can be handled automatically or manually, depending on the approach.
Ignite.NET discovers them via the `IgniteHome` or `JvmClasspath` settings.
This page introduces several most-commonly used deployment options of Ignite.NET nodes.
-== Full Binary Package Deployment
-
-* Copy the https://ignite.apache.org[whole Ignite distribution package, window=_blank] along with your application
-* Set the `IGNITE_HOME` environment variable or `IgniteConfiguration.IgniteHome` setting to point to that folder
-
== NuGet Deployment
-The post-build event is updated automatically during the Ignite.NET NuGet package installation to copy jar files to
-`Libs` folder in the output directory (see link:quick-start/dotnet[Getting Started]).
-Make sure to include that `Libs` folder when distributing your binaries.
+`Apache.Ignite` NuGet package includes a `lib` folder with all the required jar files. This folder has
+`<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>` build action, and is copied automatically to the output directory
+during the build or publish process.
Make sure `IGNITE_HOME` is not set globally. Normally you don't need to set `IGNITE_HOME` with NuGet, except for
ASP.NET deployments (see below).
+To disable this default build action, add `<ExcludeAssets>build</ExcludeAssets>` https://docs.microsoft.com/en-us/nuget/consume-packages/package-references-in-project-files#controlling-dependency-assets[property] to the corresponding `<PackageReference>` in your `.csproj` file.
Review comment:
```suggestion
To disable this default build action, add the `<ExcludeAssets>build</ExcludeAssets>` https://docs.microsoft.com/en-us/nuget/consume-packages/package-references-in-project-files#controlling-dependency-assets[property] to the corresponding `<PackageReference>` in your `.csproj` file.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8760: IGNITE-10073 .NET: Document how to exclude jar files from build output
Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8760:
URL: https://github.com/apache/ignite/pull/8760#discussion_r572048954
##########
File path: docs/_docs/net-specific/net-deployment-options.adoc
##########
@@ -17,35 +17,47 @@
== Overview
Apache Ignite.NET consists of .NET assemblies and Java jar files. The .NET assemblies are referenced by your project and
-are copied to an output folder during the build automatically. The JAR files should be copied manually.
+are copied to an output folder during the build automatically. The JAR files can be handled automatically or manually, depending on the approach.
Ignite.NET discovers them via the `IgniteHome` or `JvmClasspath` settings.
This page introduces several most-commonly used deployment options of Ignite.NET nodes.
-== Full Binary Package Deployment
-
-* Copy the https://ignite.apache.org[whole Ignite distribution package, window=_blank] along with your application
-* Set the `IGNITE_HOME` environment variable or `IgniteConfiguration.IgniteHome` setting to point to that folder
-
== NuGet Deployment
-The post-build event is updated automatically during the Ignite.NET NuGet package installation to copy jar files to
-`Libs` folder in the output directory (see link:quick-start/dotnet[Getting Started]).
-Make sure to include that `Libs` folder when distributing your binaries.
+`Apache.Ignite` NuGet package includes a `lib` folder with all the required jar files. This folder has
+`<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>` build action, and is copied automatically to the output directory
Review comment:
```suggestion
the `<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>` build action, and is copied automatically to the output directory
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org