You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by jp...@apache.org on 2013/02/02 16:32:09 UTC
svn commit: r1441764 -
/lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/index/BaseTermVectorsFormatTestCase.java
Author: jpountz
Date: Sat Feb 2 15:32:09 2013
New Revision: 1441764
URL: http://svn.apache.org/viewvc?rev=1441764&view=rev
Log:
Fix compilation under Java 6.
Modified:
lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/index/BaseTermVectorsFormatTestCase.java
Modified: lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/index/BaseTermVectorsFormatTestCase.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/index/BaseTermVectorsFormatTestCase.java?rev=1441764&r1=1441763&r2=1441764&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/index/BaseTermVectorsFormatTestCase.java (original)
+++ lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/index/BaseTermVectorsFormatTestCase.java Sat Feb 2 15:32:09 2013
@@ -722,7 +722,7 @@ public abstract class BaseTermVectorsFor
writer.close();
dir.close();
if (exception.get() != null) {
- throw new AssertionError("One thread threw an exception", exception.get());
+ throw new RuntimeException("One thread threw an exception", exception.get());
}
}
}
Re: svn commit: r1441764 - /lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/index/BaseTermVectorsFormatTestCase.java
Posted by Adrien Grand <jp...@gmail.com>.
On Sat, Feb 2, 2013 at 5:35 PM, Uwe Schindler <uw...@thetaphi.de> wrote:
> throw (AssertionError) (new AssertionError("One thread threw an exception").initCause(exception.get()));
>
> also works. But inside JUnit the following is better:
> assertNull("One thread threw an exception", exception.get());
Thanks for the tip, Uwe! I just committed!
--
Adrien
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
RE: svn commit: r1441764 - /lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/index/BaseTermVectorsFormatTestCase.java
Posted by Uwe Schindler <uw...@thetaphi.de>.
throw (AssertionError) (new AssertionError("One thread threw an exception").initCause(exception.get()));
also works. But inside JUnit the following is better:
assertNull("One thread threw an exception", exception.get());
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de
> -----Original Message-----
> From: jpountz@apache.org [mailto:jpountz@apache.org]
> Sent: Saturday, February 02, 2013 4:32 PM
> To: commits@lucene.apache.org
> Subject: svn commit: r1441764 - /lucene/dev/trunk/lucene/test-
> framework/src/java/org/apache/lucene/index/BaseTermVectorsFormatTest
> Case.java
>
> Author: jpountz
> Date: Sat Feb 2 15:32:09 2013
> New Revision: 1441764
>
> URL: http://svn.apache.org/viewvc?rev=1441764&view=rev
> Log:
> Fix compilation under Java 6.
>
> Modified:
> lucene/dev/trunk/lucene/test-
> framework/src/java/org/apache/lucene/index/BaseTermVectorsFormatTest
> Case.java
>
> Modified: lucene/dev/trunk/lucene/test-
> framework/src/java/org/apache/lucene/index/BaseTermVectorsFormatTest
> Case.java
> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/test-
> framework/src/java/org/apache/lucene/index/BaseTermVectorsFormatTest
> Case.java?rev=1441764&r1=1441763&r2=1441764&view=diff
> ==========================================================
> ====================
> --- lucene/dev/trunk/lucene/test-
> framework/src/java/org/apache/lucene/index/BaseTermVectorsFormatTest
> Case.java (original)
> +++ lucene/dev/trunk/lucene/test-
> framework/src/java/org/apache/lucene/index/BaseTermVectorsFormatTest
> Case.java Sat Feb 2 15:32:09 2013
> @@ -722,7 +722,7 @@ public abstract class BaseTermVectorsFor
> writer.close();
> dir.close();
> if (exception.get() != null) {
> - throw new AssertionError("One thread threw an exception",
> exception.get());
> + throw new RuntimeException("One thread threw an exception",
> exception.get());
> }
> }
> }
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org