[GitHub] [helix] narendly opened a new issue #627: ClusterConfig.setInstanceCapacityKeys does not allow removal of keys

[GitBox <gi...@apache.org>]

narendly opened a new issue #627: ClusterConfig.setInstanceCapacityKeys does not allow removal of keys
URL: https://github.com/apache/helix/issues/627
 
 
   ```
     /**
      * Set the required Instance Capacity Keys.
      * @param capacityKeys
      */
     public void setInstanceCapacityKeys(List<String> capacityKeys) {
       if (capacityKeys == null || capacityKeys.isEmpty()) {
         throw new IllegalArgumentException("The input instance capacity key list is empty.");
       }
       _record.setListField(ClusterConfigProperty.INSTANCE_CAPACITY_KEYS.name(), capacityKeys);
     }
   ```
   
   I remember leaving a comment on the PR that added this that we need to allow the user to be able to set empty capacityKeys. @jiajunwang 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org