[jira] Commented: (THRIFT-834) THttpClient resends contents of message after transport errors

["Anatoly Fayngelerin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896023#action_12896023 ] 

Anatoly Fayngelerin commented on THRIFT-834:
--------------------------------------------

I would like to have this included in the 0.4 release, along with the original THttpClient(https://issues.apache.org/jira/browse/THRIFT-160)

I have been using this patch in production for a few weeks now. Please, let me know if there are any improvements that I can make in order to get it committed.

> THttpClient resends contents of message after transport errors
> --------------------------------------------------------------
>
>                 Key: THRIFT-834
>                 URL: https://issues.apache.org/jira/browse/THRIFT-834
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (C#)
>    Affects Versions: 0.4
>            Reporter: Anatoly Fayngelerin
>         Attachments: thttp_error_handle_patch.patch
>
>
> Currently, THttpClient attempts to send an HTTP request on Flush(). It also waits for the response in this method. In case of a successful web request, the output stream(send) is reset. In case of a transport error, the send buffer is retained, causing the next web request to contain the data that was  previously sent.
> The fix is pretty simple. I am attaching a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.