[GitHub] [doris] freemandealer commented on a diff in pull request #18528: [fix](storage) free dict_page immediately after usage to save memory

["freemandealer (via GitHub)" <gi...@apache.org>]

freemandealer commented on code in PR #18528:
URL: https://github.com/apache/doris/pull/18528#discussion_r1161684921


##########
be/src/olap/rowset/segment_v2/column_reader.h:
##########
@@ -359,7 +359,7 @@ class FileColumnIterator final : public ColumnIterator {
     std::unique_ptr<PageDecoder> _dict_decoder;
 
     // keep dict page handle to avoid released

Review Comment:
   > also update this comment
   
   seems no problem? we do need to keep it for some time :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org