[GitHub] [netbeans] eirikbakke commented on a change in pull request #1661: [NETBEANS-3440] Allow to define a palette for fontcolors XML Schema.

[GitBox <gi...@apache.org>]

eirikbakke commented on a change in pull request #1661: [NETBEANS-3440] Allow to define a palette for fontcolors XML Schema.
URL: https://github.com/apache/netbeans/pull/1661#discussion_r349957281
 
 

 ##########
 File path: ide/editor.settings.storage/src/org/netbeans/modules/editor/settings/storage/fontscolors/ColoringStorage.java
 ##########
 @@ -289,9 +293,11 @@ public void run() throws IOException {
     private static final String HIGHLIGHTING_FILE_NAME = "editorColoring.xml"; // NOI18N
     
     private static final String E_ROOT = "fontscolors"; //NOI18N
+    private static final String E_COLORREF = "colorref"; //NOI18N
 
 Review comment:
   It seems that this is the element that _defines_ the color reference, rather than uses it. I would call that "colordef" rather than "colorref", or something similar. The "reference" is the place that refers to the previously defined color.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists