You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/26 03:56:59 UTC

[GitHub] [pulsar] michaeljmarshall opened a new pull request, #16223: Update swagger documentation for query param: authoritative

michaeljmarshall opened a new pull request, #16223:
URL: https://github.com/apache/pulsar/pull/16223

   ### Motivation
   
   Applies the changes from https://github.com/apache/pulsar/pull/16222 to the generated swagger for older versions. Since this is only updating a comment, I don't think this presents any issues for backwards compatibility. However, if something thinks it does, please let me know.
   
   ### Modifications
   
   * Replace `Is authentication required to perform this operation` with `Whether leader broker redirected this call to this broker. For internal use.`
   * Update several of the `isGlobal` blocks so that we remove the `authoritative` description and put the correct description in the `authoritative` block.
   
   ### Verifying this change
   
   This is a trivial rework of the swagger docs.
   
   ### Does this pull request potentially affect one of the following parts:
   
   This updates the already generated swagger. That could be an issue, but I don't think it will be.
   
   ### Documentation
     
   - [x] `doc` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on pull request #16223: Update swagger documentation for query param: authoritative

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #16223:
URL: https://github.com/apache/pulsar/pull/16223#issuecomment-1166585345

   After thinking about this a bit more, I don't think we should update the existing swagger documentation since it is generated from the source code for the specific tag.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall closed pull request #16223: Update swagger documentation for query param: authoritative

Posted by GitBox <gi...@apache.org>.
michaeljmarshall closed pull request #16223: Update swagger documentation for query param: authoritative
URL: https://github.com/apache/pulsar/pull/16223


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org