You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/10/11 13:52:09 UTC
[GitHub] [dolphinscheduler] DarkAssassinator opened a new pull request, #12320: [fix-12318][Doc] Correct the wrong link
DarkAssassinator opened a new pull request, #12320:
URL: https://github.com/apache/dolphinscheduler/pull/12320
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
just correct the wrong link.
## Brief change log
just update the Code Style link
## Verify this pull request
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #12320: [fix-12318][Doc] Correct the wrong link
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #12320:
URL: https://github.com/apache/dolphinscheduler/pull/12320#discussion_r992378194
##########
docs/docs/en/contribute/join/pull-request.md:
##########
@@ -64,7 +64,7 @@ Please refer to the commit message section.
### Pull Request Code Style
DolphinScheduler uses `Spotless` to automatically fix code style and formatting errors,
-see [Code Style](../development-environment-setup.md#code-style) for details.
+see [Code Style](../development-environment-setup.md#Code Style) for details.
Review Comment:
It worked before. I'm not sure why it is not working. Pretty wired. But I don't think it is caused by `-`, I suppose the reason is `.md` cannot get mapped to `.html`. Could u plz help take a look when available? @zhongjiajie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #12320: [fix-12318][Doc] Correct the wrong link
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #12320:
URL: https://github.com/apache/dolphinscheduler/pull/12320#discussion_r994253067
##########
docs/docs/en/contribute/join/pull-request.md:
##########
@@ -64,7 +64,7 @@ Please refer to the commit message section.
### Pull Request Code Style
DolphinScheduler uses `Spotless` to automatically fix code style and formatting errors,
-see [Code Style](../development-environment-setup.md#code-style) for details.
+see [Code Style](../development-environment-setup.md#Code Style) for details.
Review Comment:
@zhongjiajie Thanks for the confirmation. I will submit a PR later to fix all the anchors. @DarkAssassinator Thanks again for reporting this issue : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #12320: [fix-12318][Doc] Correct the wrong link
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #12320:
URL: https://github.com/apache/dolphinscheduler/pull/12320#discussion_r992892134
##########
docs/docs/en/contribute/join/pull-request.md:
##########
@@ -64,7 +64,7 @@ Please refer to the commit message section.
### Pull Request Code Style
DolphinScheduler uses `Spotless` to automatically fix code style and formatting errors,
-see [Code Style](../development-environment-setup.md#code-style) for details.
+see [Code Style](../development-environment-setup.md#Code Style) for details.
Review Comment:
@DarkAssassinator @EricGao888 I have half remember that we do no support archor in our website https://dolphinscheduler.apache.org/en-us/docs/latest/user_doc/contribute/join/pull-request.html and it work in github source code page https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md
this is because we website template do not support it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #12320: [fix-12318][Doc] Correct the wrong link
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #12320:
URL: https://github.com/apache/dolphinscheduler/pull/12320#discussion_r992892134
##########
docs/docs/en/contribute/join/pull-request.md:
##########
@@ -64,7 +64,7 @@ Please refer to the commit message section.
### Pull Request Code Style
DolphinScheduler uses `Spotless` to automatically fix code style and formatting errors,
-see [Code Style](../development-environment-setup.md#code-style) for details.
+see [Code Style](../development-environment-setup.md#Code Style) for details.
Review Comment:
@DarkAssassinator @EricGao888 I have half remember that we do not support anchor in our website https://dolphinscheduler.apache.org/en-us/docs/latest/user_doc/contribute/join/pull-request.html and it works in GitHub source code page https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md
this is because we website template do not support it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator commented on a diff in pull request #12320: [fix-12318][Doc] Correct the wrong link
Posted by GitBox <gi...@apache.org>.
DarkAssassinator commented on code in PR #12320:
URL: https://github.com/apache/dolphinscheduler/pull/12320#discussion_r992422639
##########
docs/docs/en/contribute/join/pull-request.md:
##########
@@ -64,7 +64,7 @@ Please refer to the commit message section.
### Pull Request Code Style
DolphinScheduler uses `Spotless` to automatically fix code style and formatting errors,
-see [Code Style](../development-environment-setup.md#code-style) for details.
+see [Code Style](../development-environment-setup.md#Code Style) for details.
Review Comment:
> annot ge
yes, i think so, becasue zh md is working fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator commented on pull request #12320: [fix-12318][Doc] Correct the wrong link
Posted by GitBox <gi...@apache.org>.
DarkAssassinator commented on PR #12320:
URL: https://github.com/apache/dolphinscheduler/pull/12320#issuecomment-1277605505
close this PR, @EricGao888 has open another PR: https://github.com/apache/dolphinscheduler/pull/12357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator closed pull request #12320: [fix-12318][Doc] Correct the wrong link
Posted by GitBox <gi...@apache.org>.
DarkAssassinator closed pull request #12320: [fix-12318][Doc] Correct the wrong link
URL: https://github.com/apache/dolphinscheduler/pull/12320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org