[GitHub] wu-sheng commented on issue #1639: Try to send 1500 trace segments to collector, with unexpected exception

[GitBox <gi...@apache.org>]

wu-sheng commented on issue #1639: Try to send 1500 trace segments to collector, with unexpected exception
URL: https://github.com/apache/incubator-skywalking/issues/1639#issuecomment-419298932
 
 
   For me, look like a gRPC internal error. We have processed this error
   
   ```
               StreamObserver<UpstreamSegment> upstreamSegmentStreamObserver = serviceStub.collect(new StreamObserver<Downstream>() {
                   @Override
                   public void onNext(Downstream downstream) {
   
                   }
   
                   @Override
                   public void onError(Throwable throwable) {
                       status.finished();
                       if (logger.isErrorEnable()) {
                           logger.error(throwable, "Send UpstreamSegment to collector fail with a grpc internal exception.");
                       }
                       ServiceManager.INSTANCE.findService(GRPCChannelManager.class).reportError(throwable);
                   }
   
                   @Override
                   public void onCompleted() {
                       status.finished();
                   }
               });
   ```
   
   In `onError`, status is tagged as finished, so send should continue. But this is an internal error, not a network error(see #reportError method), I am not sure what is happening,
   
   Have you tried the RC2 tag? (Release is on the way). We upgrade gRPC to latest version, but don't know whether fix this or not.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services