You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/03 18:02:24 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7521: video: Move _VIDIOCBASE and _VIDIOC to include/nuttx/fs/ioctl.h
xiaoxiang781216 opened a new pull request, #7521:
URL: https://github.com/apache/incubator-nuttx/pull/7521
## Summary
to align with other drivers
## Impact
code refactor
## Testing
pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #7521: video: Move _VIDIOCBASE and _VIDIOC to include/nuttx/fs/ioctl.h
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #7521:
URL: https://github.com/apache/incubator-nuttx/pull/7521#discussion_r1013262605
##########
include/nuttx/fs/ioctl.h:
##########
@@ -599,6 +600,12 @@
#define _LTEIOCVALID(c) (_IOC_TYPE(c)==_LTEBASE)
#define _LTEIOC(nr) _IOC(_LTEBASE,nr)
+/* Video device ioctl definitions *******************************************/
+
+#define __VIDIOCVALID(c) (_IOC_TYPE(c)==_VIDIOCBASE)
+#define _LTEIOC(nr) _IOC(_LTEBASE,nr)
Review Comment:
```suggestion
```
This line shouldn't be here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #7521: video: Move _VIDIOCBASE and _VIDIOC to include/nuttx/fs/ioctl.h
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #7521:
URL: https://github.com/apache/incubator-nuttx/pull/7521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #7521: video: Move _VIDIOCBASE and _VIDIOC to include/nuttx/fs/ioctl.h
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #7521:
URL: https://github.com/apache/incubator-nuttx/pull/7521#discussion_r1013263552
##########
tools/ci/testlist/arm-02.dat:
##########
@@ -1 +1 @@
-/arm/[i-k]*,CONFIG_ARM_TOOLCHAIN_GNU_EABI
+/arm/[i-k]*,CONFIG_ARM_TOOLCHAIN_CLANG
Review Comment:
Is this change intentional? It seems it was included by mistake. Please double check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7521: video: Move _VIDIOCBASE and _VIDIOC to include/nuttx/fs/ioctl.h
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7521:
URL: https://github.com/apache/incubator-nuttx/pull/7521#discussion_r1013529449
##########
tools/ci/testlist/arm-02.dat:
##########
@@ -1 +1 @@
-/arm/[i-k]*,CONFIG_ARM_TOOLCHAIN_GNU_EABI
+/arm/[i-k]*,CONFIG_ARM_TOOLCHAIN_CLANG
Review Comment:
sorry no, i will revert the change.
##########
include/nuttx/fs/ioctl.h:
##########
@@ -599,6 +600,12 @@
#define _LTEIOCVALID(c) (_IOC_TYPE(c)==_LTEBASE)
#define _LTEIOC(nr) _IOC(_LTEBASE,nr)
+/* Video device ioctl definitions *******************************************/
+
+#define __VIDIOCVALID(c) (_IOC_TYPE(c)==_VIDIOCBASE)
+#define _LTEIOC(nr) _IOC(_LTEBASE,nr)
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7521: video: Move _VIDIOCBASE and _VIDIOC to include/nuttx/fs/ioctl.h
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7521:
URL: https://github.com/apache/incubator-nuttx/pull/7521#discussion_r1013410240
##########
include/nuttx/fs/ioctl.h:
##########
@@ -599,6 +600,12 @@
#define _LTEIOCVALID(c) (_IOC_TYPE(c)==_LTEBASE)
#define _LTEIOC(nr) _IOC(_LTEBASE,nr)
+/* Video device ioctl definitions *******************************************/
+
+#define __VIDIOCVALID(c) (_IOC_TYPE(c)==_VIDIOCBASE)
Review Comment:
why double `_` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7521: video: Move _VIDIOCBASE and _VIDIOC to include/nuttx/fs/ioctl.h
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7521:
URL: https://github.com/apache/incubator-nuttx/pull/7521#discussion_r1013529449
##########
tools/ci/testlist/arm-02.dat:
##########
@@ -1 +1 @@
-/arm/[i-k]*,CONFIG_ARM_TOOLCHAIN_GNU_EABI
+/arm/[i-k]*,CONFIG_ARM_TOOLCHAIN_CLANG
Review Comment:
sorry no他, i will revert the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7521: video: Move _VIDIOCBASE and _VIDIOC to include/nuttx/fs/ioctl.h
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7521:
URL: https://github.com/apache/incubator-nuttx/pull/7521#discussion_r1013541022
##########
include/nuttx/fs/ioctl.h:
##########
@@ -599,6 +600,12 @@
#define _LTEIOCVALID(c) (_IOC_TYPE(c)==_LTEBASE)
#define _LTEIOC(nr) _IOC(_LTEBASE,nr)
+/* Video device ioctl definitions *******************************************/
+
+#define __VIDIOCVALID(c) (_IOC_TYPE(c)==_VIDIOCBASE)
Review Comment:
typo error, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org