You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Steven Rowe (JIRA)" <ji...@apache.org> on 2011/06/20 12:09:47 UTC

[jira] [Updated] (SOLR-2452) rewrite solr build system

     [ https://issues.apache.org/jira/browse/SOLR-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steven Rowe updated SOLR-2452:
------------------------------

    Attachment: SOLR-2452-post-reshuffling.patch
                SOLR-2452.dir.reshuffle.sh

This Bash script and patch together eliminate {{solr/src/}} and move everything under it up one level, except for {{solr/src/java/}}, {{solr/src/test/}} and {{solr/src/test-files/}}, which are moved under a new directory {{solr/core/}}:

{noformat}
solr/
+---core/
+---dev-tools/
+---scripts/
+---site-src/
+---solrj/
+---test-framework/
+---webapp/
    +---web/
...
{noformat}

Additionally:
# I merged {{solr/src/common/}} into the {{solrj/}} directory, and moved all {{o.a.s.client.solrj}} and {{o.a.s.common}} tests from the core tests to {{solrj/src/test/}}; and
# I merged {{src/webapp/src/}} into the {{core/src/java/}} directory.

The philosophy at work here is to keep all sources used to build an artifact under a single directory.

Compilation and testing works, though the core<->solrj dependencies are unusual: non-test core depends on non-test solrj, but solrj tests depend on core tests.  (The IntelliJ and Maven builds need fudging to make this work, since their dependency mechanisms are not fine-grained enough to directly support this setup - these changes are also included in the patch.)

I haven't committed this to the branch because it's fairly radical, and I'd like to make sure nobody objects, but also because tracking trunk changes will become much harder after this change is committed to the branch.

Robert, would you please review?


> rewrite solr build system
> -------------------------
>
>                 Key: SOLR-2452
>                 URL: https://issues.apache.org/jira/browse/SOLR-2452
>             Project: Solr
>          Issue Type: Task
>          Components: Build
>            Reporter: Robert Muir
>             Fix For: 3.3
>
>         Attachments: SOLR-2452-post-reshuffling.patch, SOLR-2452.dir.reshuffle.sh
>
>
> As discussed some in SOLR-2002 (but that issue is long and hard to follow), I think we should rewrite the solr build system.
> Its slow, cumbersome, and messy, and makes it hard for us to improve things.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org