You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Justin Mclean <ju...@me.com> on 2014/10/20 05:00:26 UTC
[DISCUSSION] Squiggly 1.1 release candidate 0
Hi,
Please place any discussion here and not in the vote thread.
Thanks,
Justin
Re: [DISCUSSION] Squiggly 1.1 release candidate 0
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I thought we were going to skip votes for release candidates ?
You need to vote on a RC in order to make it a official release, there's no way that Apache policy (for good reasons). Plus I can't see this release having a large number of RCs unless there's something obvious I'm missing as it's relatively simple. I would guess one or two RC as most (fingers crossed), and if we do need another RC it likely votes will carry over.
Justin
Re: [DISCUSSION] Squiggly 1.1 release candidate 0
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Having said that, the consensus within the PMC was to first do a few rounds
> of QA without calling a vote for each build.
That's the whole point of CTR (commit then review).
> Justin didn’t agree and as Release Manager, he is free to handle a release
> as he sees fit, however.
It not that I disagreed it's just that:
- I can't see Squiggly having many RCs, it straight forward and there nothing contentious in there that I'm aware of
- Asking people to QA stuff without a vote doesn't tend to get anywhere (see the previous non voting RC0s I did)
Thanks,
Justin
Re: [DISCUSSION] Squiggly 1.1 release candidate 0
Posted by Erik de Bruin <er...@ixsoftware.nl>.
There has to be at least one vote in order for something to become a
release.
Having said that, the consensus within the PMC was to first do a few rounds
of QA without calling a vote for each build. That way, if a few people
ironed out the wrinkles first, likely only one round of voting would be
needed. There was even a Board member that chimed in on that discussion and
told us that was the way to go …
Justin didn’t agree and as Release Manager, he is free to handle a release
as he sees fit, however.
EdB
On Tue, Oct 21, 2014 at 10:10 AM, Tom Chiverton <tc...@extravision.com> wrote:
> I thought we were going to skip votes for release candidates ?
>
> Tom
>
>
> On 20/10/14 04:00, Justin Mclean wrote:
>
>> Hi,
>>
>> Please place any discussion here and not in the vote thread.
>>
>> Thanks,
>> Justin
>>
>> ______________________________________________________________________
>> This email has been scanned by the Symantec Email Security.cloud service.
>> For more information please visit http://www.symanteccloud.com
>> ______________________________________________________________________
>>
>>
>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [DISCUSSION] Squiggly 1.1 release candidate 0
Posted by Tom Chiverton <tc...@extravision.com>.
I thought we were going to skip votes for release candidates ?
Tom
On 20/10/14 04:00, Justin Mclean wrote:
> Hi,
>
> Please place any discussion here and not in the vote thread.
>
> Thanks,
> Justin
>
> ______________________________________________________________________
> This email has been scanned by the Symantec Email Security.cloud service.
> For more information please visit http://www.symanteccloud.com
> ______________________________________________________________________
>
Re: [DISCUSSION] Squiggly 1.1 release candidate 0
Posted by Chris Martin <wi...@gmail.com>.
Justin,
Okay after reviewing your email. I was able to get this to work. I took
the ApacheSpellingUI.swc out of the src folder, so I only have
ApacheSpellingUIEx.swc in my libs folder. And I've added the
ApackeFlexLinguisticUtils.swc into my libs folder. After that everything
works great!
Proposing some changes to the README:
* Clarify that if ApacheSpellingUI.swc is needed to leverage the speller
for mx components, then include it into the libs folder rather than the src
folder as it says now.
* Add that you will need both the ApacheSpellingFramework.swc and
ApacheFlexLinguisticUtils.swc in your libs folder.
The final issue of the context menu not attaching was due to the missing
ApacheFlexLinguisticUtils.swc file in the libs folder.
Thanks Justin for the info! That got me right past the issues. If the
above is cool by everyone, I can make the adjustments to the README.
Chris
On Tue, Oct 21, 2014 at 5:05 PM, Chris Martin <wi...@gmail.com> wrote:
> Justin,
>
> I also have the following in my lib folder:
>
> ApacheSpellingEngine.swc
> ApacheSpellingUIEx.swc
>
> Per the README I also have ApacheSpellingUI.swc in my src folder. Is that
> right? I noted above you mentioned that it was included in the libs
> folder. Also you said that you have either ApacheSpellingUI.swc or
> ApacheSpellingUIEx.swc depending if you are targeting mx or spark
> components. Right now I have ApacheSpellingUI.swc in my src folder and
> ApacheSpellingUIEx.swc in my libs folder.
>
> I did not find any references to ApacheSpellingFramework.swc or
> ApacheFlexLinguisticUtils.swc in the README file.
>
> Chris
>
>
> On Tue, Oct 21, 2014 at 4:03 PM, Justin Mclean <ju...@classsoftware.com>
> wrote:
>
>> Hi,
>>
>> > Yep, included that in my libs folder per the README.
>>
>> What other swcs do you have in your lib directory? I think you need a
>> minimum of SpellingEngine.swc, SpellingFramework.swc, LinguisticUtils.swf
>> (?) and SpellingUI.swf or SpellingUIEx.swf depending if you have mx or
>> spark controls.
>>
>> I've doubled checked here and it working fine with the compiled 1.1
>> version of the swcs
>>
>> Thanks,
>> Justin
>
>
>
Re: [DISCUSSION] Squiggly 1.1 release candidate 0
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I went through the RC. Checked in a bunch of spelling errors in SWC
> names, README, RELEASE_NOTES. IMO, it wouldn’t be right to release a
> Spell Checker with spelling errors in the supporting documentation ;-).
We released 1.0 with similar "issues". You could think of it as data to test :-)
Justin
Re: [DISCUSSION] Squiggly 1.1 release candidate 0
Posted by Alex Harui <ah...@adobe.com>.
I went through the RC. Checked in a bunch of spelling errors in SWC
names, README, RELEASE_NOTES. IMO, it wouldn’t be right to release a
Spell Checker with spelling errors in the supporting documentation ;-).
Everything else (LICENSE, NOTICE, build, RAT) all looks fine so I would
likely vote to approve the next RC.
-Alex
On 10/21/14, 5:57 PM, "Chris Martin" <wi...@gmail.com> wrote:
>> That incorrect you should only have one of ApacheFlexSpellingUI.swc or
>ApacheFlexSpellingUIEx.swc, for spark controls you need
>ApacheFlexSpellingUIEx.swc. These swcs define the same classes so you can
>only use one at a time.
>
>Ahh good to know! Then i'd adjust my first suggested change to the README
>to make it clear that you can only target either mx or spark, so you can
>only use one of the two swcs at a time.
>
>Chris
>
>On Tue, Oct 21, 2014 at 5:19 PM, Justin Mclean <ju...@classsoftware.com>
>wrote:
>
>> Hi,
>>
>> > Per the README I also have ApacheSpellingUI.swc in my src folder. Is
>> that right?
>>
>> That incorrect you should only have one of ApacheFlexSpellingUI.swc or
>> ApacheFlexSpellingUIEx.swc, for spark controls you need
>> ApacheFlexSpellingUIEx.swc. These swcs define the same classes so you
>>can
>> only use one at a time.
>>
>> > I did not find any references to ApacheSpellingFramework.swc or
>> ApacheFlexLinguisticUtils.swc in the README file.
>>
>> I believe ApacheFlexSpellingFramework.swc and
>>ApacheFlexSpellingEngine.swc
>> exist so that Squiggy can be used with both AS and Flex project, but we
>> would have to ask Adobe/original developers what their intent was. You
>> require both for Squiggly to work with Flex projects.
>> ApacheFlexLinguisticUtils.swc I think is optional and may be required if
>> you want to add your own custom dictionaries but again I'm not 100% sure
>> what Adobe's intent was.
>>
>> Thanks,
>> Justin
Re: [DISCUSSION] Squiggly 1.1 release candidate 0
Posted by Chris Martin <wi...@gmail.com>.
> That incorrect you should only have one of ApacheFlexSpellingUI.swc or
ApacheFlexSpellingUIEx.swc, for spark controls you need
ApacheFlexSpellingUIEx.swc. These swcs define the same classes so you can
only use one at a time.
Ahh good to know! Then i'd adjust my first suggested change to the README
to make it clear that you can only target either mx or spark, so you can
only use one of the two swcs at a time.
Chris
On Tue, Oct 21, 2014 at 5:19 PM, Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> > Per the README I also have ApacheSpellingUI.swc in my src folder. Is
> that right?
>
> That incorrect you should only have one of ApacheFlexSpellingUI.swc or
> ApacheFlexSpellingUIEx.swc, for spark controls you need
> ApacheFlexSpellingUIEx.swc. These swcs define the same classes so you can
> only use one at a time.
>
> > I did not find any references to ApacheSpellingFramework.swc or
> ApacheFlexLinguisticUtils.swc in the README file.
>
> I believe ApacheFlexSpellingFramework.swc and ApacheFlexSpellingEngine.swc
> exist so that Squiggy can be used with both AS and Flex project, but we
> would have to ask Adobe/original developers what their intent was. You
> require both for Squiggly to work with Flex projects.
> ApacheFlexLinguisticUtils.swc I think is optional and may be required if
> you want to add your own custom dictionaries but again I'm not 100% sure
> what Adobe's intent was.
>
> Thanks,
> Justin
Re: [DISCUSSION] Squiggly 1.1 release candidate 0
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Per the README I also have ApacheSpellingUI.swc in my src folder. Is that right?
That incorrect you should only have one of ApacheFlexSpellingUI.swc or ApacheFlexSpellingUIEx.swc, for spark controls you need ApacheFlexSpellingUIEx.swc. These swcs define the same classes so you can only use one at a time.
> I did not find any references to ApacheSpellingFramework.swc or ApacheFlexLinguisticUtils.swc in the README file.
I believe ApacheFlexSpellingFramework.swc and ApacheFlexSpellingEngine.swc exist so that Squiggy can be used with both AS and Flex project, but we would have to ask Adobe/original developers what their intent was. You require both for Squiggly to work with Flex projects. ApacheFlexLinguisticUtils.swc I think is optional and may be required if you want to add your own custom dictionaries but again I'm not 100% sure what Adobe's intent was.
Thanks,
Justin
Re: [DISCUSSION] Squiggly 1.1 release candidate 0
Posted by Chris Martin <wi...@gmail.com>.
Justin,
I also have the following in my lib folder:
ApacheSpellingEngine.swc
ApacheSpellingUIEx.swc
Per the README I also have ApacheSpellingUI.swc in my src folder. Is that
right? I noted above you mentioned that it was included in the libs
folder. Also you said that you have either ApacheSpellingUI.swc or
ApacheSpellingUIEx.swc depending if you are targeting mx or spark
components. Right now I have ApacheSpellingUI.swc in my src folder and
ApacheSpellingUIEx.swc in my libs folder.
I did not find any references to ApacheSpellingFramework.swc or
ApacheFlexLinguisticUtils.swc in the README file.
Chris
On Tue, Oct 21, 2014 at 4:03 PM, Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> > Yep, included that in my libs folder per the README.
>
> What other swcs do you have in your lib directory? I think you need a
> minimum of SpellingEngine.swc, SpellingFramework.swc, LinguisticUtils.swf
> (?) and SpellingUI.swf or SpellingUIEx.swf depending if you have mx or
> spark controls.
>
> I've doubled checked here and it working fine with the compiled 1.1
> version of the swcs
>
> Thanks,
> Justin
Re: [DISCUSSION] Squiggly 1.1 release candidate 0
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Yep, included that in my libs folder per the README.
What other swcs do you have in your lib directory? I think you need a minimum of SpellingEngine.swc, SpellingFramework.swc, LinguisticUtils.swf (?) and SpellingUI.swf or SpellingUIEx.swf depending if you have mx or spark controls.
I've doubled checked here and it working fine with the compiled 1.1 version of the swcs
Thanks,
Justin
Re: [DISCUSSION] Squiggly 1.1 release candidate 0
Posted by Chris Martin <wi...@gmail.com>.
Justin,
>As per the README I think you need to add ApacheFlexSpellingUIEx.swc for
it to work with spark
>components.
Yep, included that in my libs folder per the README.
Chris
On Mon, Oct 20, 2014 at 2:36 PM, Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> > After including the ApacheFlexSpellingFramework.swc in my lib I got past
> > that error. Maybe we need to add that into the README?
>
> As per the README I think you need to add ApacheFlexSpellingUIEx.swc for
> it to work with spark components.
>
> Thanks,
> Justin
Re: [DISCUSSION] Squiggly 1.1 release candidate 0
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> After including the ApacheFlexSpellingFramework.swc in my lib I got past
> that error. Maybe we need to add that into the README?
As per the README I think you need to add ApacheFlexSpellingUIEx.swc for it to work with spark components.
Thanks,
Justin
Re: [DISCUSSION] Squiggly 1.1 release candidate 0
Posted by Chris Martin <wi...@gmail.com>.
Heyo,
Trying to test this out in a simple app. I use the same code as above, and
I got the following error:
VerifyError: Error #1014: Class
com.adobe.linguistics.spelling.framework.ui::IHighlighter could not be
found.
at SquigglyTest/btnCheck_clickHandler()[C:\Users\cmartin\Documents\Adobe
Flash Builder 4.7 flex-sdk\SquigglyTest\src\SquigglyTest.mxml:18]
at SquigglyTest/__btnCheck_click()[C:\Users\cmartin\Documents\Adobe Flash
Builder 4.7 flex-sdk\SquigglyTest\src\SquigglyTest.mxml:34]
After including the ApacheFlexSpellingFramework.swc in my lib I got past
that error. Maybe we need to add that into the README?
After clicking on "Check Spark" nothing happens. Looked through via debug
and it seems that the context menu is not ultimately getting added
(SpellUI.as@510) so the _spellingEnabled is never set to true.
Now, what's really odd (and probably means developer environment error), is
that when I try to debug at line 510, it appears to "skip" over the line.
No error caught in the try catch, and the execution does not drop into the
addContextMenu function as expected.
I suspect, I ultimately need to get my flashplayer version references in
line. Right now i'm running FP 15, with the build files for the squiggly
swcs referencing the globalplayer.swc for FP14, and my flex-sdk home is
still set to Flex 4.12.1 which matches the SDK i'm using in the project and
that is expecting at least FP 12.0. I'll try to take another look at this
later today to see if I can test a good test of the project.
Any feedback if I'm going in the right direction would be cool too. I'm
still new to compiling/using libraries in my projects.
Chris
On Sun, Oct 19, 2014 at 8:13 PM, Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> Here's a sample to test out spelling working in spark components:
>
> <?xml version="1.0" encoding="utf-8"?>
>
> <s:WindowedApplication xmlns:fx="http://ns.adobe.com/mxml/2009"
>
> xmlns:s="library://ns.adobe.com/flex/spark"
>
> xmlns:mx="library://ns.adobe.com/flex/mx">
>
> <s:layout>
>
> <s:VerticalLayout />
>
> </s:layout>
>
>
> <fx:Script>
>
> <![CDATA[
>
> import com.adobe.linguistics.spelling.SpellUI;
>
>
> private function enableSpark():void {
>
> SpellUI.enableSpelling(sparkta, "en_GB");
>
> }
>
> ]]>
>
> </fx:Script>
>
> <s:TextArea id="sparkta" text="Spell cheecking in TextArea "/>
>
> <s:Button label="Check Spark" click="enableSpark()" />
>
> </s:WindowedApplication>
>
>
> You'll need to add the en_GB dictionary to your project and set up the
> spelling config file like so:
>
>
> <SpellingConfig>
>
> <LanguageResource language="English (British)" languageCode="en_GB"
> ruleFile="./data/en_GB/en_GB.aff" dictionaryFile="./data/en_GB/en_GB.dic"/>
>
> </SpellingConfig>
>
> Thanks,
> Justin
>
> On Mon, Oct 20, 2014 at 2:00 PM, Justin Mclean <ju...@me.com>
> wrote:
>
> > Hi,
> >
> > Please place any discussion here and not in the vote thread.
> >
> > Thanks,
> > Justin
> >
>
Re: [DISCUSSION] Squiggly 1.1 release candidate 0
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
Here's a sample to test out spelling working in spark components:
<?xml version="1.0" encoding="utf-8"?>
<s:WindowedApplication xmlns:fx="http://ns.adobe.com/mxml/2009"
xmlns:s="library://ns.adobe.com/flex/spark"
xmlns:mx="library://ns.adobe.com/flex/mx">
<s:layout>
<s:VerticalLayout />
</s:layout>
<fx:Script>
<![CDATA[
import com.adobe.linguistics.spelling.SpellUI;
private function enableSpark():void {
SpellUI.enableSpelling(sparkta, "en_GB");
}
]]>
</fx:Script>
<s:TextArea id="sparkta" text="Spell cheecking in TextArea "/>
<s:Button label="Check Spark" click="enableSpark()" />
</s:WindowedApplication>
You'll need to add the en_GB dictionary to your project and set up the
spelling config file like so:
<SpellingConfig>
<LanguageResource language="English (British)" languageCode="en_GB"
ruleFile="./data/en_GB/en_GB.aff" dictionaryFile="./data/en_GB/en_GB.dic"/>
</SpellingConfig>
Thanks,
Justin
On Mon, Oct 20, 2014 at 2:00 PM, Justin Mclean <ju...@me.com> wrote:
> Hi,
>
> Please place any discussion here and not in the vote thread.
>
> Thanks,
> Justin
>