You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Qifan Chen (Code Review)" <ge...@cloudera.org> on 2020/10/27 20:54:22 UTC
[Impala-ASF-CR] IMPALA-10292 Improvement to test misaligned parquet row groups
Qifan Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16668
Change subject: IMPALA-10292 Improvement to test_misaligned_parquet_row_groups
......................................................................
IMPALA-10292 Improvement to test_misaligned_parquet_row_groups
This fix improved the function _misaligned_parquet_row_groups_helper
in test_scanners.py by removing the hardcoded three backends running
a query. Instead, the number is fetched from the counter NumBackends
in the profile.
Testing:
1. Unit testing.
Change-Id: Icd190bca840ffdad0f615d8bde059431cb13b984
---
M tests/query_test/test_scanners.py
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/16668/2
--
To view, visit http://gerrit.cloudera.org:8080/16668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd190bca840ffdad0f615d8bde059431cb13b984
Gerrit-Change-Number: 16668
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
[Impala-ASF-CR] IMPALA-10292 Improvement to test misaligned parquet row groups
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16668 )
Change subject: IMPALA-10292 Improvement to test_misaligned_parquet_row_groups
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7570/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd190bca840ffdad0f615d8bde059431cb13b984
Gerrit-Change-Number: 16668
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Oct 2020 21:15:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10292 Improvement to test misaligned parquet row groups
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16668 )
Change subject: IMPALA-10292 Improvement to test_misaligned_parquet_row_groups
......................................................................
Patch Set 2:
The underlying reason the test fails in this case is that an impalad crashed, so there is the wrong number of impalads. Typically, when an impalad crashes, hundreds of tests fail. I see that as ok, and I don't think we should put much effort into making the tests resilient to the wrong number of impalads. The crash is the important part, and without the crash, this test will consistently pass.
--
To view, visit http://gerrit.cloudera.org:8080/16668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd190bca840ffdad0f615d8bde059431cb13b984
Gerrit-Change-Number: 16668
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Oct 2020 22:53:07 +0000
Gerrit-HasComments: No