You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/18 17:53:49 UTC
[GitHub] [flink] RyanSkraba opened a new pull request #19161: [FLINK-26736][tests][JUnit5 migration] flink-avro-confluent-registry
RyanSkraba opened a new pull request #19161:
URL: https://github.com/apache/flink/pull/19161
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Update the `flink-formats/flink-avro-confluent-registry` module to AssertJ and JUnit 5 following the [JUnit 5 Migration Guide](https://docs.google.com/document/d/1514Wa_aNB9bJUen4xm5uiuXOooOJTtXqS_Jqk9KJitU/edit)
I used the https://github.com/slinkydeveloper/assertj-migrator as the starting point
## Brief change log
* Removed dependences on JUnit 4, JUnit 5 Assertions and Hamcrest where possible.
## Verifying this change
This change is a code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive):no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RyanSkraba commented on a change in pull request #19161: [FLINK-26736][tests][JUnit5 migration] flink-avro-confluent-registry
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on a change in pull request #19161:
URL: https://github.com/apache/flink/pull/19161#discussion_r832937286
##########
File path: flink-formats/flink-avro-confluent-registry/src/test/java/org/apache/flink/formats/avro/registry/confluent/CachedSchemaCoderProviderTest.java
##########
@@ -85,21 +83,21 @@ public void testThatBasicAuthIsInitializedForBasicAuthProperties() {
BasicAuthCredentialProvider basicAuthCredentialProvider =
getBasicAuthFromProvider(provider);
- assertNotNull(basicAuthCredentialProvider);
- assertEquals(basicAuthCredentialProvider.getUserInfo(null), userPassword);
+ assertThat(basicAuthCredentialProvider).isNotNull();
+ assertThat(userPassword).isEqualTo(basicAuthCredentialProvider.getUserInfo(null));
Review comment:
You are correct -- done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19161: [FLINK-26736][tests][JUnit5 migration] flink-avro-confluent-registry
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19161:
URL: https://github.com/apache/flink/pull/19161#issuecomment-1072663756
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d47af79f7ad58d4c31fa1b392a72466e3008332e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33383",
"triggerID" : "d47af79f7ad58d4c31fa1b392a72466e3008332e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d47af79f7ad58d4c31fa1b392a72466e3008332e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33383)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19161: [FLINK-26736][tests][JUnit5 migration] flink-avro-confluent-registry
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19161:
URL: https://github.com/apache/flink/pull/19161#issuecomment-1072663756
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d47af79f7ad58d4c31fa1b392a72466e3008332e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33383",
"triggerID" : "d47af79f7ad58d4c31fa1b392a72466e3008332e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d47af79f7ad58d4c31fa1b392a72466e3008332e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33383)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19161: [FLINK-26736][tests][JUnit5 migration] flink-avro-confluent-registry
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19161:
URL: https://github.com/apache/flink/pull/19161#issuecomment-1072663756
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d47af79f7ad58d4c31fa1b392a72466e3008332e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33383",
"triggerID" : "d47af79f7ad58d4c31fa1b392a72466e3008332e",
"triggerType" : "PUSH"
}, {
"hash" : "1dd33ef2924b48a680e4144989375e4b5340545d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33632",
"triggerID" : "1dd33ef2924b48a680e4144989375e4b5340545d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d47af79f7ad58d4c31fa1b392a72466e3008332e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33383)
* 1dd33ef2924b48a680e4144989375e4b5340545d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33632)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19161: [FLINK-26736][tests][JUnit5 migration] flink-avro-confluent-registry
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19161:
URL: https://github.com/apache/flink/pull/19161#issuecomment-1072663756
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d47af79f7ad58d4c31fa1b392a72466e3008332e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33383",
"triggerID" : "d47af79f7ad58d4c31fa1b392a72466e3008332e",
"triggerType" : "PUSH"
}, {
"hash" : "1dd33ef2924b48a680e4144989375e4b5340545d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1dd33ef2924b48a680e4144989375e4b5340545d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d47af79f7ad58d4c31fa1b392a72466e3008332e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33383)
* 1dd33ef2924b48a680e4144989375e4b5340545d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RyanSkraba commented on a change in pull request #19161: [FLINK-26736][tests][JUnit5 migration] flink-avro-confluent-registry
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on a change in pull request #19161:
URL: https://github.com/apache/flink/pull/19161#discussion_r830231696
##########
File path: flink-formats/flink-avro-confluent-registry/src/test/java/org/apache/flink/formats/avro/registry/confluent/CachedSchemaCoderProviderTest.java
##########
@@ -22,7 +22,7 @@
import io.confluent.kafka.schemaregistry.client.rest.RestService;
import io.confluent.kafka.schemaregistry.client.security.basicauth.BasicAuthCredentialProvider;
import io.confluent.kafka.schemaregistry.client.security.bearerauth.BearerAuthCredentialProvider;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
import org.powermock.reflect.Whitebox;
Review comment:
It's tricky to get rid of this `Whitebox` ... I left it for now.
I'm thinking the best alternative might actually be to remove a bunch of these tests: SSL setup is tested extensively internally to the Confluent Schema Registry. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RyanSkraba commented on a change in pull request #19161: [FLINK-26736][tests][JUnit5 migration] flink-avro-confluent-registry
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on a change in pull request #19161:
URL: https://github.com/apache/flink/pull/19161#discussion_r830232710
##########
File path: flink-formats/flink-avro-confluent-registry/src/test/java/org/apache/flink/formats/avro/registry/confluent/debezium/DebeziumAvroSerDeSchemaTest.java
##########
@@ -222,4 +225,18 @@ public void close() {
// do nothing
}
}
+
+ private class MockInitializationContext
Review comment:
Do you think this might be reusable, or is it too simple to bother?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19161: [FLINK-26736][tests][JUnit5 migration] flink-avro-confluent-registry
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19161:
URL: https://github.com/apache/flink/pull/19161#issuecomment-1072663756
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d47af79f7ad58d4c31fa1b392a72466e3008332e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d47af79f7ad58d4c31fa1b392a72466e3008332e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d47af79f7ad58d4c31fa1b392a72466e3008332e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #19161: [FLINK-26736][tests][JUnit5 migration] flink-avro-confluent-registry
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #19161:
URL: https://github.com/apache/flink/pull/19161#discussion_r832147963
##########
File path: flink-formats/flink-avro-confluent-registry/src/test/java/org/apache/flink/formats/avro/registry/confluent/debezium/DebeziumAvroSerDeSchemaTest.java
##########
@@ -222,4 +225,18 @@ public void close() {
// do nothing
}
}
+
+ private class MockInitializationContext
Review comment:
seems fine as is. Should be static though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on a change in pull request #19161: [FLINK-26736][tests][JUnit5 migration] flink-avro-confluent-registry
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on a change in pull request #19161:
URL: https://github.com/apache/flink/pull/19161#discussion_r830620611
##########
File path: flink-formats/flink-avro-confluent-registry/src/test/java/org/apache/flink/formats/avro/registry/confluent/CachedSchemaCoderProviderTest.java
##########
@@ -85,21 +83,21 @@ public void testThatBasicAuthIsInitializedForBasicAuthProperties() {
BasicAuthCredentialProvider basicAuthCredentialProvider =
getBasicAuthFromProvider(provider);
- assertNotNull(basicAuthCredentialProvider);
- assertEquals(basicAuthCredentialProvider.getUserInfo(null), userPassword);
+ assertThat(basicAuthCredentialProvider).isNotNull();
+ assertThat(userPassword).isEqualTo(basicAuthCredentialProvider.getUserInfo(null));
Review comment:
nit: Adjust the order of `userPassword` and `basicAuthCredentialProvider.getUserInfo(null)`
##########
File path: flink-formats/flink-avro-confluent-registry/src/test/java/org/apache/flink/formats/avro/registry/confluent/CachedSchemaCoderProviderTest.java
##########
@@ -109,8 +107,8 @@ public void testThatBearerAuthIsInitializedForBearerAuthProperties() {
BearerAuthCredentialProvider bearerAuthCredentialProvider =
getBearerAuthFromProvider(provider);
- assertNotNull(bearerAuthCredentialProvider);
- assertEquals(bearerAuthCredentialProvider.getBearerToken(null), token);
+ assertThat(bearerAuthCredentialProvider).isNotNull();
+ assertThat(token).isEqualTo(bearerAuthCredentialProvider.getBearerToken(null));
Review comment:
idem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #19161: [FLINK-26736][tests][JUnit5 migration] flink-avro-confluent-registry
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #19161:
URL: https://github.com/apache/flink/pull/19161#discussion_r832154253
##########
File path: flink-formats/flink-avro-confluent-registry/src/test/java/org/apache/flink/formats/avro/registry/confluent/CachedSchemaCoderProviderTest.java
##########
@@ -22,7 +22,7 @@
import io.confluent.kafka.schemaregistry.client.rest.RestService;
import io.confluent.kafka.schemaregistry.client.security.basicauth.BasicAuthCredentialProvider;
import io.confluent.kafka.schemaregistry.client.security.bearerauth.BearerAuthCredentialProvider;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
import org.powermock.reflect.Whitebox;
Review comment:
As is the tests don't provide any value; but if we refactored them to actually use the Flink factories (_actually_ checking that the right properties are set) then we'd still need the Whitebox for verification I suppose.
I'd leave it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #19161: [FLINK-26736][tests][JUnit5 migration] flink-avro-confluent-registry
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #19161:
URL: https://github.com/apache/flink/pull/19161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19161: [FLINK-26736][tests][JUnit5 migration] flink-avro-confluent-registry
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19161:
URL: https://github.com/apache/flink/pull/19161#issuecomment-1072663756
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d47af79f7ad58d4c31fa1b392a72466e3008332e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33383",
"triggerID" : "d47af79f7ad58d4c31fa1b392a72466e3008332e",
"triggerType" : "PUSH"
}, {
"hash" : "1dd33ef2924b48a680e4144989375e4b5340545d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33632",
"triggerID" : "1dd33ef2924b48a680e4144989375e4b5340545d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1dd33ef2924b48a680e4144989375e4b5340545d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33632)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org