You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by sh...@apache.org on 2013/10/11 03:25:42 UTC
git commit: Made hideFormAccessoryBar a readwrite property again - it
turns out the keyboard view is never re-used, and always created on use.
Updated Branches:
refs/heads/plugins 7959156de -> 33cf7118e
Made hideFormAccessoryBar a readwrite property again - it turns out the keyboard view is never re-used, and always created on use.
Project: http://git-wip-us.apache.org/repos/asf/cordova-labs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-labs/commit/33cf7118
Tree: http://git-wip-us.apache.org/repos/asf/cordova-labs/tree/33cf7118
Diff: http://git-wip-us.apache.org/repos/asf/cordova-labs/diff/33cf7118
Branch: refs/heads/plugins
Commit: 33cf7118e3a9faafcbdfbb642bed30c046bbf430
Parents: 7959156
Author: Shazron Abdullah <sh...@apache.org>
Authored: Thu Oct 10 18:25:34 2013 -0700
Committer: Shazron Abdullah <sh...@apache.org>
Committed: Thu Oct 10 18:25:34 2013 -0700
----------------------------------------------------------------------
keyboard/src/ios/CDVKeyboard.h | 2 +-
keyboard/src/ios/CDVKeyboard.m | 4 ----
2 files changed, 1 insertion(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-labs/blob/33cf7118/keyboard/src/ios/CDVKeyboard.h
----------------------------------------------------------------------
diff --git a/keyboard/src/ios/CDVKeyboard.h b/keyboard/src/ios/CDVKeyboard.h
index f59294c..dca1fb5 100644
--- a/keyboard/src/ios/CDVKeyboard.h
+++ b/keyboard/src/ios/CDVKeyboard.h
@@ -36,7 +36,7 @@
@property (readwrite, assign) BOOL shrinkView;
@property (readwrite, assign) BOOL disableScrollingInShrinkView;
-@property (readonly, assign) BOOL hideFormAccessoryBar;
+@property (readwrite, assign) BOOL hideFormAccessoryBar;
@property (readonly, assign) BOOL keyboardIsVisible;
http://git-wip-us.apache.org/repos/asf/cordova-labs/blob/33cf7118/keyboard/src/ios/CDVKeyboard.m
----------------------------------------------------------------------
diff --git a/keyboard/src/ios/CDVKeyboard.m b/keyboard/src/ios/CDVKeyboard.m
index 1cca6a9..ada6082 100644
--- a/keyboard/src/ios/CDVKeyboard.m
+++ b/keyboard/src/ios/CDVKeyboard.m
@@ -27,7 +27,6 @@
@interface CDVKeyboard ()
@property (nonatomic, readwrite, assign) BOOL keyboardIsVisible;
-@property (nonatomic, readwrite, assign) BOOL hideFormAccessoryBar;
@end
@@ -228,9 +227,6 @@
- (void)formAccessoryBarKeyboardWillHide:(NSNotification*)notif
{
- // TODO: incomplete - we can't restore the accessory bar currently, this is why the public interface for the setting is readonly.
- // Not entirely sure we can restore this properly in the same hierarchy, even if we save the references
-
// restore the scrollview frame
self.webView.scrollView.frame = self.webView.frame;
}