[jira] [Commented] (FLINK-7798) Add support for windowed joins to Table API

["Xingcan Cui (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199824#comment-16199824 ] 

Xingcan Cui commented on FLINK-7798:
------------------------------------

Hi [~fhueske], as you said, most of the related code has already been there. To enable the stream window join in Table API, it seems we just need to get rid of the validation snippet in {{operators.scala}}.
{code:java}
if (tableEnv.isInstanceOf[StreamTableEnvironment]
  && !right.isInstanceOf[LogicalTableFunctionCall]) {
  failValidation(s"Join on stream tables is currently not supported.")
}
{code}
In addition, do you think it's necessary to add some (temporary) restrictions in the table validation process, so that we can provide more friendly exception messages (instead of something like "...TableException: Cannot generate a valid execution plan for the given query: ...").

> Add support for windowed joins to Table API
> -------------------------------------------
>
>                 Key: FLINK-7798
>                 URL: https://issues.apache.org/jira/browse/FLINK-7798
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: Fabian Hueske
>            Assignee: Xingcan Cui
>            Priority: Critical
>             Fix For: 1.4.0
>
>
> Currently, windowed joins on streaming tables are only supported through SQL.
> The Table API should support these joins as well. For that, we have to adjust the Table API validation and translate the API into the respective logical plan. Since most of the code should already be there for the batch Table API joins, this should be fairly straightforward.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)