You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2023/01/16 11:06:41 UTC

[GitHub] [lucene] romseygeek opened a new pull request, #12088: Don't throw UOE when highlighting FieldExistsQuery

romseygeek opened a new pull request, #12088:
URL: https://github.com/apache/lucene/pull/12088

   WeightedSpanTermExtractor will try to rewrite queries that it doesn't
   know about, to see if they end up as something it does know about and
   that it can extract terms from.  To support field merging, it rewrites against
   a delegating leaf reader that does not support `getFieldInfos()`.
   
   FieldExistsQuery uses `getFieldInfos()` in its rewrite, which means that 
   if one is passed to WeightedSpanTermExtractor, we get an
   UnsupportedOperationException thrown.
   
   This commit makes WeightedSpanTermExtractor aware of FieldExistsQuery,
   so that it can just ignore it and avoid throwing an exception.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] romseygeek commented on pull request #12088: Don't throw UOE when highlighting FieldExistsQuery

Posted by GitBox <gi...@apache.org>.
romseygeek commented on PR #12088:
URL: https://github.com/apache/lucene/pull/12088#issuecomment-1383932158

   Thanks for the review @mkhludnev! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] romseygeek merged pull request #12088: Don't throw UOE when highlighting FieldExistsQuery

Posted by GitBox <gi...@apache.org>.
romseygeek merged PR #12088:
URL: https://github.com/apache/lucene/pull/12088


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org