You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/23 16:21:23 UTC

[GitHub] [spark] nikriek commented on a change in pull request #31899: [SPARK-34525][DOCS] Update Spark Create Table DDL to reflect alternative key value notation

nikriek commented on a change in pull request #31899:
URL: https://github.com/apache/spark/pull/31899#discussion_r599725854



##########
File path: docs/sql-ref-syntax-ddl-create-table-datasource.md
##########
@@ -29,14 +29,14 @@ The `CREATE TABLE` statement defines a new table using a Data Source.
 CREATE TABLE [ IF NOT EXISTS ] table_identifier
     [ ( col_name1 col_type1 [ COMMENT col_comment1 ], ... ) ]
     USING data_source
-    [ OPTIONS ( key1=val1, key2=val2, ... ) ]
+    [ OPTIONS ( ( key1=val1, key2=val2, ... ) | ( key1 val1, key2 val2, ... ) ) ]

Review comment:
       Agree, I don't have strong arguments against your version. I would argue that the my version is more readable for a documentation. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org