[jira] [Commented] (BIGTOP-1524) FailureExecutor breaks smoke tests : Smoke tests should run from source

["Konstantin Boudnik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229532#comment-14229532 ] 

Konstantin Boudnik commented on BIGTOP-1524:
--------------------------------------------

I have just noticed that the patch was dirly actually, and included the following irrelevant code in the patch:
{code}
diff --git a/bigtop-deploy/vm/smoke-tests.sh b/bigtop-deploy/vm/smoke-tests.sh
index cfb4050..abc0c09 100755
--- a/bigtop-deploy/vm/smoke-tests.sh
+++ b/bigtop-deploy/vm/smoke-tests.sh
@@ -17,4 +17,4 @@ su -s /bin/bash $HCFS_USER -c 'hadoop fs -chmod 777 /user/vagrant'
 su -s /bin/bash $HCFS_USER -c 'hadoop fs -chmod 777 /user/root'
{code}

We need to me more careful preparing patches (and perhaps reviewing them too). I will open a ticket to revert these lines (unless they are now required elsewhere). [~jayunit100], could you please take a look to make sure if these lines are needed for something else? Thanks!

> FailureExecutor  breaks smoke tests : Smoke tests should run from source
> ------------------------------------------------------------------------
>
>                 Key: BIGTOP-1524
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1524
>             Project: Bigtop
>          Issue Type: Bug
>          Components: tests
>    Affects Versions: 0.8.0
>            Reporter: jay vyas
>            Assignee: jay vyas
>            Priority: Blocker
>             Fix For: 0.9.0
>
>         Attachments: BIGTOP-1524.patch, BIGTOP-1524.patch, BIGTOP-1524.patch, BIGTOP-1524.patch, BIGTOP-1524.patch
>
>
> Duh : By adding a hard requirement on itest-snapshot-0.9.0, we now break the existing mapreduce smoke tests. 
> Maybe i can add ITest as a compiled, rather than jar file, dependency for {{smoke-tests}}  . let me look into it 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)