You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/25 15:22:53 UTC
[GitHub] [camel] jamesnetherton opened a new pull request #4299: CAMEL-15581: Fix loading of XML rest definitions with camel-main
jamesnetherton opened a new pull request #4299:
URL: https://github.com/apache/camel/pull/4299
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #4299: CAMEL-15581: Fix loading of XML rest definitions with camel-main
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4299:
URL: https://github.com/apache/camel/pull/4299#issuecomment-699089856
I wonder if we have this problem on 3.4.x branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #4299: CAMEL-15581: Fix loading of XML rest definitions with camel-main
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #4299:
URL: https://github.com/apache/camel/pull/4299#issuecomment-699129803
The above link shows a different commit now. The error before reverting a95d17c772149a0f3c70243a68532272477c5423 was
```
mvn clean install -DskipTests
[INFO] BuildTimeEventSpy is registered.
[INFO] Scanning for projects...
[ERROR] [ERROR] The projects in the reactor contain a cyclic reference: Edge between 'Vertex{label='org.apache.camel:camel-undertow:3.6.0-SNAPSHOT'}' and 'Vertex{label='org.apache.camel:camel-test-spring-junit5:3.6.0-SNAPSHOT'}' introduces to cycle in the graph org.apache.camel:camel-test-spring-junit5:3.6.0-SNAPSHOT --> org.apache.camel:camel-spring:3.6.0-SNAPSHOT --> org.apache.camel:camel-main:3.6.0-SNAPSHOT --> org.apache.camel:camel-undertow:3.6.0-SNAPSHOT --> org.apache.camel:camel-test-spring-junit5:3.6.0-SNAPSHOT @
[ERROR] The projects in the reactor contain a cyclic reference: Edge between 'Vertex{label='org.apache.camel:camel-undertow:3.6.0-SNAPSHOT'}' and 'Vertex{label='org.apache.camel:camel-test-spring-junit5:3.6.0-SNAPSHOT'}' introduces to cycle in the graph org.apache.camel:camel-test-spring-junit5:3.6.0-SNAPSHOT --> org.apache.camel:camel-spring:3.6.0-SNAPSHOT --> org.apache.camel:camel-main:3.6.0-SNAPSHOT --> org.apache.camel:camel-undertow:3.6.0-SNAPSHOT --> org.apache.camel:camel-test-spring-junit5:3.6.0-SNAPSHOT -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectCycleException
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] jamesnetherton merged pull request #4299: CAMEL-15581: Fix loading of XML rest definitions with camel-main
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #4299:
URL: https://github.com/apache/camel/pull/4299
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a change in pull request #4299: CAMEL-15581: Fix loading of XML rest definitions with camel-main
Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #4299:
URL: https://github.com/apache/camel/pull/4299#discussion_r495142606
##########
File path: core/camel-main/src/main/java/org/apache/camel/main/DefaultRoutesCollector.java
##########
@@ -206,7 +206,7 @@ public void configure() throws Exception {
Set<InputStream> set = resolver.findResources(part);
for (InputStream is : set) {
log.debug("Found XML rest from location: {}", part);
- RestsDefinition rests = (RestsDefinition) ecc.getXMLRoutesDefinitionLoader().loadRoutesDefinition(ecc, is);
+ RestsDefinition rests = (RestsDefinition) ecc.getXMLRoutesDefinitionLoader().loadRestsDefinition(ecc, is);
Review comment:
Ha one of the many billion copy/paste mistakes in the world
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] jamesnetherton commented on pull request #4299: CAMEL-15581: Fix loading of XML rest definitions with camel-main
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #4299:
URL: https://github.com/apache/camel/pull/4299#issuecomment-699102669
> I wonder if we have this problem on 3.4.x branch
Yeah, seems the bug goes back to 3.1.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #4299: CAMEL-15581: Fix loading of XML rest definitions with camel-main
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #4299:
URL: https://github.com/apache/camel/pull/4299#issuecomment-699121215
I dared to revert this because it caused a cycle in the maven dependency graph: https://github.com/apache/camel/pull/4295/checks?check_run_id=1167651159#step:6:15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #4299: CAMEL-15581: Fix loading of XML rest definitions with camel-main
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4299:
URL: https://github.com/apache/camel/pull/4299#issuecomment-699441556
Ah yeah you can add such kind of tests in tests/camel-itest - or avoid using undertow in the test, and use a simulated rest component, we do that in some other rest based tests in camel-core testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org