Re: web::request -reset

[Ronnie Brunner <ro...@netcetera.ch>]

> I'm confused about
> 
> int resetRequestData(Tcl_Interp * interp, RequestData * requestData)
> 
> <dt><b>web::request -reset</b>
> 
> deletes all parameters from the web::request data (like 'web::request
> -unset'), removes all static parameters (like 'web::cmdurlcfg
> -unset'), all form variables (like 'web::formvar -unset'), all query
> string parameters (like 'web::param -unset'), and all temporary files
> created by HTTP form upload
> 
> but it also seems to reset stuff that is set in ::config, which seems
> like a more 'global' command (and should therefore take precedence?).

I agree: imho these things should be application specific, not request
specific. Normally this should be done in the web::initializer -> if
reset between requests the application will fail. Browsing through the
options in web::config, I don't see any option that is request
specific in that sense. E.g. the requestData->cmdTag and
requestData->timeTag should not be reset.

Ronnie
------------------------------------------------------------------------
Ronnie Brunner                               ronnie.brunner@netcetera.ch
Netcetera AG, 8040 Zuerich    phone +41 1 247 79 79 Fax: +41 1 247 70 75

Re: web::request -reset

["David N. Welton" <da...@dedasys.com>]

Ronnie Brunner <ro...@netcetera.ch> writes:

> > I'm confused about

> > int resetRequestData(Tcl_Interp * interp, RequestData * requestData)

> > <dt><b>web::request -reset</b>

> > deletes all parameters from the web::request data (like
> > 'web::request -unset'), removes all static parameters (like
> > 'web::cmdurlcfg -unset'), all form variables (like 'web::formvar
> > -unset'), all query string parameters (like 'web::param -unset'),
> > and all temporary files created by HTTP form upload

> > but it also seems to reset stuff that is set in ::config, which
> > seems like a more 'global' command (and should therefore take
> > precedence?).

> I agree: imho these things should be application specific, not
> request specific. Normally this should be done in the
> web::initializer -> if reset between requests the application will
> fail. Browsing through the options in web::config, I don't see any
> option that is request specific in that sense. E.g. the
> requestData->cmdTag and requestData->timeTag should not be reset.

Ok, now for me this brings up something of a worrying situation, as it
starts to become more of a behavior change rather than a simple bugfix
or simple feature addition.

I will open a new bug for this problem - but what are your feelings
regarding a fix?

-- 
David N. Welton
   Consulting: http://www.dedasys.com/
Free Software: http://people.debian.org/~davidw/
   Apache Tcl: http://tcl.apache.org/
     Personal: http://www.efn.org/~davidw/