You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@hotmail.com> on 2013/08/14 03:03:18 UTC
Review Request 13548: [HELIX-207] Add javadocs to classes and public methods
in the top-level package
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13548/
-----------------------------------------------------------
Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu.
Bugs: HELIX-205 and HELIX-207
Repository: helix-git
Description
-------
Fix for HELIX-207. This is a subtask of HELIX-205, roughly divided into package. This one is for the top-level org.apache.helix package.
Diffs
-----
helix-core/src/main/java/org/apache/helix/AccessOption.java eb86fee
helix-core/src/main/java/org/apache/helix/BaseDataAccessor.java fcbad00
helix-core/src/main/java/org/apache/helix/ClusterMessagingService.java dc4a0ad
helix-core/src/main/java/org/apache/helix/ConfigAccessor.java c1afb8d
helix-core/src/main/java/org/apache/helix/ControllerChangeListener.java b27596d
helix-core/src/main/java/org/apache/helix/Criteria.java 11e9f7a
helix-core/src/main/java/org/apache/helix/CurrentStateChangeListener.java 0c3baa5
helix-core/src/main/java/org/apache/helix/ExternalCommand.java 5c9d716
helix-core/src/main/java/org/apache/helix/ExternalViewChangeListener.java 1fa0db0
helix-core/src/main/java/org/apache/helix/GroupCommit.java 29f7369
helix-core/src/main/java/org/apache/helix/HealthStateChangeListener.java bd3ef4f
helix-core/src/main/java/org/apache/helix/HelixAdmin.java 5cd9a13
helix-core/src/main/java/org/apache/helix/HelixConstants.java 19bc740
helix-core/src/main/java/org/apache/helix/HelixDataAccessor.java 946787a
helix-core/src/main/java/org/apache/helix/HelixException.java 79c3468
helix-core/src/main/java/org/apache/helix/HelixManager.java 7b01f2c
helix-core/src/main/java/org/apache/helix/HelixManagerFactory.java cc5673f
helix-core/src/main/java/org/apache/helix/HelixManagerProperties.java f58dc27
helix-core/src/main/java/org/apache/helix/HelixProperty.java 31ac50a
helix-core/src/main/java/org/apache/helix/HelixTimerTask.java 0b7edb9
helix-core/src/main/java/org/apache/helix/IdealStateChangeListener.java d387593
helix-core/src/main/java/org/apache/helix/InstanceConfigChangeListener.java 5d55be1
helix-core/src/main/java/org/apache/helix/LiveInstanceChangeListener.java 79b0845
helix-core/src/main/java/org/apache/helix/LiveInstanceInfoProvider.java 1651839
helix-core/src/main/java/org/apache/helix/MessageListener.java cb3776e
helix-core/src/main/java/org/apache/helix/NotificationContext.java f683e77
helix-core/src/main/java/org/apache/helix/PreConnectCallback.java 9d65a14
helix-core/src/main/java/org/apache/helix/PropertyKey.java 50dbc60
helix-core/src/main/java/org/apache/helix/PropertyPathConfig.java eb5310b
helix-core/src/main/java/org/apache/helix/PropertyType.java b11d1ce
helix-core/src/main/java/org/apache/helix/ScopedConfigChangeListener.java e690d38
helix-core/src/main/java/org/apache/helix/ZNRecord.java 4cf5449
helix-core/src/main/java/org/apache/helix/ZNRecordAssembler.java df5ed8b
helix-core/src/main/java/org/apache/helix/ZNRecordBucketizer.java c0fbdc0
helix-core/src/main/java/org/apache/helix/ZNRecordDelta.java fd7f03d
helix-core/src/main/java/org/apache/helix/ZNRecordUpdater.java 6b431e9
Diff: https://reviews.apache.org/r/13548/diff/
Testing
-------
Tests passing locally.
Thanks,
Kanak Biscuitwala
Re: Review Request 13548: [HELIX-207] Add javadocs to classes and public
methods in the top-level package
Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13548/#review25159
-----------------------------------------------------------
Ship it!
Ship It!
- Zhen Zhang
On Aug. 14, 2013, 1:03 a.m., Kanak Biscuitwala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13548/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2013, 1:03 a.m.)
>
>
> Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu.
>
>
> Bugs: HELIX-205 and HELIX-207
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> Fix for HELIX-207. This is a subtask of HELIX-205, roughly divided into package. This one is for the top-level org.apache.helix package.
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/AccessOption.java eb86fee
> helix-core/src/main/java/org/apache/helix/BaseDataAccessor.java fcbad00
> helix-core/src/main/java/org/apache/helix/ClusterMessagingService.java dc4a0ad
> helix-core/src/main/java/org/apache/helix/ConfigAccessor.java c1afb8d
> helix-core/src/main/java/org/apache/helix/ControllerChangeListener.java b27596d
> helix-core/src/main/java/org/apache/helix/Criteria.java 11e9f7a
> helix-core/src/main/java/org/apache/helix/CurrentStateChangeListener.java 0c3baa5
> helix-core/src/main/java/org/apache/helix/ExternalCommand.java 5c9d716
> helix-core/src/main/java/org/apache/helix/ExternalViewChangeListener.java 1fa0db0
> helix-core/src/main/java/org/apache/helix/GroupCommit.java 29f7369
> helix-core/src/main/java/org/apache/helix/HealthStateChangeListener.java bd3ef4f
> helix-core/src/main/java/org/apache/helix/HelixAdmin.java 5cd9a13
> helix-core/src/main/java/org/apache/helix/HelixConstants.java 19bc740
> helix-core/src/main/java/org/apache/helix/HelixDataAccessor.java 946787a
> helix-core/src/main/java/org/apache/helix/HelixException.java 79c3468
> helix-core/src/main/java/org/apache/helix/HelixManager.java 7b01f2c
> helix-core/src/main/java/org/apache/helix/HelixManagerFactory.java cc5673f
> helix-core/src/main/java/org/apache/helix/HelixManagerProperties.java f58dc27
> helix-core/src/main/java/org/apache/helix/HelixProperty.java 31ac50a
> helix-core/src/main/java/org/apache/helix/HelixTimerTask.java 0b7edb9
> helix-core/src/main/java/org/apache/helix/IdealStateChangeListener.java d387593
> helix-core/src/main/java/org/apache/helix/InstanceConfigChangeListener.java 5d55be1
> helix-core/src/main/java/org/apache/helix/LiveInstanceChangeListener.java 79b0845
> helix-core/src/main/java/org/apache/helix/LiveInstanceInfoProvider.java 1651839
> helix-core/src/main/java/org/apache/helix/MessageListener.java cb3776e
> helix-core/src/main/java/org/apache/helix/NotificationContext.java f683e77
> helix-core/src/main/java/org/apache/helix/PreConnectCallback.java 9d65a14
> helix-core/src/main/java/org/apache/helix/PropertyKey.java 50dbc60
> helix-core/src/main/java/org/apache/helix/PropertyPathConfig.java eb5310b
> helix-core/src/main/java/org/apache/helix/PropertyType.java b11d1ce
> helix-core/src/main/java/org/apache/helix/ScopedConfigChangeListener.java e690d38
> helix-core/src/main/java/org/apache/helix/ZNRecord.java 4cf5449
> helix-core/src/main/java/org/apache/helix/ZNRecordAssembler.java df5ed8b
> helix-core/src/main/java/org/apache/helix/ZNRecordBucketizer.java c0fbdc0
> helix-core/src/main/java/org/apache/helix/ZNRecordDelta.java fd7f03d
> helix-core/src/main/java/org/apache/helix/ZNRecordUpdater.java 6b431e9
>
> Diff: https://reviews.apache.org/r/13548/diff/
>
>
> Testing
> -------
>
> Tests passing locally.
>
>
> Thanks,
>
> Kanak Biscuitwala
>
>