[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1511: MINIFICPP-1716 Recover core dumps from CI

["adamdebreceni (via GitHub)" <gi...@apache.org>]

adamdebreceni commented on code in PR #1511:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1511#discussion_r1129254375


##########
.github/workflows/ci.yml:
##########
@@ -196,13 +247,36 @@ jobs:
       - id: build
         run: |
           if [ -d ~/.ccache ]; then mv ~/.ccache .; fi
-          mkdir build && cd build && cmake -DUSE_SHARED_LIBS=ON -DCI_BUILD=ON -DSTRICT_GSL_CHECKS=AUDIT -DFAIL_ON_WARNINGS=ON -DENABLE_AWS=ON -DENABLE_AZURE=ON \
+          mkdir build && cd build && cmake -DUSE_SHARED_LIBS=ON -DCI_BUILD=ON -DCMAKE_BUILD_TYPE=Release -DSTRICT_GSL_CHECKS=AUDIT -DFAIL_ON_WARNINGS=ON -DENABLE_AWS=ON -DENABLE_AZURE=ON \

Review Comment:
   could we add the comment about running out of size on centos here as well? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org