You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Sai Pullabhotla (JIRA)" <ji...@apache.org> on 2010/04/01 14:44:27 UTC
[jira] Created: (FTPSERVER-362) Add a configuration option for
maximum number of threads the server is allowed to create
Add a configuration option for maximum number of threads the server is allowed to create
----------------------------------------------------------------------------------------
Key: FTPSERVER-362
URL: https://issues.apache.org/jira/browse/FTPSERVER-362
Project: FtpServer
Issue Type: New Feature
Components: Core
Affects Versions: 1.0.4, 1.0.3, 1.0.2, 1.0.1, 1.0.0, 1.0.0-RC2, 1.0.0-RC1, 1.0.0-M4, 1.0.0-M3, 1.0.0-M2, 1.0.0-M1
Reporter: Sai Pullabhotla
Fix For: 1.0.5
Currently the max threads are defaulted to 16. Based on the discussion on the DEV mailing list, it would be nice to make this configurable.
The thread on the mailing list is at - http://old.nabble.com/FTPServer-handling-of-multiple-concurrent-connections.-td28079420.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FTPSERVER-362) Add a configuration option for
maximum number of threads the server is allowed to create
Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853563#action_12853563 ]
Niklas Gustavsson commented on FTPSERVER-362:
---------------------------------------------
Looks good to me, let's get it in so we can do some further testing.
> Add a configuration option for maximum number of threads the server is allowed to create
> ----------------------------------------------------------------------------------------
>
> Key: FTPSERVER-362
> URL: https://issues.apache.org/jira/browse/FTPSERVER-362
> Project: FtpServer
> Issue Type: New Feature
> Components: Core
> Affects Versions: 1.0.0-M1, 1.0.0-M2, 1.0.0-M3, 1.0.0-M4, 1.0.0-RC1, 1.0.0-RC2, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4
> Reporter: Sai Pullabhotla
> Assignee: Sai Pullabhotla
> Fix For: 1.0.5
>
> Attachments: FTPSERVER-362.patch
>
>
> Currently the max threads are defaulted to 16. Based on the discussion on the DEV mailing list, it would be nice to make this configurable.
> The thread on the mailing list is at - http://old.nabble.com/FTPServer-handling-of-multiple-concurrent-connections.-td28079420.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FTPSERVER-362) Add a configuration option for
maximum number of threads the server is allowed to create
Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913448#action_12913448 ]
Niklas Gustavsson commented on FTPSERVER-362:
---------------------------------------------
Merged into 1.0.x in rev 999788.
> Add a configuration option for maximum number of threads the server is allowed to create
> ----------------------------------------------------------------------------------------
>
> Key: FTPSERVER-362
> URL: https://issues.apache.org/jira/browse/FTPSERVER-362
> Project: FtpServer
> Issue Type: New Feature
> Components: Core
> Affects Versions: 1.0.0-M1, 1.0.0-M2, 1.0.0-M3, 1.0.0-M4, 1.0.0-RC1, 1.0.0-RC2, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4
> Reporter: Sai Pullabhotla
> Assignee: Sai Pullabhotla
> Fix For: 1.0.5, 1.1.0
>
> Attachments: FTPSERVER-362.patch
>
>
> Currently the max threads are defaulted to 16. Based on the discussion on the DEV mailing list, it would be nice to make this configurable.
> The thread on the mailing list is at - http://old.nabble.com/FTPServer-handling-of-multiple-concurrent-connections.-td28079420.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FTPSERVER-362) Add a configuration option for
maximum number of threads the server is allowed to create
Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niklas Gustavsson updated FTPSERVER-362:
----------------------------------------
Fix Version/s: 1.0.5
> Add a configuration option for maximum number of threads the server is allowed to create
> ----------------------------------------------------------------------------------------
>
> Key: FTPSERVER-362
> URL: https://issues.apache.org/jira/browse/FTPSERVER-362
> Project: FtpServer
> Issue Type: New Feature
> Components: Core
> Affects Versions: 1.0.0-M1, 1.0.0-M2, 1.0.0-M3, 1.0.0-M4, 1.0.0-RC1, 1.0.0-RC2, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4
> Reporter: Sai Pullabhotla
> Assignee: Sai Pullabhotla
> Fix For: 1.0.5, 1.1.0
>
> Attachments: FTPSERVER-362.patch
>
>
> Currently the max threads are defaulted to 16. Based on the discussion on the DEV mailing list, it would be nice to make this configurable.
> The thread on the mailing list is at - http://old.nabble.com/FTPServer-handling-of-multiple-concurrent-connections.-td28079420.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FTPSERVER-362) Add a configuration option for
maximum number of threads the server is allowed to create
Posted by "Sai Pullabhotla (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sai Pullabhotla updated FTPSERVER-362:
--------------------------------------
Attachment: FTPSERVER-362.patch
For the most part I made the patch work like we have talked on the mailing list. However, a few things note:
If max-threads is explicitly set and is a positive integer, a thread pool of specified size will be created and shared across all listeners.
If max-threads is not explicitly set, but max-logins are set (explicit or implicit), then max-threads = max-logins
If max-threads is not explicitly set, and if the max-logins is set to zero (0) then max-threads become 16. This is due to the fact the we consider max-logins=0 as unlimited. I had to choose some default for max-threads and picked 16.
Let me know if this looks good and can be checked in.
Thanks.
> Add a configuration option for maximum number of threads the server is allowed to create
> ----------------------------------------------------------------------------------------
>
> Key: FTPSERVER-362
> URL: https://issues.apache.org/jira/browse/FTPSERVER-362
> Project: FtpServer
> Issue Type: New Feature
> Components: Core
> Affects Versions: 1.0.0-M1, 1.0.0-M2, 1.0.0-M3, 1.0.0-M4, 1.0.0-RC1, 1.0.0-RC2, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4
> Reporter: Sai Pullabhotla
> Fix For: 1.0.5
>
> Attachments: FTPSERVER-362.patch
>
>
> Currently the max threads are defaulted to 16. Based on the discussion on the DEV mailing list, it would be nice to make this configurable.
> The thread on the mailing list is at - http://old.nabble.com/FTPServer-handling-of-multiple-concurrent-connections.-td28079420.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FTPSERVER-362) Add a configuration option for
maximum number of threads the server is allowed to create
Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niklas Gustavsson updated FTPSERVER-362:
----------------------------------------
Fix Version/s: 1.1.0
(was: 1.0.5)
> Add a configuration option for maximum number of threads the server is allowed to create
> ----------------------------------------------------------------------------------------
>
> Key: FTPSERVER-362
> URL: https://issues.apache.org/jira/browse/FTPSERVER-362
> Project: FtpServer
> Issue Type: New Feature
> Components: Core
> Affects Versions: 1.0.0-M1, 1.0.0-M2, 1.0.0-M3, 1.0.0-M4, 1.0.0-RC1, 1.0.0-RC2, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4
> Reporter: Sai Pullabhotla
> Assignee: Sai Pullabhotla
> Fix For: 1.1.0
>
> Attachments: FTPSERVER-362.patch
>
>
> Currently the max threads are defaulted to 16. Based on the discussion on the DEV mailing list, it would be nice to make this configurable.
> The thread on the mailing list is at - http://old.nabble.com/FTPServer-handling-of-multiple-concurrent-connections.-td28079420.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FTPSERVER-362) Add a configuration option for
maximum number of threads the server is allowed to create
Posted by "Sai Pullabhotla (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sai Pullabhotla reassigned FTPSERVER-362:
-----------------------------------------
Assignee: Sai Pullabhotla
> Add a configuration option for maximum number of threads the server is allowed to create
> ----------------------------------------------------------------------------------------
>
> Key: FTPSERVER-362
> URL: https://issues.apache.org/jira/browse/FTPSERVER-362
> Project: FtpServer
> Issue Type: New Feature
> Components: Core
> Affects Versions: 1.0.0-M1, 1.0.0-M2, 1.0.0-M3, 1.0.0-M4, 1.0.0-RC1, 1.0.0-RC2, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4
> Reporter: Sai Pullabhotla
> Assignee: Sai Pullabhotla
> Fix For: 1.0.5
>
> Attachments: FTPSERVER-362.patch
>
>
> Currently the max threads are defaulted to 16. Based on the discussion on the DEV mailing list, it would be nice to make this configurable.
> The thread on the mailing list is at - http://old.nabble.com/FTPServer-handling-of-multiple-concurrent-connections.-td28079420.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FTPSERVER-362) Add a configuration option for
maximum number of threads the server is allowed to create
Posted by "Sai Pullabhotla (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853915#action_12853915 ]
Sai Pullabhotla commented on FTPSERVER-362:
-------------------------------------------
Okay, it is checked into the trunk. I created a patch out of the trunk, applied it to the 1.x branch, and when I do the DIFF, all new lines are messed up (converted to windows new lines). I'm not sure what the issue is, probably with the SVN plugin for MyEclipse. So, I did not check into the branch. Could one of you check it into the branch please?
Thanks.
> Add a configuration option for maximum number of threads the server is allowed to create
> ----------------------------------------------------------------------------------------
>
> Key: FTPSERVER-362
> URL: https://issues.apache.org/jira/browse/FTPSERVER-362
> Project: FtpServer
> Issue Type: New Feature
> Components: Core
> Affects Versions: 1.0.0-M1, 1.0.0-M2, 1.0.0-M3, 1.0.0-M4, 1.0.0-RC1, 1.0.0-RC2, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4
> Reporter: Sai Pullabhotla
> Assignee: Sai Pullabhotla
> Fix For: 1.0.5
>
> Attachments: FTPSERVER-362.patch
>
>
> Currently the max threads are defaulted to 16. Based on the discussion on the DEV mailing list, it would be nice to make this configurable.
> The thread on the mailing list is at - http://old.nabble.com/FTPServer-handling-of-multiple-concurrent-connections.-td28079420.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FTPSERVER-362) Add a configuration option for
maximum number of threads the server is allowed to create
Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niklas Gustavsson closed FTPSERVER-362.
---------------------------------------
Resolution: Fixed
> Add a configuration option for maximum number of threads the server is allowed to create
> ----------------------------------------------------------------------------------------
>
> Key: FTPSERVER-362
> URL: https://issues.apache.org/jira/browse/FTPSERVER-362
> Project: FtpServer
> Issue Type: New Feature
> Components: Core
> Affects Versions: 1.0.0-M1, 1.0.0-M2, 1.0.0-M3, 1.0.0-M4, 1.0.0-RC1, 1.0.0-RC2, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4
> Reporter: Sai Pullabhotla
> Assignee: Sai Pullabhotla
> Fix For: 1.1.0
>
> Attachments: FTPSERVER-362.patch
>
>
> Currently the max threads are defaulted to 16. Based on the discussion on the DEV mailing list, it would be nice to make this configurable.
> The thread on the mailing list is at - http://old.nabble.com/FTPServer-handling-of-multiple-concurrent-connections.-td28079420.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FTPSERVER-362) Add a configuration option for
maximum number of threads the server is allowed to create
Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906378#action_12906378 ]
Niklas Gustavsson commented on FTPSERVER-362:
---------------------------------------------
Let's keep this to 1.1.0, it's a pretty invasive patch to get into 1.0.5, and will also update the XML schema.
> Add a configuration option for maximum number of threads the server is allowed to create
> ----------------------------------------------------------------------------------------
>
> Key: FTPSERVER-362
> URL: https://issues.apache.org/jira/browse/FTPSERVER-362
> Project: FtpServer
> Issue Type: New Feature
> Components: Core
> Affects Versions: 1.0.0-M1, 1.0.0-M2, 1.0.0-M3, 1.0.0-M4, 1.0.0-RC1, 1.0.0-RC2, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4
> Reporter: Sai Pullabhotla
> Assignee: Sai Pullabhotla
> Fix For: 1.1.0
>
> Attachments: FTPSERVER-362.patch
>
>
> Currently the max threads are defaulted to 16. Based on the discussion on the DEV mailing list, it would be nice to make this configurable.
> The thread on the mailing list is at - http://old.nabble.com/FTPServer-handling-of-multiple-concurrent-connections.-td28079420.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.