You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/10 06:54:05 UTC
[GitHub] [incubator-superset] michellethomas commented on issue #6959: [WiP]
debugging and improving 'Time Table'
michellethomas commented on issue #6959: [WiP] debugging and improving 'Time Table'
URL: https://github.com/apache/incubator-superset/pull/6959#issuecomment-481558625
@mistercrunch have you dug into this anymore? We are running into the error `Converting circular structure to JSON` in 0.31 with adding anything to time table.
When I remove [this line](https://github.com/apache/incubator-superset/pull/6523/files#diff-11e98750ad920e62b68d5aadc8128f16R86) I don't get the error. It looks like all props are getting added to each object in `value`, which creates a circular reference where each object in `value` contains `value` (the list of time series column params). Do you remember why you were adding props to the control here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org