You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/03/11 22:46:39 UTC

[GitHub] [incubator-mxnet] reminisce commented on issue #17810: GraphExecutor + Numpy + Dynamic shape crash

reminisce commented on issue #17810: GraphExecutor + Numpy + Dynamic shape crash
URL: https://github.com/apache/incubator-mxnet/issues/17810#issuecomment-597917475
 
 
   This is because unknown shape `NDArray`s are assigned with default `storage_shape=(0,)`
   
   https://github.com/apache/incubator-mxnet/blob/713d962359cfe5b014ca24c0f9b3676d86b28569/include/mxnet/ndarray.h#L115-L120
   
   and dynamic shape workflow used this information as a condition for checking whether the ndarray has been allocated or not before NumPy shape semantics was added,
   
   https://github.com/apache/incubator-mxnet/blob/713d962359cfe5b014ca24c0f9b3676d86b28569/src/ndarray/ndarray.cc#L116-L121
   
   while in NumPy shape semantics, `(0,)` is treated as a known shape and thus leads to shape mismatch failure downstream.
   
   https://github.com/apache/incubator-mxnet/blob/713d962359cfe5b014ca24c0f9b3676d86b28569/src/executor/graph_executor.cc#L148-L152

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services