You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/11/18 13:07:50 UTC
Re: Review Request 71662: SSL Wrapper: Windows: Guarded the SSL-only
connect method.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71662/#review218659
-----------------------------------------------------------
Ship it!
Ship It!
- Benno Evers
On Oct. 23, 2019, 7:37 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71662/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2019, 7:37 p.m.)
>
>
> Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till Toenshoff.
>
>
> Bugs: MESOS-10009
> https://issues.apache.org/jira/browse/MESOS-10009
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the new SSL socket class wraps the PollSocket, the
> Windows version of the PollSocket needs to be guarded
> for SSL-only methods.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/windows/poll_socket.cpp e2a84694ac554b4c23242fd93d93800c0334a943
>
>
> Diff: https://reviews.apache.org/r/71662/diff/1/
>
>
> Testing
> -------
>
> cmake --build . --target process (Windows)
>
>
> Thanks,
>
> Joseph Wu
>
>