[GitHub] [tvm] lhutton1 commented on a diff in pull request #11519: [TFLite] Support quantized GREATER op in TFLite frontend

[GitBox <gi...@apache.org>]

lhutton1 commented on code in PR #11519:
URL: https://github.com/apache/tvm/pull/11519#discussion_r925348956


##########
tests/python/frontend/tflite/test_forward.py:
##########
@@ -2480,26 +2493,15 @@ def _test_forward_elemwise(testop):
     )
 
 
-def _test_forward_elemwise_quantized(testop):
-    if testop is not _test_equal:
-        testop(
-            [
-                np.array(np.random.uniform(0, 255, (3, 6)), dtype=np.uint8),
-                np.array(np.random.uniform(0, 255, (3, 6)), dtype=np.uint8),
-            ],
-            quantized=True,
-            qnn_op=testop,
-        )
-    else:
-        # no need for fake_quant to hold tensors in float32 until conversion
-        testop(
-            [
-                np.array(np.random.uniform(0, 255, (3, 6)), dtype=np.float32),
-                np.array(np.random.uniform(0, 255, (3, 6)), dtype=np.float32),
-            ],
-            quantized=True,
-            qnn_op=testop,
-        )
+def _test_forward_elemwise_quantized(testop, comparison_op=False):

Review Comment:
   Nit: looks like `comparison_op` here is not used, can we remove it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org