You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/01 06:56:50 UTC
[GitHub] [flink] xintongsong commented on a diff in pull request #20123: [FLINK-28310][rest] Introduce aggregating task metrics
xintongsong commented on code in PR #20123:
URL: https://github.com/apache/flink/pull/20123#discussion_r911663772
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/AggregatedTaskDetailsInfo.java:
##########
@@ -0,0 +1,265 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.rest.messages;
+
+import org.apache.flink.annotation.VisibleForTesting;
+import org.apache.flink.runtime.execution.ExecutionState;
+import org.apache.flink.runtime.rest.messages.job.SubtaskExecutionAttemptDetailsInfo;
+import org.apache.flink.runtime.rest.messages.job.metrics.IOMetricsInfo;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonCreator;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonProperty;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Comparator;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.stream.Collectors;
+
+/** Aggregated info of a set of tasks. */
+public class AggregatedTaskDetailsInfo implements ResponseBody {
+ public static final String FIELD_NAME_METRICS = "metrics";
+ public static final String FIELD_NAME_STATUS_DURATION = "status-duration";
+
+ private static final String[] metricsNames = {
+ IOMetricsInfo.FIELD_NAME_BYTES_READ,
+ IOMetricsInfo.FIELD_NAME_BYTES_WRITTEN,
+ IOMetricsInfo.FIELD_NAME_RECORDS_READ,
+ IOMetricsInfo.FIELD_NAME_RECORDS_WRITTEN,
+ IOMetricsInfo.FIELD_NAME_ACC_BACK_PRESSURE,
+ IOMetricsInfo.FIELD_NAME_ACC_BUSY,
+ IOMetricsInfo.FIELD_NAME_ACC_IDLE
+ };
+
+ private static final String[] statusNames = {
+ ExecutionState.CREATED.name(),
+ ExecutionState.SCHEDULED.name(),
+ ExecutionState.INITIALIZING.name(),
+ ExecutionState.DEPLOYING.name(),
+ ExecutionState.RUNNING.name()
+ };
+
+ @JsonProperty(FIELD_NAME_METRICS)
+ private final Map<String, Map<String, Long>> metrics;
+
+ @JsonProperty(FIELD_NAME_STATUS_DURATION)
+ private final Map<String, Map<String, Long>> statusDuration;
+
+ @JsonCreator
+ public AggregatedTaskDetailsInfo(
+ @JsonProperty(FIELD_NAME_METRICS) Map<String, Map<String, Long>> metrics,
+ @JsonProperty(FIELD_NAME_STATUS_DURATION)
+ Map<String, Map<String, Long>> statusDuration) {
+ this.metrics = Preconditions.checkNotNull(metrics);
+ this.statusDuration = Preconditions.checkNotNull(statusDuration);
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+
+ AggregatedTaskDetailsInfo that = (AggregatedTaskDetailsInfo) o;
+ return Objects.equals(metrics, that.metrics)
+ && Objects.equals(statusDuration, that.statusDuration);
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(metrics, statusDuration);
+ }
+
+ public static AggregatedTaskDetailsInfo create(
+ List<SubtaskExecutionAttemptDetailsInfo> subtaskInfo) {
+ return create(
+ subtaskInfo.stream()
+ .map(SubtaskExecutionAttemptDetailsInfo::getIoMetricsInfo)
+ .collect(Collectors.toList()),
+ subtaskInfo.stream()
+ .map(SubtaskExecutionAttemptDetailsInfo::getStatusDuration)
+ .collect(Collectors.toList()));
+ }
+
+ public static AggregatedTaskDetailsInfo create(
+ List<IOMetricsInfo> ioMetricsInfos, List<Map<ExecutionState, Long>> statusDurations) {
+ Map<String, MetricsStatistics> metrics = new HashMap<>();
+ Map<String, MetricsStatistics> statusDuration = new HashMap<>();
+ Arrays.stream(metricsNames).forEach(name -> metrics.put(name, new MetricsStatistics(name)));
+ Arrays.stream(statusNames)
+ .forEach(name -> statusDuration.put(name, new MetricsStatistics(name)));
+
+ ioMetricsInfos.forEach(
+ ioMetricsInfo -> {
+ metrics.get(IOMetricsInfo.FIELD_NAME_BYTES_READ)
+ .addValue(ioMetricsInfo.getBytesRead());
+ metrics.get(IOMetricsInfo.FIELD_NAME_BYTES_WRITTEN)
+ .addValue(ioMetricsInfo.getBytesWritten());
+ metrics.get(IOMetricsInfo.FIELD_NAME_RECORDS_READ)
+ .addValue(ioMetricsInfo.getRecordsRead());
+ metrics.get(IOMetricsInfo.FIELD_NAME_RECORDS_WRITTEN)
+ .addValue(ioMetricsInfo.getRecordsWritten());
+ metrics.get(IOMetricsInfo.FIELD_NAME_ACC_IDLE)
+ .addValue(ioMetricsInfo.getAccumulatedIdle());
+ metrics.get(IOMetricsInfo.FIELD_NAME_ACC_BACK_PRESSURE)
+ .addValue(ioMetricsInfo.getAccumulatedBackpressured());
+ if (!Double.isNaN(ioMetricsInfo.getAccumulatedBusy())) {
+ metrics.get(IOMetricsInfo.FIELD_NAME_ACC_BUSY)
+ .addValue((long) ioMetricsInfo.getAccumulatedBusy());
+ } else {
+ metrics.get(IOMetricsInfo.FIELD_NAME_ACC_BUSY).addValue(-1);
+ }
+ });
+
+ statusDurations.forEach(
+ status -> {
+ statusDuration
+ .get(ExecutionState.CREATED.name())
+ .addValue(status.get(ExecutionState.CREATED));
+ statusDuration
+ .get(ExecutionState.SCHEDULED.name())
+ .addValue(status.get(ExecutionState.SCHEDULED));
+ statusDuration
+ .get(ExecutionState.INITIALIZING.name())
+ .addValue(status.get(ExecutionState.INITIALIZING));
+ statusDuration
+ .get(ExecutionState.DEPLOYING.name())
+ .addValue(status.get(ExecutionState.DEPLOYING));
+ statusDuration
+ .get(ExecutionState.RUNNING.name())
+ .addValue(status.get(ExecutionState.RUNNING));
+ });
+ return new AggregatedTaskDetailsInfo(
+ metrics.values().stream()
+ .collect(
+ Collectors.toMap(
+ MetricsStatistics::getName, MetricsStatistics::toMap)),
+ statusDuration.values().stream()
+ .collect(
+ Collectors.toMap(
+ MetricsStatistics::getName, MetricsStatistics::toMap)));
+ }
+
+ @VisibleForTesting
+ static class MetricsStatistics {
+ private final List<Long> values = new ArrayList<>();
+ private final String name;
+ private boolean sorted = false;
+ private long sum = 0;
+
+ MetricsStatistics(String name) {
+ this.name = name;
+ }
+
+ void addValue(long value) {
+ values.add(value);
+ sum += value;
+ sorted = false;
+ }
+
+ private String getName() {
+ return name;
+ }
+
+ private Map<String, Long> toMap() {
+ Map<String, Long> result = new HashMap<>();
+ result.put("min", getMin());
+ result.put("max", getMax());
+ result.put("avg", getAvg());
+ result.put("sum", getSum());
+ result.put("median", getMedian());
+ result.put("p25", getP25());
+ result.put("p75", getP75());
+ result.put("p95", getP95());
+ return result;
+ }
+
+ long getMin() {
+ if (!sorted) {
+ values.sort(Comparator.naturalOrder());
+ sorted = true;
+ }
Review Comment:
This can be deduplicated.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/AggregatedTaskDetailsInfo.java:
##########
@@ -0,0 +1,265 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.rest.messages;
+
+import org.apache.flink.annotation.VisibleForTesting;
+import org.apache.flink.runtime.execution.ExecutionState;
+import org.apache.flink.runtime.rest.messages.job.SubtaskExecutionAttemptDetailsInfo;
+import org.apache.flink.runtime.rest.messages.job.metrics.IOMetricsInfo;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonCreator;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonProperty;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Comparator;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.stream.Collectors;
+
+/** Aggregated info of a set of tasks. */
+public class AggregatedTaskDetailsInfo implements ResponseBody {
+ public static final String FIELD_NAME_METRICS = "metrics";
+ public static final String FIELD_NAME_STATUS_DURATION = "status-duration";
+
+ private static final String[] metricsNames = {
+ IOMetricsInfo.FIELD_NAME_BYTES_READ,
+ IOMetricsInfo.FIELD_NAME_BYTES_WRITTEN,
+ IOMetricsInfo.FIELD_NAME_RECORDS_READ,
+ IOMetricsInfo.FIELD_NAME_RECORDS_WRITTEN,
+ IOMetricsInfo.FIELD_NAME_ACC_BACK_PRESSURE,
+ IOMetricsInfo.FIELD_NAME_ACC_BUSY,
+ IOMetricsInfo.FIELD_NAME_ACC_IDLE
+ };
+
+ private static final String[] statusNames = {
+ ExecutionState.CREATED.name(),
+ ExecutionState.SCHEDULED.name(),
+ ExecutionState.INITIALIZING.name(),
+ ExecutionState.DEPLOYING.name(),
+ ExecutionState.RUNNING.name()
+ };
+
+ @JsonProperty(FIELD_NAME_METRICS)
+ private final Map<String, Map<String, Long>> metrics;
+
+ @JsonProperty(FIELD_NAME_STATUS_DURATION)
+ private final Map<String, Map<String, Long>> statusDuration;
+
+ @JsonCreator
+ public AggregatedTaskDetailsInfo(
+ @JsonProperty(FIELD_NAME_METRICS) Map<String, Map<String, Long>> metrics,
+ @JsonProperty(FIELD_NAME_STATUS_DURATION)
+ Map<String, Map<String, Long>> statusDuration) {
+ this.metrics = Preconditions.checkNotNull(metrics);
+ this.statusDuration = Preconditions.checkNotNull(statusDuration);
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+
+ AggregatedTaskDetailsInfo that = (AggregatedTaskDetailsInfo) o;
+ return Objects.equals(metrics, that.metrics)
+ && Objects.equals(statusDuration, that.statusDuration);
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(metrics, statusDuration);
+ }
+
+ public static AggregatedTaskDetailsInfo create(
+ List<SubtaskExecutionAttemptDetailsInfo> subtaskInfo) {
+ return create(
+ subtaskInfo.stream()
+ .map(SubtaskExecutionAttemptDetailsInfo::getIoMetricsInfo)
+ .collect(Collectors.toList()),
+ subtaskInfo.stream()
+ .map(SubtaskExecutionAttemptDetailsInfo::getStatusDuration)
+ .collect(Collectors.toList()));
+ }
+
+ public static AggregatedTaskDetailsInfo create(
+ List<IOMetricsInfo> ioMetricsInfos, List<Map<ExecutionState, Long>> statusDurations) {
+ Map<String, MetricsStatistics> metrics = new HashMap<>();
+ Map<String, MetricsStatistics> statusDuration = new HashMap<>();
+ Arrays.stream(metricsNames).forEach(name -> metrics.put(name, new MetricsStatistics(name)));
+ Arrays.stream(statusNames)
+ .forEach(name -> statusDuration.put(name, new MetricsStatistics(name)));
+
+ ioMetricsInfos.forEach(
+ ioMetricsInfo -> {
+ metrics.get(IOMetricsInfo.FIELD_NAME_BYTES_READ)
+ .addValue(ioMetricsInfo.getBytesRead());
+ metrics.get(IOMetricsInfo.FIELD_NAME_BYTES_WRITTEN)
+ .addValue(ioMetricsInfo.getBytesWritten());
+ metrics.get(IOMetricsInfo.FIELD_NAME_RECORDS_READ)
+ .addValue(ioMetricsInfo.getRecordsRead());
+ metrics.get(IOMetricsInfo.FIELD_NAME_RECORDS_WRITTEN)
+ .addValue(ioMetricsInfo.getRecordsWritten());
+ metrics.get(IOMetricsInfo.FIELD_NAME_ACC_IDLE)
+ .addValue(ioMetricsInfo.getAccumulatedIdle());
+ metrics.get(IOMetricsInfo.FIELD_NAME_ACC_BACK_PRESSURE)
+ .addValue(ioMetricsInfo.getAccumulatedBackpressured());
+ if (!Double.isNaN(ioMetricsInfo.getAccumulatedBusy())) {
+ metrics.get(IOMetricsInfo.FIELD_NAME_ACC_BUSY)
+ .addValue((long) ioMetricsInfo.getAccumulatedBusy());
+ } else {
+ metrics.get(IOMetricsInfo.FIELD_NAME_ACC_BUSY).addValue(-1);
+ }
+ });
+
+ statusDurations.forEach(
+ status -> {
+ statusDuration
+ .get(ExecutionState.CREATED.name())
+ .addValue(status.get(ExecutionState.CREATED));
+ statusDuration
+ .get(ExecutionState.SCHEDULED.name())
+ .addValue(status.get(ExecutionState.SCHEDULED));
+ statusDuration
+ .get(ExecutionState.INITIALIZING.name())
+ .addValue(status.get(ExecutionState.INITIALIZING));
+ statusDuration
+ .get(ExecutionState.DEPLOYING.name())
+ .addValue(status.get(ExecutionState.DEPLOYING));
+ statusDuration
+ .get(ExecutionState.RUNNING.name())
+ .addValue(status.get(ExecutionState.RUNNING));
+ });
+ return new AggregatedTaskDetailsInfo(
+ metrics.values().stream()
+ .collect(
+ Collectors.toMap(
+ MetricsStatistics::getName, MetricsStatistics::toMap)),
+ statusDuration.values().stream()
+ .collect(
+ Collectors.toMap(
+ MetricsStatistics::getName, MetricsStatistics::toMap)));
+ }
+
+ @VisibleForTesting
+ static class MetricsStatistics {
+ private final List<Long> values = new ArrayList<>();
+ private final String name;
+ private boolean sorted = false;
+ private long sum = 0;
+
+ MetricsStatistics(String name) {
+ this.name = name;
+ }
+
+ void addValue(long value) {
+ values.add(value);
+ sum += value;
+ sorted = false;
+ }
+
+ private String getName() {
+ return name;
+ }
+
+ private Map<String, Long> toMap() {
+ Map<String, Long> result = new HashMap<>();
+ result.put("min", getMin());
+ result.put("max", getMax());
+ result.put("avg", getAvg());
+ result.put("sum", getSum());
+ result.put("median", getMedian());
+ result.put("p25", getP25());
+ result.put("p75", getP75());
+ result.put("p95", getP95());
+ return result;
+ }
+
+ long getMin() {
+ if (!sorted) {
+ values.sort(Comparator.naturalOrder());
+ sorted = true;
+ }
+ return values.isEmpty() ? 0 : values.get(0);
+ }
+
+ long getMax() {
+ if (!sorted) {
+ values.sort(Comparator.naturalOrder());
+ sorted = true;
+ }
+ return values.isEmpty() ? 0 : values.get(values.size() - 1);
+ }
+
+ long getMedian() {
+ if (!sorted) {
+ values.sort(Comparator.naturalOrder());
+ sorted = true;
+ }
+ return values.isEmpty() ? 0 : values.get(values.size() / 2);
+ }
+
+ long getP25() {
+ if (!sorted) {
+ values.sort(Comparator.naturalOrder());
+ sorted = true;
+ }
+ return values.isEmpty()
+ ? 0
+ : values.get(
+ Math.min(values.size() - 1, (int) Math.rint(values.size() * 0.25)));
Review Comment:
This is a very common calculation. I wonder if we can leverage some existing libraries. E.g., I find `org.apache.commons.math3.stat.descriptive.rank.Percentile` which might fit our needs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org