You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Avery Ching (JIRA)" <ji...@apache.org> on 2011/09/20 00:30:08 UTC
[jira] [Created] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Adding checkstyle enforcement of Giraph code conventions
--------------------------------------------------------
Key: GIRAPH-40
URL: https://issues.apache.org/jira/browse/GIRAPH-40
Project: Giraph
Issue Type: New Feature
Reporter: Avery Ching
Priority: Minor
Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Avery Ching (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching updated GIRAPH-40:
------------------------------
Attachment: GIRAPH-40.patch
I began with the commons-math checkstyle file and added and removed checks until I got to the closest interpretation of our CODE_CONVENTIONS. This is mostly pretty close to our CODE_CONVENTIONS with a few exceptions.
I have formatted a few files and to show folks. If you guys like it, I'll format the entire Giraph codebase and make this checkstyle enforceable.
I really believe that adding checkstyle will make our contribution process more smooth and allow us to work faster.
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Minor
> Attachments: GIRAPH-40.patch
>
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Avery Ching (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199935#comment-13199935 ]
Avery Ching commented on GIRAPH-40:
-----------------------------------
What I meant and am working on, is failing the build when checkstyle errors occur. For now, I am going through and fixing the checkstyle.xml I have and adjusting code, then will submit a patch with the checkstyle.xml and all the warnings fixed. Then, going forward, we will not have to deal with many formatting issues for patches. Well, that's the goal anyway. =)
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Priority: Minor
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Avery Ching (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209801#comment-13209801 ]
Avery Ching commented on GIRAPH-40:
-----------------------------------
Thanks so much for the reviews Jakob and Sebastian. It's committed.
@Sebastian, 'mvn compile' and 'mvn package' will succeed with violations. Anything using 'verify', i.e. 'mvn verify' or 'mvn install' will hit problems with checkstyle and rat.
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Minor
> Attachments: GIRAPH-40.2.patch, GIRAPH-40.3.patch, GIRAPH-40.patch, GIRAPH-40.patch
>
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Avery Ching (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206291#comment-13206291 ]
Avery Ching commented on GIRAPH-40:
-----------------------------------
Thank you for the feedback Claudio. I'll continue to transition the other files and submit a final patch unless anyone has any objections.
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Minor
> Attachments: GIRAPH-40.patch
>
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Avery Ching (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207203#comment-13207203 ]
Avery Ching commented on GIRAPH-40:
-----------------------------------
I'm not a checkstyle expert, but I don't think so. I can play around with trying to fix that. Or we can fix in another issue. I should be done with this patch today.
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Minor
> Attachments: GIRAPH-40.patch
>
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Avery Ching (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching updated GIRAPH-40:
------------------------------
Attachment: GIRAPH-40.patch
As promised, here is the full patch. Due to its massive size, I am not posting this to reviewboard. Here are the details of what I did:
* Created a checkstyle.xml file that follows our CODE_CONVENTIONS as best as possible.
* Compiles will now fail if checkstyle guidelines are not met.
* While checkstyle isn't comprehensive, it should reduce our reviewer overhead for formatting issues and common code style violations
* Current source code (not test code) now meets checkstyle checks
It passes both the local and MR unittests and also passes rat installation.
Take a look at a few files. I don't recommend looking at everything since
$ git diff HEAD^ | grep -P "^(\+|\-)" | wc -l
32848
Let's get this in soon to help us iterate faster and get rid of this technical debt!
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Minor
> Attachments: GIRAPH-40.patch, GIRAPH-40.patch
>
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Avery Ching (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching resolved GIRAPH-40.
-------------------------------
Resolution: Fixed
Hudson reported success, closing.
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Minor
> Attachments: GIRAPH-40.2.patch, GIRAPH-40.3.patch, GIRAPH-40.patch, GIRAPH-40.patch
>
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Claudio Martella (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206076#comment-13206076 ]
Claudio Martella commented on GIRAPH-40:
----------------------------------------
I already work with different coding styles in different projects, so I'm passed the concept of "the right coding style" meaning that I can live with these drawbacks. If this is the most we can do, I'm +1.
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Minor
> Attachments: GIRAPH-40.patch
>
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Jakob Homan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207205#comment-13207205 ]
Jakob Homan commented on GIRAPH-40:
-----------------------------------
OK. If we can fix it later, it'll be less traumatic than the patch coming today since it'll just apply to method signatures...
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Minor
> Attachments: GIRAPH-40.patch
>
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Avery Ching (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205976#comment-13205976 ]
Avery Ching commented on GIRAPH-40:
-----------------------------------
Here are some examples of one problem: Checkstyle doesn't seem to be able to handle single indent versus double indent of 2 spaces when appropriate. The below examples are what Checkstyle wants to have us do.
{noformat}
@Override
public BasicVertex<LongWritable, DoubleWritable, DoubleWritable, M>
getCurrentVertex() throws IOException, InterruptedException {
@Override
public VertexReader<LongWritable, DoubleWritable, DoubleWritable, M>
createVertexReader(InputSplit split, TaskAttemptContext context)
throws IOException {
{noformat}
Also, checkstyle won't enforce indenting after a line wrap. So both of these examples are passing checkstyle.
{noformat}
aggregateVertices =
configuration.getLong(
PseudoRandomVertexInputFormat.AGGREGATE_VERTICES, 0);
aggregateVertices =
configuration.getLong(
PseudoRandomVertexInputFormat.AGGREGATE_VERTICES, 0);
{noformat}
That being said, I think this is the right thing to do and we can make some sacrifices to have better, more uniform code. Please let me know your thoughts.
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Minor
> Attachments: GIRAPH-40.patch
>
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Jakob Homan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208731#comment-13208731 ]
Jakob Homan commented on GIRAPH-40:
-----------------------------------
ok, looks good to me. +1. However, since no one can do a full review of this patch, I'd like another committer to +1 it as well before committing. This helps us to explain away not actually doing a full review.
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Minor
> Attachments: GIRAPH-40.2.patch, GIRAPH-40.patch, GIRAPH-40.patch
>
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Avery Ching (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199938#comment-13199938 ]
Avery Ching commented on GIRAPH-40:
-----------------------------------
By the way Claudio, I think several IDEs have support for checkstyle (i.e. Eclipse and Intellij).
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Minor
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Avery Ching (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207188#comment-13207188 ]
Avery Ching commented on GIRAPH-40:
-----------------------------------
So for the first example, we need to follow that format, or else checkstyle will mark it an error.
For the second examples, checkstyle doesn't seem to enforce the line wrap indent. So we need to still keep an eye out for those issues.
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Minor
> Attachments: GIRAPH-40.patch
>
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209814#comment-13209814 ]
Hudson commented on GIRAPH-40:
------------------------------
Integrated in Giraph-trunk-Commit #83 (See [https://builds.apache.org/job/Giraph-trunk-Commit/83/])
GIRAPH-40: Added checkstyle for enforcement of code conventions. All
Giraph source files now pass checkstyle. (aching). (Revision 1245205)
Result = SUCCESS
aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245205
Files :
* /incubator/giraph/trunk/CHANGELOG
* /incubator/giraph/trunk/checkstyle.xml
* /incubator/giraph/trunk/license-header.txt
* /incubator/giraph/trunk/pom.xml
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/GiraphRunner.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/HashMapVertexPageRankBenchmark.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PageRankComputation.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/RandomMessageBenchmark.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/package-info.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/ApplicationState.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/BspInputFormat.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/BspInputSplit.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/BspOutputFormat.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/BspRecordReader.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/BspRecordWriter.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedService.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedServiceMaster.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/ImmutableOutputCommitter.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/SuperstepState.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/package-info.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/ArrayListWritable.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/CommunicationsInterface.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/MsgList.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/RPCCommunications.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/ServerInterface.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/VertexIdMessages.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/VertexIdMessagesList.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/VertexList.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/WorkerCommunications.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/package-info.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/ConnectedComponentsVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/GeneratedVertexInputFormat.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/GeneratedVertexReader.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/IntIntNullIntTextInputFormat.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/LongSumAggregator.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/MaxAggregator.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/MinAggregator.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/MinimumIntCombiner.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleAggregatorWriter.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCombinerVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleFailVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleMsgVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleMutateGraphVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleShortestPathsVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleSumCombiner.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleSuperstepVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleTextVertexOutputFormat.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleVertexWithWorkerContext.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SumAggregator.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/VerifyMessage.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/VertexWithComponentTextOutputFormat.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/package-info.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/Aggregator.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/AggregatorUsage.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/AggregatorWriter.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertexResolver.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspService.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceMaster.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspUtils.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/DefaultWorkerContext.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/Edge.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/EdgeListVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GiraphJob.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GlobalStats.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GraphState.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/HashMapVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/IntIntNullIntVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/LongDoubleFloatDoubleVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/MasterThread.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/MutableVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/TextAggregatorWriter.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexChanges.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexCombiner.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexEdgeCount.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexInputFormat.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexMutations.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexOutputFormat.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexReader.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexResolver.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexWriter.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/WorkerContext.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/WorkerInfo.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/package-info.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/BasicPartitionOwner.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/GraphPartitionerFactory.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/HashMasterPartitioner.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/HashPartitionerFactory.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/HashRangePartitionerFactory.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/HashRangeWorkerPartitioner.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/HashWorkerPartitioner.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/MasterGraphPartitioner.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/Partition.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/PartitionBalancer.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/PartitionExchange.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/PartitionOwner.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/PartitionStats.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/PartitionUtils.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/RangeMasterPartitioner.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/RangePartitionOwner.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/RangePartitionStats.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/RangeSplitHint.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/RangeWorkerPartitioner.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/WorkerGraphPartitioner.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/package-info.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/hadoop/BspPolicyProvider.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/hadoop/BspTokenSelector.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/hadoop/package-info.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/integration/SuperstepHashPartitionerFactory.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/integration/package-info.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/AdjacencyListTextVertexOutputFormat.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/AdjacencyListVertexReader.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/IdWithValueTextOutputFormat.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/JsonBase64VertexFormat.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/JsonBase64VertexInputFormat.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/JsonBase64VertexOutputFormat.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/LongDoubleDoubleAdjacencyListVertexInputFormat.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/SequenceFileVertexInputFormat.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/TextDoubleDoubleAdjacencyListVertexInputFormat.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/TextVertexInputFormat.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/TextVertexOutputFormat.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/package-info.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/package-info.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/utils/ComparisonUtils.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/utils/EmptyIterable.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/utils/MemoryUtils.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/utils/ReflectionUtils.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/utils/UnmodifiableIntArrayIterator.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/utils/WritableUtils.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/utils/package-info.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/zk/BspEvent.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/zk/ContextLock.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/zk/PredicateLock.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/zk/ZooKeeperExt.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/zk/ZooKeeperManager.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/zk/package-info.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestBspBasic.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestJsonBase64Format.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestManualCheckpoint.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/examples/SimpleShortestPathVertexTest.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/graph/TestEdgeListVertex.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/utils/MockUtils.java
* /incubator/giraph/trunk/src/test/java/zk/TestZooKeeperManager.java
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Minor
> Attachments: GIRAPH-40.2.patch, GIRAPH-40.3.patch, GIRAPH-40.patch, GIRAPH-40.patch
>
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Avery Ching (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching updated GIRAPH-40:
------------------------------
Attachment: GIRAPH-40.3.patch
Good suggestion, Jakob. I have addressed Jakob's comments by changing phases from 'compile'->'verify' for checkstyle. This is the only change I made.
{noquote}
<execution>
- <phase>compile</phase>
+ <phase>verify</phase>
<goals>
{noquote}
We need to require our users to have tested with 'mvn verify' (or 'mvn install') before submitting diffs. This matches the rat approach.
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Minor
> Attachments: GIRAPH-40.2.patch, GIRAPH-40.3.patch, GIRAPH-40.patch, GIRAPH-40.patch
>
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Jakob Homan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208786#comment-13208786 ]
Jakob Homan commented on GIRAPH-40:
-----------------------------------
Thanks. +1 on latest patch, while still hoping to get another committer to take a look.
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Minor
> Attachments: GIRAPH-40.2.patch, GIRAPH-40.3.patch, GIRAPH-40.patch, GIRAPH-40.patch
>
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Jakob Homan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208750#comment-13208750 ]
Jakob Homan commented on GIRAPH-40:
-----------------------------------
Actually, I have a concern:
> Compiles will now fail if checkstyle guidelines are not met.
I tested this and it's true. This means that if you have an extra space in an if statement, you can't compile, even if you're planning to clean up the code later. This is going to be a huge problem. During development the code has to *always* pass checkstyle, not just when submitting a patch. Is there a way to turn this off for compile and just run checkstyle during a specific run? This would mean that it would be up to the submitted and committer to verify correctness, exactly as is required currently with rat... I have to withdraw my -1.
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Minor
> Attachments: GIRAPH-40.2.patch, GIRAPH-40.patch, GIRAPH-40.patch
>
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Jakob Homan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207195#comment-13207195 ]
Jakob Homan commented on GIRAPH-40:
-----------------------------------
bq. So for the first example, we need to follow that format, or else checkstyle will mark it an error.
Blech. -0.9... That's a big change from what we agreed on earlier. Can that particular check be turned off?
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Minor
> Attachments: GIRAPH-40.patch
>
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Harsh J (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199787#comment-13199787 ]
Harsh J commented on GIRAPH-40:
-------------------------------
By enforce do you mean it ought to touch source files upon running of the target or just spew warns?
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Priority: Minor
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Avery Ching (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching reassigned GIRAPH-40:
---------------------------------
Assignee: Avery Ching
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Minor
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Avery Ching (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209727#comment-13209727 ]
Avery Ching commented on GIRAPH-40:
-----------------------------------
Can another committer please look at this as per Jakob's request?
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Minor
> Attachments: GIRAPH-40.2.patch, GIRAPH-40.3.patch, GIRAPH-40.patch, GIRAPH-40.patch
>
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Avery Ching (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206761#comment-13206761 ]
Avery Ching commented on GIRAPH-40:
-----------------------------------
Just a quick update. There are a lot of formatting changes. I should be done tomorrow with the src directory. I will submit a diff, but I doubt anyone will really read it...just hopefully look at a few files and make sure it's what folks expect.
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Minor
> Attachments: GIRAPH-40.patch
>
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Jakob Homan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207185#comment-13207185 ]
Jakob Homan commented on GIRAPH-40:
-----------------------------------
bq. The below examples are what Checkstyle wants to have us do.
So does that mean code not in that hideous style will be flagged by Checkstyle? I'm confused by the next example you posted, which says Checkstyle won't enforce indenting post line wrap...
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Minor
> Attachments: GIRAPH-40.patch
>
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Claudio Martella (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199806#comment-13199806 ]
Claudio Martella commented on GIRAPH-40:
----------------------------------------
I'm pretty much in favor of this, it's making part of contribution process complicated.
I think though, to simplify the process, we might/should provide style configs for Eclipse/Netbeans to be used by contributors, or for an external formatting tool (jindent, jalopy, jakobe etc.).
Here's a list of tools:
http://mindprod.com/jgloss/beautifier.html
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Priority: Minor
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Sebastian Schelter (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209741#comment-13209741 ]
Sebastian Schelter commented on GIRAPH-40:
------------------------------------------
Had a quick look, if it is ensured that one can build the project even with violations of the coding style (for development), I'm +1 on this too.
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Minor
> Attachments: GIRAPH-40.2.patch, GIRAPH-40.3.patch, GIRAPH-40.patch, GIRAPH-40.patch
>
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-40) Adding checkstyle enforcement of
Giraph code conventions
Posted by "Avery Ching (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching updated GIRAPH-40:
------------------------------
Attachment: GIRAPH-40.2.patch
I looked at the Hadoop checkstyle file and found it to be more orderly. I have taken this checkstyle.xml file and organized it better. Additionally, I added a few Hadoop checks that I found in the Hadoop checkstyle file that improve our code as well.
Can someone please take a look? Thanks!
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
> Key: GIRAPH-40
> URL: https://issues.apache.org/jira/browse/GIRAPH-40
> Project: Giraph
> Issue Type: New Feature
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Minor
> Attachments: GIRAPH-40.2.patch, GIRAPH-40.patch, GIRAPH-40.patch
>
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira