You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@esme.apache.org by Richard Hirsch <hi...@gmail.com> on 2011/05/02 10:40:18 UTC
1.3 status
I was looking at the looking at 1.3 status this morning and I have a
few questions:
@Ethan - can we close ESME-328 "Rewrite the comet timeline"?
@Vladimir is "ESME-332 "There are still some problems with SBT tests"
still valid after the SBT upgrade?
@Vladimir can we close "ESME-321 Get rid of deprecated methods"? I
wasn't sure how many deprecated methods will still present.
D.
Re: 1.3 status
Posted by Ethan Jewett <es...@gmail.com>.
Hi,
I think if the enabled parameter isn't provided then it should remain
as currently set. Using "openOr true" will result in disabled actions
being enabled if the parameter isn't provided, so not quite right but
on the right track I think.
I'll check out the IE9 issue on Windows 7 32-bit when I get to work
today. Hopefully it is still a non-issue :-)
Cheers,
Ethan
On Sunday, May 15, 2011, Richard Hirsch <hi...@gmail.com> wrote:
> Looking at other items for 1.3:
>
> -------------
>
> [ESME-245] <https://issues.apache.org/jira/browse/ESME-245>
>
> Change in API2.scala / line 506
>
> enabled <- S.param("enabled").map(toBoolean) ?~
> S.?("base_rest_api_err_missing_param", "enable"))
>
> ?~ S.?("base_rest_api_err_missing_param", "enable")) is wrong need to
> default to true if present: "openor true"
>
> ----------------------------------
>
> On Sun, May 15, 2011 at 8:11 PM, Ethan Jewett <es...@gmail.com> wrote:
>> This is now complete, as people may have noticed. And just in time to make
>> it into Dick's latest deploy :-)
>>
>> So, do we still have any blocking issues or can we try to evaluate what we
>> see on the latest deploy to figure out if we are ready for release? I think
>> the following might be blockers:
>>
>> ESME-342 <https://issues.apache.org/jira/browse/ESME-342>
>>
>> Sign On button doesn't work in
>> IE9<https://issues.apache.org/jira/browse/ESME-342>
>> ESME-282 <https://issues.apache.org/jira/browse/ESME-282>
>>
>> When a public message is resent by one user, no other users are able to
>> resend it <https://issues.apache.org/jira/browse/ESME-282>
>>
>> ESME-282 needs to get fixed, but it probably isn't a major issue. ESME-342
>> sounds like a bigger problem.
>
> Let me take a look at 342 - I once had a similar problem with Chrome
> but it appears to have since disappeared. I don't have IE9 on my work
> machine, so I can't try it out until I get home.
>
>
>>
>> Ethan
>>
>> On Tue, May 3, 2011 at 5:00 PM, Richard Hirsch <hi...@gmail.com>wrote:
>>
>>> @Ethan - that's fine - no rush. I'm just trying to keep up the momentum.
>>>
>>> D.
>>>
>>> On Tue, May 3, 2011 at 9:39 AM, Ethan Jewett <es...@gmail.com> wrote:
>>> > Hi Dick,
>>> >
>>> > On ESME-328, we still have a todo around display of message times. This
>>> is
>>> > more complicated than I thought, but I do have a strategy now, and I'll
>>> > address ESME-308 at the same time, I hope.
>>> >
>>> > When are we looking to release? I'm on vacation this week without my
>>> > computer but I should be able to finish this issue next week. If someone
>>> > else wants to do it this week that would be great as well.
>>> >
>>> > Thanks,
>>> > Ethan
>>> >
>>> >
>>> > On Mon, May 2, 2011 at 10:40 AM, Richard Hirsch <hirsch.dick@gmail.com
>>> >wrote:
>>> >
>>> >> I was looking at the looking at 1.3 status this morning and I have a
>>> >> few questions:
>>> >>
>>> >> @Ethan - can we close ESME-328 "Rewrite the comet timeline"?
>>> >>
>>> >> @Vladimir is "ESME-332 "There are still some problems with SBT tests"
>>> >> still valid after the SBT upgrade?
>>> >>
>>> >> @Vladimir can we close "ESME-321 Get rid of deprecated methods"? I
>>> >> wasn't sure how many deprecated methods will still present.
>>> >>
>>> >> D.
>>> >>
>>> >
>>>
>>
>
Re: 1.3 status
Posted by Richard Hirsch <hi...@gmail.com>.
Looking at other items for 1.3:
-------------
[ESME-245] <https://issues.apache.org/jira/browse/ESME-245>
Change in API2.scala / line 506
enabled <- S.param("enabled").map(toBoolean) ?~
S.?("base_rest_api_err_missing_param", "enable"))
?~ S.?("base_rest_api_err_missing_param", "enable")) is wrong need to
default to true if present: "openor true"
----------------------------------
On Sun, May 15, 2011 at 8:11 PM, Ethan Jewett <es...@gmail.com> wrote:
> This is now complete, as people may have noticed. And just in time to make
> it into Dick's latest deploy :-)
>
> So, do we still have any blocking issues or can we try to evaluate what we
> see on the latest deploy to figure out if we are ready for release? I think
> the following might be blockers:
>
> ESME-342 <https://issues.apache.org/jira/browse/ESME-342>
>
> Sign On button doesn't work in
> IE9<https://issues.apache.org/jira/browse/ESME-342>
> ESME-282 <https://issues.apache.org/jira/browse/ESME-282>
>
> When a public message is resent by one user, no other users are able to
> resend it <https://issues.apache.org/jira/browse/ESME-282>
>
> ESME-282 needs to get fixed, but it probably isn't a major issue. ESME-342
> sounds like a bigger problem.
Let me take a look at 342 - I once had a similar problem with Chrome
but it appears to have since disappeared. I don't have IE9 on my work
machine, so I can't try it out until I get home.
>
> Ethan
>
> On Tue, May 3, 2011 at 5:00 PM, Richard Hirsch <hi...@gmail.com>wrote:
>
>> @Ethan - that's fine - no rush. I'm just trying to keep up the momentum.
>>
>> D.
>>
>> On Tue, May 3, 2011 at 9:39 AM, Ethan Jewett <es...@gmail.com> wrote:
>> > Hi Dick,
>> >
>> > On ESME-328, we still have a todo around display of message times. This
>> is
>> > more complicated than I thought, but I do have a strategy now, and I'll
>> > address ESME-308 at the same time, I hope.
>> >
>> > When are we looking to release? I'm on vacation this week without my
>> > computer but I should be able to finish this issue next week. If someone
>> > else wants to do it this week that would be great as well.
>> >
>> > Thanks,
>> > Ethan
>> >
>> >
>> > On Mon, May 2, 2011 at 10:40 AM, Richard Hirsch <hirsch.dick@gmail.com
>> >wrote:
>> >
>> >> I was looking at the looking at 1.3 status this morning and I have a
>> >> few questions:
>> >>
>> >> @Ethan - can we close ESME-328 "Rewrite the comet timeline"?
>> >>
>> >> @Vladimir is "ESME-332 "There are still some problems with SBT tests"
>> >> still valid after the SBT upgrade?
>> >>
>> >> @Vladimir can we close "ESME-321 Get rid of deprecated methods"? I
>> >> wasn't sure how many deprecated methods will still present.
>> >>
>> >> D.
>> >>
>> >
>>
>
Re: 1.3 status
Posted by Vladimir Ivanov <le...@gmail.com>.
I have Win7 x64 as a secondary OS, but I use Fedora to work with development
tasks.
I remembered that I found this issue on Stax. So I've just tested it again
and it's not reproduced. I have no idea why it hadn't worked before - either
IE was updated or it were some local problems...
I'll change status of this issue to 'Cannot reproduce'.
Vladimir
2011/5/16 Richard Hirsch <hi...@gmail.com>
> I also have Vista at home - so we need a test environment with Win7....
>
> D.
>
> On Sun, May 15, 2011 at 7:45 PM, Vladimir Ivanov <le...@gmail.com>
> wrote:
> > Hello Ethan,
> >
> > You made a great work rewriting Timelines with CSS selectors - thanks!
> >
> > Regarding ESME-342 - has someone reproduced it locally too? I've just
> tested
> > it with IE9 on Win Vista 32 bit and it worked! But also tested it a while
> > ago on IE9 with Win7 64-bit and I'm pretty sure it didn't work - that's
> why
> > I created this issue.
> >
> > Vladimir
> >
> > 2011/5/15 Ethan Jewett <es...@gmail.com>
> >
> >> This is now complete, as people may have noticed. And just in time to
> make
> >> it into Dick's latest deploy :-)
> >>
> >> So, do we still have any blocking issues or can we try to evaluate what
> we
> >> see on the latest deploy to figure out if we are ready for release? I
> think
> >> the following might be blockers:
> >>
> >> ESME-342 <https://issues.apache.org/jira/browse/ESME-342>
> >>
> >> Sign On button doesn't work in
> >> IE9<https://issues.apache.org/jira/browse/ESME-342>
> >> ESME-282 <https://issues.apache.org/jira/browse/ESME-282>
> >>
> >> When a public message is resent by one user, no other users are able to
> >> resend it <https://issues.apache.org/jira/browse/ESME-282>
> >>
> >> ESME-282 needs to get fixed, but it probably isn't a major issue.
> ESME-342
> >> sounds like a bigger problem.
> >>
> >> Ethan
> >>
> >> On Tue, May 3, 2011 at 5:00 PM, Richard Hirsch <hirsch.dick@gmail.com
> >> >wrote:
> >>
> >> > @Ethan - that's fine - no rush. I'm just trying to keep up the
> momentum.
> >> >
> >> > D.
> >> >
> >> > On Tue, May 3, 2011 at 9:39 AM, Ethan Jewett <es...@gmail.com>
> wrote:
> >> > > Hi Dick,
> >> > >
> >> > > On ESME-328, we still have a todo around display of message times.
> This
> >> > is
> >> > > more complicated than I thought, but I do have a strategy now, and
> I'll
> >> > > address ESME-308 at the same time, I hope.
> >> > >
> >> > > When are we looking to release? I'm on vacation this week without my
> >> > > computer but I should be able to finish this issue next week. If
> >> someone
> >> > > else wants to do it this week that would be great as well.
> >> > >
> >> > > Thanks,
> >> > > Ethan
> >> > >
> >> > >
> >> > > On Mon, May 2, 2011 at 10:40 AM, Richard Hirsch <
> hirsch.dick@gmail.com
> >> > >wrote:
> >> > >
> >> > >> I was looking at the looking at 1.3 status this morning and I have
> a
> >> > >> few questions:
> >> > >>
> >> > >> @Ethan - can we close ESME-328 "Rewrite the comet timeline"?
> >> > >>
> >> > >> @Vladimir is "ESME-332 "There are still some problems with SBT
> tests"
> >> > >> still valid after the SBT upgrade?
> >> > >>
> >> > >> @Vladimir can we close "ESME-321 Get rid of deprecated methods"? I
> >> > >> wasn't sure how many deprecated methods will still present.
> >> > >>
> >> > >> D.
> >> > >>
> >> > >
> >> >
> >>
> >
> >
> >
> > --
> > Best Regards,
> > Vladimir Ivanov
> >
>
--
Best Regards,
Vladimir Ivanov
Re: 1.3 status
Posted by Richard Hirsch <hi...@gmail.com>.
I also have Vista at home - so we need a test environment with Win7....
D.
On Sun, May 15, 2011 at 7:45 PM, Vladimir Ivanov <le...@gmail.com> wrote:
> Hello Ethan,
>
> You made a great work rewriting Timelines with CSS selectors - thanks!
>
> Regarding ESME-342 - has someone reproduced it locally too? I've just tested
> it with IE9 on Win Vista 32 bit and it worked! But also tested it a while
> ago on IE9 with Win7 64-bit and I'm pretty sure it didn't work - that's why
> I created this issue.
>
> Vladimir
>
> 2011/5/15 Ethan Jewett <es...@gmail.com>
>
>> This is now complete, as people may have noticed. And just in time to make
>> it into Dick's latest deploy :-)
>>
>> So, do we still have any blocking issues or can we try to evaluate what we
>> see on the latest deploy to figure out if we are ready for release? I think
>> the following might be blockers:
>>
>> ESME-342 <https://issues.apache.org/jira/browse/ESME-342>
>>
>> Sign On button doesn't work in
>> IE9<https://issues.apache.org/jira/browse/ESME-342>
>> ESME-282 <https://issues.apache.org/jira/browse/ESME-282>
>>
>> When a public message is resent by one user, no other users are able to
>> resend it <https://issues.apache.org/jira/browse/ESME-282>
>>
>> ESME-282 needs to get fixed, but it probably isn't a major issue. ESME-342
>> sounds like a bigger problem.
>>
>> Ethan
>>
>> On Tue, May 3, 2011 at 5:00 PM, Richard Hirsch <hirsch.dick@gmail.com
>> >wrote:
>>
>> > @Ethan - that's fine - no rush. I'm just trying to keep up the momentum.
>> >
>> > D.
>> >
>> > On Tue, May 3, 2011 at 9:39 AM, Ethan Jewett <es...@gmail.com> wrote:
>> > > Hi Dick,
>> > >
>> > > On ESME-328, we still have a todo around display of message times. This
>> > is
>> > > more complicated than I thought, but I do have a strategy now, and I'll
>> > > address ESME-308 at the same time, I hope.
>> > >
>> > > When are we looking to release? I'm on vacation this week without my
>> > > computer but I should be able to finish this issue next week. If
>> someone
>> > > else wants to do it this week that would be great as well.
>> > >
>> > > Thanks,
>> > > Ethan
>> > >
>> > >
>> > > On Mon, May 2, 2011 at 10:40 AM, Richard Hirsch <hirsch.dick@gmail.com
>> > >wrote:
>> > >
>> > >> I was looking at the looking at 1.3 status this morning and I have a
>> > >> few questions:
>> > >>
>> > >> @Ethan - can we close ESME-328 "Rewrite the comet timeline"?
>> > >>
>> > >> @Vladimir is "ESME-332 "There are still some problems with SBT tests"
>> > >> still valid after the SBT upgrade?
>> > >>
>> > >> @Vladimir can we close "ESME-321 Get rid of deprecated methods"? I
>> > >> wasn't sure how many deprecated methods will still present.
>> > >>
>> > >> D.
>> > >>
>> > >
>> >
>>
>
>
>
> --
> Best Regards,
> Vladimir Ivanov
>
Re: 1.3 status
Posted by Vladimir Ivanov <le...@gmail.com>.
Hello Ethan,
You made a great work rewriting Timelines with CSS selectors - thanks!
Regarding ESME-342 - has someone reproduced it locally too? I've just tested
it with IE9 on Win Vista 32 bit and it worked! But also tested it a while
ago on IE9 with Win7 64-bit and I'm pretty sure it didn't work - that's why
I created this issue.
Vladimir
2011/5/15 Ethan Jewett <es...@gmail.com>
> This is now complete, as people may have noticed. And just in time to make
> it into Dick's latest deploy :-)
>
> So, do we still have any blocking issues or can we try to evaluate what we
> see on the latest deploy to figure out if we are ready for release? I think
> the following might be blockers:
>
> ESME-342 <https://issues.apache.org/jira/browse/ESME-342>
>
> Sign On button doesn't work in
> IE9<https://issues.apache.org/jira/browse/ESME-342>
> ESME-282 <https://issues.apache.org/jira/browse/ESME-282>
>
> When a public message is resent by one user, no other users are able to
> resend it <https://issues.apache.org/jira/browse/ESME-282>
>
> ESME-282 needs to get fixed, but it probably isn't a major issue. ESME-342
> sounds like a bigger problem.
>
> Ethan
>
> On Tue, May 3, 2011 at 5:00 PM, Richard Hirsch <hirsch.dick@gmail.com
> >wrote:
>
> > @Ethan - that's fine - no rush. I'm just trying to keep up the momentum.
> >
> > D.
> >
> > On Tue, May 3, 2011 at 9:39 AM, Ethan Jewett <es...@gmail.com> wrote:
> > > Hi Dick,
> > >
> > > On ESME-328, we still have a todo around display of message times. This
> > is
> > > more complicated than I thought, but I do have a strategy now, and I'll
> > > address ESME-308 at the same time, I hope.
> > >
> > > When are we looking to release? I'm on vacation this week without my
> > > computer but I should be able to finish this issue next week. If
> someone
> > > else wants to do it this week that would be great as well.
> > >
> > > Thanks,
> > > Ethan
> > >
> > >
> > > On Mon, May 2, 2011 at 10:40 AM, Richard Hirsch <hirsch.dick@gmail.com
> > >wrote:
> > >
> > >> I was looking at the looking at 1.3 status this morning and I have a
> > >> few questions:
> > >>
> > >> @Ethan - can we close ESME-328 "Rewrite the comet timeline"?
> > >>
> > >> @Vladimir is "ESME-332 "There are still some problems with SBT tests"
> > >> still valid after the SBT upgrade?
> > >>
> > >> @Vladimir can we close "ESME-321 Get rid of deprecated methods"? I
> > >> wasn't sure how many deprecated methods will still present.
> > >>
> > >> D.
> > >>
> > >
> >
>
--
Best Regards,
Vladimir Ivanov
Re: 1.3 status
Posted by Ethan Jewett <es...@gmail.com>.
This is now complete, as people may have noticed. And just in time to make
it into Dick's latest deploy :-)
So, do we still have any blocking issues or can we try to evaluate what we
see on the latest deploy to figure out if we are ready for release? I think
the following might be blockers:
ESME-342 <https://issues.apache.org/jira/browse/ESME-342>
Sign On button doesn't work in
IE9<https://issues.apache.org/jira/browse/ESME-342>
ESME-282 <https://issues.apache.org/jira/browse/ESME-282>
When a public message is resent by one user, no other users are able to
resend it <https://issues.apache.org/jira/browse/ESME-282>
ESME-282 needs to get fixed, but it probably isn't a major issue. ESME-342
sounds like a bigger problem.
Ethan
On Tue, May 3, 2011 at 5:00 PM, Richard Hirsch <hi...@gmail.com>wrote:
> @Ethan - that's fine - no rush. I'm just trying to keep up the momentum.
>
> D.
>
> On Tue, May 3, 2011 at 9:39 AM, Ethan Jewett <es...@gmail.com> wrote:
> > Hi Dick,
> >
> > On ESME-328, we still have a todo around display of message times. This
> is
> > more complicated than I thought, but I do have a strategy now, and I'll
> > address ESME-308 at the same time, I hope.
> >
> > When are we looking to release? I'm on vacation this week without my
> > computer but I should be able to finish this issue next week. If someone
> > else wants to do it this week that would be great as well.
> >
> > Thanks,
> > Ethan
> >
> >
> > On Mon, May 2, 2011 at 10:40 AM, Richard Hirsch <hirsch.dick@gmail.com
> >wrote:
> >
> >> I was looking at the looking at 1.3 status this morning and I have a
> >> few questions:
> >>
> >> @Ethan - can we close ESME-328 "Rewrite the comet timeline"?
> >>
> >> @Vladimir is "ESME-332 "There are still some problems with SBT tests"
> >> still valid after the SBT upgrade?
> >>
> >> @Vladimir can we close "ESME-321 Get rid of deprecated methods"? I
> >> wasn't sure how many deprecated methods will still present.
> >>
> >> D.
> >>
> >
>
Re: 1.3 status
Posted by Richard Hirsch <hi...@gmail.com>.
@Ethan - that's fine - no rush. I'm just trying to keep up the momentum.
D.
On Tue, May 3, 2011 at 9:39 AM, Ethan Jewett <es...@gmail.com> wrote:
> Hi Dick,
>
> On ESME-328, we still have a todo around display of message times. This is
> more complicated than I thought, but I do have a strategy now, and I'll
> address ESME-308 at the same time, I hope.
>
> When are we looking to release? I'm on vacation this week without my
> computer but I should be able to finish this issue next week. If someone
> else wants to do it this week that would be great as well.
>
> Thanks,
> Ethan
>
>
> On Mon, May 2, 2011 at 10:40 AM, Richard Hirsch <hi...@gmail.com>wrote:
>
>> I was looking at the looking at 1.3 status this morning and I have a
>> few questions:
>>
>> @Ethan - can we close ESME-328 "Rewrite the comet timeline"?
>>
>> @Vladimir is "ESME-332 "There are still some problems with SBT tests"
>> still valid after the SBT upgrade?
>>
>> @Vladimir can we close "ESME-321 Get rid of deprecated methods"? I
>> wasn't sure how many deprecated methods will still present.
>>
>> D.
>>
>
Re: 1.3 status
Posted by Ethan Jewett <es...@gmail.com>.
Hi Dick,
On ESME-328, we still have a todo around display of message times. This is
more complicated than I thought, but I do have a strategy now, and I'll
address ESME-308 at the same time, I hope.
When are we looking to release? I'm on vacation this week without my
computer but I should be able to finish this issue next week. If someone
else wants to do it this week that would be great as well.
Thanks,
Ethan
On Mon, May 2, 2011 at 10:40 AM, Richard Hirsch <hi...@gmail.com>wrote:
> I was looking at the looking at 1.3 status this morning and I have a
> few questions:
>
> @Ethan - can we close ESME-328 "Rewrite the comet timeline"?
>
> @Vladimir is "ESME-332 "There are still some problems with SBT tests"
> still valid after the SBT upgrade?
>
> @Vladimir can we close "ESME-321 Get rid of deprecated methods"? I
> wasn't sure how many deprecated methods will still present.
>
> D.
>
Re: 1.3 status
Posted by Vladimir Ivanov <le...@gmail.com>.
Hi Richard,
ESME-332 is still valid - I can't get stable test results after upgading
either.
ESME-321: all mentioned warnings are present I guess. I think it's easy to
replace deprecated Log with Loggable trait. As far as I remeber Vassil wrote
that warning related to Either.merge() usage should gone anyway. Deprecated
List.sort() had been replaced with SeqLike.sortWith() but one test failed
(due to incorrect implementation) afterwards, so I didn't commit it - it
would be better if Vassil fix this test by himself. Warning related to case
class with subclasses should take additional consideration. Therefore I
think this issue should remain open.
Vladimir
2011/5/2 Richard Hirsch <hi...@gmail.com>
> I was looking at the looking at 1.3 status this morning and I have a
> few questions:
>
> @Ethan - can we close ESME-328 "Rewrite the comet timeline"?
>
> @Vladimir is "ESME-332 "There are still some problems with SBT tests"
> still valid after the SBT upgrade?
>
> @Vladimir can we close "ESME-321 Get rid of deprecated methods"? I
> wasn't sure how many deprecated methods will still present.
>
> D.
>
--
Best Regards,
Vladimir Ivanov
Re: 1.3 status
Posted by Vladimir Ivanov <le...@gmail.com>.
Hi Vassil!
1. Yes, I noted implicit def afterwards and was going to remove
explicit instantiation but hasn't been able to so due to high workload.
2. Sounds reasonable, especially if you say that FetchFeed class itself
isn't used in app (except for pattern mathcing).
Thanks for improvements! Wish you and your family good weekend too!
P.S. Hmm... I tested RSS feed acton right after my changes and it worked for
me. I'll try to update and test it again.
Vladimir
2011/5/14 Vassil Dichev <vd...@apache.org>
> Hi Vladimir,
>
> After ensuring that the necessary parts were there when replacing the
> deprecated stuff, I had more time to check if we can remove some
> superfluous stuff:
>
> 1. Regarding MergeableEither, we can remove the explicit "new
> MergeableEither" instantiation since any Either is converted
> implicitly to a MergeableEither when you use the merge method.
>
> 2. The FetchFeed was working great, but it had many superfluous
> methods like hashCode and equals. Why maintain them when they are
> generated automatically in the case classes and all we need is the
> extractor? Therefore I've only left the unapply method in "object
> FetchFeed". I also made class FetchFeed abstract- we don't have any
> FetchFeed instantiations and it doesn't make much sense if it's not a
> more specific instance (although it would have worked even if it
> wasn't abstract).
>
> Have a nice weekend!
> Vassil
>
> P.S. Fetching feeds doesn't seem to work for me right now, but the
> reason must be somewhere else, because I've checked that pattern
> matching works. Does anyone else experience the same problem?
>
>
> On Mon, May 9, 2011 at 2:07 AM, Vladimir Ivanov <le...@gmail.com>
> wrote:
> > Thanks for review, Vassil!
> >
> > Vladimir
> >
> > 2011/5/8 Vassil Dichev <vd...@apache.org>
> >
> >> Vladimir,
> >>
> >> Nice work- looks good! I've also learned a couple of things from the
> >> deprecation analysis.
> >>
> >> Cheers,
> >> Vassil
> >>
> >>
> >> On Sun, May 8, 2011 at 3:54 AM, Vladimir Ivanov <le...@gmail.com>
> >> wrote:
> >> > Guys,
> >> >
> >> > I've just comleted ESME-321: Get rid of deprecated methods. Among
> other
> >> > deprecation warnings, there were two I'd like to mention about:
> >> >
> >> > 1) Case class FetchFeed had two subclasses: FetchAtom and FetchRss in
> >> > Action.scala. Since 2.8 version Scala compiler consider it as unduly
> >> > complicating both usage and implementation and suggests use extractors
> >> for
> >> > pattern matching on non-leaf nodes instead. See
> >> >
> >>
> http://scala-programming-language.1934581.n4.nabble.com/Adding-an-extractor-to-an-object-to-behave-like-a-case-object-td1950373.html
> >> > for
> >> > more details. Therefore FetchFeed class was rewritten as follows:
> >> >
> >> > Before modification:
> >> >
> >> > case class FetchFeed(url: UrlStore, tags: List[String]) extends
> >> Performances
> >> >
> >> > After modification:
> >> >
> >> > object FetchFeed extends ((UrlStore, List[String]) => FetchFeed) {
> >> > def unapply(f: FetchFeed): Option[(UrlStore, List[String])] = {
> >> > Some(f.url, f.tags)
> >> > }
> >> > def apply(url: UrlStore, tags: List[String]) = new FetchFeed(url,
> tags)
> >> > }
> >> >
> >> > class FetchFeed(val url: UrlStore, val tags: List[String]) extends
> >> > Performances {
> >> > override def hashCode = 41 * (41 + url.hashCode) + tags.hashCode
> >> > override def equals(other: Any) = other match {
> >> > case that: FetchFeed => (that canEqual this) && super.equals(that)
> &&
> >> > this.url == that.url && this.tags == that.tags
> >> > case _ => false
> >> > }
> >> > def canEqual(other: Any) = other.isInstanceOf[FetchFeed]
> >> > def copy(url1: UrlStore = url, tags1: List[String] = tags) = new
> >> > FetchFeed(url1, tags1)
> >> > }
> >> >
> >> > FetchAtom and FetchFeed case classes were left unchanged:
> >> >
> >> > case class FetchAtom(override val url: UrlStore, override val tags:
> >> > List[String]) extends FetchFeed(url, tags)
> >> > case class FetchRss(override val url: UrlStore, override val tags:
> >> > List[String]) extends FetchFeed(url, tags)
> >> >
> >> > 2) Method Either.merge used to extract value from Either in
> >> TwitterAPI.scala
> >> > has been deprecated in Scala 2.8. I replaced it with
> >> Either.MergeableEither
> >> > class:
> >> >
> >> > Before modification:
> >> >
> >> > Either.merge(...)
> >> >
> >> > After modification:
> >> >
> >> > new Either.MergeableEither(...).merge
> >> >
> >> >
> >> > As always it would be great if someone review these changes.
> >> >
> >> > Vladimir
> >> >
> >> >
> >> >
> >> > 2011/5/2 Richard Hirsch <hi...@gmail.com>
> >> >
> >> >> I was looking at the looking at 1.3 status this morning and I have a
> >> >> few questions:
> >> >>
> >> >> @Ethan - can we close ESME-328 "Rewrite the comet timeline"?
> >> >>
> >> >> @Vladimir is "ESME-332 "There are still some problems with SBT tests"
> >> >> still valid after the SBT upgrade?
> >> >>
> >> >> @Vladimir can we close "ESME-321 Get rid of deprecated methods"? I
> >> >> wasn't sure how many deprecated methods will still present.
> >> >>
> >> >> D.
> >> >>
> >> >
> >> >
> >> >
> >> > --
> >> > Best Regards,
> >> > Vladimir Ivanov
> >> >
> >>
> >
> >
> >
> > --
> > Best Regards,
> > Vladimir Ivanov
> >
>
--
Best Regards,
Vladimir Ivanov
Re: 1.3 status
Posted by Vladimir Ivanov <le...@gmail.com>.
Vassil,
I've just updated and tested RSS feed action with:
Test=every 1 mins
Action=rss:
http://issues.apache.org/jira/sr/jira.issueviews:searchrequest-xml/temp/SearchRequest.xml?pid=12310850&reporterSelect=specificuser&reporter=esjewett&sorter/field=issuekey&sorter/order=DESC&tempMax=1000
Fetching feeds seems work for me.
Vladimir
2011/5/14 Vassil Dichev <vd...@apache.org>
> Hi Vladimir,
>
> After ensuring that the necessary parts were there when replacing the
> deprecated stuff, I had more time to check if we can remove some
> superfluous stuff:
>
> 1. Regarding MergeableEither, we can remove the explicit "new
> MergeableEither" instantiation since any Either is converted
> implicitly to a MergeableEither when you use the merge method.
>
> 2. The FetchFeed was working great, but it had many superfluous
> methods like hashCode and equals. Why maintain them when they are
> generated automatically in the case classes and all we need is the
> extractor? Therefore I've only left the unapply method in "object
> FetchFeed". I also made class FetchFeed abstract- we don't have any
> FetchFeed instantiations and it doesn't make much sense if it's not a
> more specific instance (although it would have worked even if it
> wasn't abstract).
>
> Have a nice weekend!
> Vassil
>
> P.S. Fetching feeds doesn't seem to work for me right now, but the
> reason must be somewhere else, because I've checked that pattern
> matching works. Does anyone else experience the same problem?
>
>
> On Mon, May 9, 2011 at 2:07 AM, Vladimir Ivanov <le...@gmail.com>
> wrote:
> > Thanks for review, Vassil!
> >
> > Vladimir
> >
> > 2011/5/8 Vassil Dichev <vd...@apache.org>
> >
> >> Vladimir,
> >>
> >> Nice work- looks good! I've also learned a couple of things from the
> >> deprecation analysis.
> >>
> >> Cheers,
> >> Vassil
> >>
> >>
> >> On Sun, May 8, 2011 at 3:54 AM, Vladimir Ivanov <le...@gmail.com>
> >> wrote:
> >> > Guys,
> >> >
> >> > I've just comleted ESME-321: Get rid of deprecated methods. Among
> other
> >> > deprecation warnings, there were two I'd like to mention about:
> >> >
> >> > 1) Case class FetchFeed had two subclasses: FetchAtom and FetchRss in
> >> > Action.scala. Since 2.8 version Scala compiler consider it as unduly
> >> > complicating both usage and implementation and suggests use extractors
> >> for
> >> > pattern matching on non-leaf nodes instead. See
> >> >
> >>
> http://scala-programming-language.1934581.n4.nabble.com/Adding-an-extractor-to-an-object-to-behave-like-a-case-object-td1950373.html
> >> > for
> >> > more details. Therefore FetchFeed class was rewritten as follows:
> >> >
> >> > Before modification:
> >> >
> >> > case class FetchFeed(url: UrlStore, tags: List[String]) extends
> >> Performances
> >> >
> >> > After modification:
> >> >
> >> > object FetchFeed extends ((UrlStore, List[String]) => FetchFeed) {
> >> > def unapply(f: FetchFeed): Option[(UrlStore, List[String])] = {
> >> > Some(f.url, f.tags)
> >> > }
> >> > def apply(url: UrlStore, tags: List[String]) = new FetchFeed(url,
> tags)
> >> > }
> >> >
> >> > class FetchFeed(val url: UrlStore, val tags: List[String]) extends
> >> > Performances {
> >> > override def hashCode = 41 * (41 + url.hashCode) + tags.hashCode
> >> > override def equals(other: Any) = other match {
> >> > case that: FetchFeed => (that canEqual this) && super.equals(that)
> &&
> >> > this.url == that.url && this.tags == that.tags
> >> > case _ => false
> >> > }
> >> > def canEqual(other: Any) = other.isInstanceOf[FetchFeed]
> >> > def copy(url1: UrlStore = url, tags1: List[String] = tags) = new
> >> > FetchFeed(url1, tags1)
> >> > }
> >> >
> >> > FetchAtom and FetchFeed case classes were left unchanged:
> >> >
> >> > case class FetchAtom(override val url: UrlStore, override val tags:
> >> > List[String]) extends FetchFeed(url, tags)
> >> > case class FetchRss(override val url: UrlStore, override val tags:
> >> > List[String]) extends FetchFeed(url, tags)
> >> >
> >> > 2) Method Either.merge used to extract value from Either in
> >> TwitterAPI.scala
> >> > has been deprecated in Scala 2.8. I replaced it with
> >> Either.MergeableEither
> >> > class:
> >> >
> >> > Before modification:
> >> >
> >> > Either.merge(...)
> >> >
> >> > After modification:
> >> >
> >> > new Either.MergeableEither(...).merge
> >> >
> >> >
> >> > As always it would be great if someone review these changes.
> >> >
> >> > Vladimir
> >> >
> >> >
> >> >
> >> > 2011/5/2 Richard Hirsch <hi...@gmail.com>
> >> >
> >> >> I was looking at the looking at 1.3 status this morning and I have a
> >> >> few questions:
> >> >>
> >> >> @Ethan - can we close ESME-328 "Rewrite the comet timeline"?
> >> >>
> >> >> @Vladimir is "ESME-332 "There are still some problems with SBT tests"
> >> >> still valid after the SBT upgrade?
> >> >>
> >> >> @Vladimir can we close "ESME-321 Get rid of deprecated methods"? I
> >> >> wasn't sure how many deprecated methods will still present.
> >> >>
> >> >> D.
> >> >>
> >> >
> >> >
> >> >
> >> > --
> >> > Best Regards,
> >> > Vladimir Ivanov
> >> >
> >>
> >
> >
> >
> > --
> > Best Regards,
> > Vladimir Ivanov
> >
>
--
Best Regards,
Vladimir Ivanov
Re: 1.3 status
Posted by Vassil Dichev <vd...@apache.org>.
Hi Vladimir,
After ensuring that the necessary parts were there when replacing the
deprecated stuff, I had more time to check if we can remove some
superfluous stuff:
1. Regarding MergeableEither, we can remove the explicit "new
MergeableEither" instantiation since any Either is converted
implicitly to a MergeableEither when you use the merge method.
2. The FetchFeed was working great, but it had many superfluous
methods like hashCode and equals. Why maintain them when they are
generated automatically in the case classes and all we need is the
extractor? Therefore I've only left the unapply method in "object
FetchFeed". I also made class FetchFeed abstract- we don't have any
FetchFeed instantiations and it doesn't make much sense if it's not a
more specific instance (although it would have worked even if it
wasn't abstract).
Have a nice weekend!
Vassil
P.S. Fetching feeds doesn't seem to work for me right now, but the
reason must be somewhere else, because I've checked that pattern
matching works. Does anyone else experience the same problem?
On Mon, May 9, 2011 at 2:07 AM, Vladimir Ivanov <le...@gmail.com> wrote:
> Thanks for review, Vassil!
>
> Vladimir
>
> 2011/5/8 Vassil Dichev <vd...@apache.org>
>
>> Vladimir,
>>
>> Nice work- looks good! I've also learned a couple of things from the
>> deprecation analysis.
>>
>> Cheers,
>> Vassil
>>
>>
>> On Sun, May 8, 2011 at 3:54 AM, Vladimir Ivanov <le...@gmail.com>
>> wrote:
>> > Guys,
>> >
>> > I've just comleted ESME-321: Get rid of deprecated methods. Among other
>> > deprecation warnings, there were two I'd like to mention about:
>> >
>> > 1) Case class FetchFeed had two subclasses: FetchAtom and FetchRss in
>> > Action.scala. Since 2.8 version Scala compiler consider it as unduly
>> > complicating both usage and implementation and suggests use extractors
>> for
>> > pattern matching on non-leaf nodes instead. See
>> >
>> http://scala-programming-language.1934581.n4.nabble.com/Adding-an-extractor-to-an-object-to-behave-like-a-case-object-td1950373.html
>> > for
>> > more details. Therefore FetchFeed class was rewritten as follows:
>> >
>> > Before modification:
>> >
>> > case class FetchFeed(url: UrlStore, tags: List[String]) extends
>> Performances
>> >
>> > After modification:
>> >
>> > object FetchFeed extends ((UrlStore, List[String]) => FetchFeed) {
>> > def unapply(f: FetchFeed): Option[(UrlStore, List[String])] = {
>> > Some(f.url, f.tags)
>> > }
>> > def apply(url: UrlStore, tags: List[String]) = new FetchFeed(url, tags)
>> > }
>> >
>> > class FetchFeed(val url: UrlStore, val tags: List[String]) extends
>> > Performances {
>> > override def hashCode = 41 * (41 + url.hashCode) + tags.hashCode
>> > override def equals(other: Any) = other match {
>> > case that: FetchFeed => (that canEqual this) && super.equals(that) &&
>> > this.url == that.url && this.tags == that.tags
>> > case _ => false
>> > }
>> > def canEqual(other: Any) = other.isInstanceOf[FetchFeed]
>> > def copy(url1: UrlStore = url, tags1: List[String] = tags) = new
>> > FetchFeed(url1, tags1)
>> > }
>> >
>> > FetchAtom and FetchFeed case classes were left unchanged:
>> >
>> > case class FetchAtom(override val url: UrlStore, override val tags:
>> > List[String]) extends FetchFeed(url, tags)
>> > case class FetchRss(override val url: UrlStore, override val tags:
>> > List[String]) extends FetchFeed(url, tags)
>> >
>> > 2) Method Either.merge used to extract value from Either in
>> TwitterAPI.scala
>> > has been deprecated in Scala 2.8. I replaced it with
>> Either.MergeableEither
>> > class:
>> >
>> > Before modification:
>> >
>> > Either.merge(...)
>> >
>> > After modification:
>> >
>> > new Either.MergeableEither(...).merge
>> >
>> >
>> > As always it would be great if someone review these changes.
>> >
>> > Vladimir
>> >
>> >
>> >
>> > 2011/5/2 Richard Hirsch <hi...@gmail.com>
>> >
>> >> I was looking at the looking at 1.3 status this morning and I have a
>> >> few questions:
>> >>
>> >> @Ethan - can we close ESME-328 "Rewrite the comet timeline"?
>> >>
>> >> @Vladimir is "ESME-332 "There are still some problems with SBT tests"
>> >> still valid after the SBT upgrade?
>> >>
>> >> @Vladimir can we close "ESME-321 Get rid of deprecated methods"? I
>> >> wasn't sure how many deprecated methods will still present.
>> >>
>> >> D.
>> >>
>> >
>> >
>> >
>> > --
>> > Best Regards,
>> > Vladimir Ivanov
>> >
>>
>
>
>
> --
> Best Regards,
> Vladimir Ivanov
>
Re: 1.3 status
Posted by Vladimir Ivanov <le...@gmail.com>.
Thanks for review, Vassil!
Vladimir
2011/5/8 Vassil Dichev <vd...@apache.org>
> Vladimir,
>
> Nice work- looks good! I've also learned a couple of things from the
> deprecation analysis.
>
> Cheers,
> Vassil
>
>
> On Sun, May 8, 2011 at 3:54 AM, Vladimir Ivanov <le...@gmail.com>
> wrote:
> > Guys,
> >
> > I've just comleted ESME-321: Get rid of deprecated methods. Among other
> > deprecation warnings, there were two I'd like to mention about:
> >
> > 1) Case class FetchFeed had two subclasses: FetchAtom and FetchRss in
> > Action.scala. Since 2.8 version Scala compiler consider it as unduly
> > complicating both usage and implementation and suggests use extractors
> for
> > pattern matching on non-leaf nodes instead. See
> >
> http://scala-programming-language.1934581.n4.nabble.com/Adding-an-extractor-to-an-object-to-behave-like-a-case-object-td1950373.html
> > for
> > more details. Therefore FetchFeed class was rewritten as follows:
> >
> > Before modification:
> >
> > case class FetchFeed(url: UrlStore, tags: List[String]) extends
> Performances
> >
> > After modification:
> >
> > object FetchFeed extends ((UrlStore, List[String]) => FetchFeed) {
> > def unapply(f: FetchFeed): Option[(UrlStore, List[String])] = {
> > Some(f.url, f.tags)
> > }
> > def apply(url: UrlStore, tags: List[String]) = new FetchFeed(url, tags)
> > }
> >
> > class FetchFeed(val url: UrlStore, val tags: List[String]) extends
> > Performances {
> > override def hashCode = 41 * (41 + url.hashCode) + tags.hashCode
> > override def equals(other: Any) = other match {
> > case that: FetchFeed => (that canEqual this) && super.equals(that) &&
> > this.url == that.url && this.tags == that.tags
> > case _ => false
> > }
> > def canEqual(other: Any) = other.isInstanceOf[FetchFeed]
> > def copy(url1: UrlStore = url, tags1: List[String] = tags) = new
> > FetchFeed(url1, tags1)
> > }
> >
> > FetchAtom and FetchFeed case classes were left unchanged:
> >
> > case class FetchAtom(override val url: UrlStore, override val tags:
> > List[String]) extends FetchFeed(url, tags)
> > case class FetchRss(override val url: UrlStore, override val tags:
> > List[String]) extends FetchFeed(url, tags)
> >
> > 2) Method Either.merge used to extract value from Either in
> TwitterAPI.scala
> > has been deprecated in Scala 2.8. I replaced it with
> Either.MergeableEither
> > class:
> >
> > Before modification:
> >
> > Either.merge(...)
> >
> > After modification:
> >
> > new Either.MergeableEither(...).merge
> >
> >
> > As always it would be great if someone review these changes.
> >
> > Vladimir
> >
> >
> >
> > 2011/5/2 Richard Hirsch <hi...@gmail.com>
> >
> >> I was looking at the looking at 1.3 status this morning and I have a
> >> few questions:
> >>
> >> @Ethan - can we close ESME-328 "Rewrite the comet timeline"?
> >>
> >> @Vladimir is "ESME-332 "There are still some problems with SBT tests"
> >> still valid after the SBT upgrade?
> >>
> >> @Vladimir can we close "ESME-321 Get rid of deprecated methods"? I
> >> wasn't sure how many deprecated methods will still present.
> >>
> >> D.
> >>
> >
> >
> >
> > --
> > Best Regards,
> > Vladimir Ivanov
> >
>
--
Best Regards,
Vladimir Ivanov
Re: 1.3 status
Posted by Vassil Dichev <vd...@apache.org>.
Vladimir,
Nice work- looks good! I've also learned a couple of things from the
deprecation analysis.
Cheers,
Vassil
On Sun, May 8, 2011 at 3:54 AM, Vladimir Ivanov <le...@gmail.com> wrote:
> Guys,
>
> I've just comleted ESME-321: Get rid of deprecated methods. Among other
> deprecation warnings, there were two I'd like to mention about:
>
> 1) Case class FetchFeed had two subclasses: FetchAtom and FetchRss in
> Action.scala. Since 2.8 version Scala compiler consider it as unduly
> complicating both usage and implementation and suggests use extractors for
> pattern matching on non-leaf nodes instead. See
> http://scala-programming-language.1934581.n4.nabble.com/Adding-an-extractor-to-an-object-to-behave-like-a-case-object-td1950373.html
> for
> more details. Therefore FetchFeed class was rewritten as follows:
>
> Before modification:
>
> case class FetchFeed(url: UrlStore, tags: List[String]) extends Performances
>
> After modification:
>
> object FetchFeed extends ((UrlStore, List[String]) => FetchFeed) {
> def unapply(f: FetchFeed): Option[(UrlStore, List[String])] = {
> Some(f.url, f.tags)
> }
> def apply(url: UrlStore, tags: List[String]) = new FetchFeed(url, tags)
> }
>
> class FetchFeed(val url: UrlStore, val tags: List[String]) extends
> Performances {
> override def hashCode = 41 * (41 + url.hashCode) + tags.hashCode
> override def equals(other: Any) = other match {
> case that: FetchFeed => (that canEqual this) && super.equals(that) &&
> this.url == that.url && this.tags == that.tags
> case _ => false
> }
> def canEqual(other: Any) = other.isInstanceOf[FetchFeed]
> def copy(url1: UrlStore = url, tags1: List[String] = tags) = new
> FetchFeed(url1, tags1)
> }
>
> FetchAtom and FetchFeed case classes were left unchanged:
>
> case class FetchAtom(override val url: UrlStore, override val tags:
> List[String]) extends FetchFeed(url, tags)
> case class FetchRss(override val url: UrlStore, override val tags:
> List[String]) extends FetchFeed(url, tags)
>
> 2) Method Either.merge used to extract value from Either in TwitterAPI.scala
> has been deprecated in Scala 2.8. I replaced it with Either.MergeableEither
> class:
>
> Before modification:
>
> Either.merge(...)
>
> After modification:
>
> new Either.MergeableEither(...).merge
>
>
> As always it would be great if someone review these changes.
>
> Vladimir
>
>
>
> 2011/5/2 Richard Hirsch <hi...@gmail.com>
>
>> I was looking at the looking at 1.3 status this morning and I have a
>> few questions:
>>
>> @Ethan - can we close ESME-328 "Rewrite the comet timeline"?
>>
>> @Vladimir is "ESME-332 "There are still some problems with SBT tests"
>> still valid after the SBT upgrade?
>>
>> @Vladimir can we close "ESME-321 Get rid of deprecated methods"? I
>> wasn't sure how many deprecated methods will still present.
>>
>> D.
>>
>
>
>
> --
> Best Regards,
> Vladimir Ivanov
>
Re: 1.3 status
Posted by Vladimir Ivanov <le...@gmail.com>.
Guys,
I've just comleted ESME-321: Get rid of deprecated methods. Among other
deprecation warnings, there were two I'd like to mention about:
1) Case class FetchFeed had two subclasses: FetchAtom and FetchRss in
Action.scala. Since 2.8 version Scala compiler consider it as unduly
complicating both usage and implementation and suggests use extractors for
pattern matching on non-leaf nodes instead. See
http://scala-programming-language.1934581.n4.nabble.com/Adding-an-extractor-to-an-object-to-behave-like-a-case-object-td1950373.html
for
more details. Therefore FetchFeed class was rewritten as follows:
Before modification:
case class FetchFeed(url: UrlStore, tags: List[String]) extends Performances
After modification:
object FetchFeed extends ((UrlStore, List[String]) => FetchFeed) {
def unapply(f: FetchFeed): Option[(UrlStore, List[String])] = {
Some(f.url, f.tags)
}
def apply(url: UrlStore, tags: List[String]) = new FetchFeed(url, tags)
}
class FetchFeed(val url: UrlStore, val tags: List[String]) extends
Performances {
override def hashCode = 41 * (41 + url.hashCode) + tags.hashCode
override def equals(other: Any) = other match {
case that: FetchFeed => (that canEqual this) && super.equals(that) &&
this.url == that.url && this.tags == that.tags
case _ => false
}
def canEqual(other: Any) = other.isInstanceOf[FetchFeed]
def copy(url1: UrlStore = url, tags1: List[String] = tags) = new
FetchFeed(url1, tags1)
}
FetchAtom and FetchFeed case classes were left unchanged:
case class FetchAtom(override val url: UrlStore, override val tags:
List[String]) extends FetchFeed(url, tags)
case class FetchRss(override val url: UrlStore, override val tags:
List[String]) extends FetchFeed(url, tags)
2) Method Either.merge used to extract value from Either in TwitterAPI.scala
has been deprecated in Scala 2.8. I replaced it with Either.MergeableEither
class:
Before modification:
Either.merge(...)
After modification:
new Either.MergeableEither(...).merge
As always it would be great if someone review these changes.
Vladimir
2011/5/2 Richard Hirsch <hi...@gmail.com>
> I was looking at the looking at 1.3 status this morning and I have a
> few questions:
>
> @Ethan - can we close ESME-328 "Rewrite the comet timeline"?
>
> @Vladimir is "ESME-332 "There are still some problems with SBT tests"
> still valid after the SBT upgrade?
>
> @Vladimir can we close "ESME-321 Get rid of deprecated methods"? I
> wasn't sure how many deprecated methods will still present.
>
> D.
>
--
Best Regards,
Vladimir Ivanov