You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/18 07:11:36 UTC
[GitHub] [incubator-mxnet] szha opened a new pull request #18956: add signal handler for fpe, bus error
szha opened a new pull request #18956:
URL: https://github.com/apache/incubator-mxnet/pull/18956
## Description ##
add signal handler for fpe, bus error
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [ ] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18956: add signal handler for fpe, bus error
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18956:
URL: https://github.com/apache/incubator-mxnet/pull/18956#issuecomment-675300333
Hey @szha , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [miscellaneous, centos-cpu, clang, centos-gpu, sanity, edge, website, windows-cpu, unix-gpu, unix-cpu, windows-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #18956: add signal handler for fpe, bus error
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #18956:
URL: https://github.com/apache/incubator-mxnet/pull/18956#discussion_r473592009
##########
File path: include/mxnet/runtime/c_runtime_api.h
##########
@@ -177,4 +178,43 @@ MXNET_DLL int MXNetObjectTypeKey2Index(const char* type_key, unsigned* out_tinde
#ifdef __cplusplus
} // extern "C"
#endif
+
Review comment:
OK, there's external dependency on this ... https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-gpu/detail/PR-18956/7/pipeline
I will revert this change for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #18956: add signal handler for fpe, bus error
Posted by GitBox <gi...@apache.org>.
szha merged pull request #18956:
URL: https://github.com/apache/incubator-mxnet/pull/18956
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #18956: add signal handler for fpe, bus error
Posted by GitBox <gi...@apache.org>.
samskalicky commented on a change in pull request #18956:
URL: https://github.com/apache/incubator-mxnet/pull/18956#discussion_r473531261
##########
File path: include/mxnet/runtime/c_runtime_api.h
##########
@@ -177,4 +178,43 @@ MXNET_DLL int MXNetObjectTypeKey2Index(const char* type_key, unsigned* out_tinde
#ifdef __cplusplus
} // extern "C"
#endif
+
Review comment:
is this useful or should we get rid of this indirection?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #18956: add signal handler for fpe, bus error
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #18956:
URL: https://github.com/apache/incubator-mxnet/pull/18956#discussion_r473529844
##########
File path: include/mxnet/runtime/c_runtime_api.h
##########
@@ -177,4 +178,43 @@ MXNET_DLL int MXNetObjectTypeKey2Index(const char* type_key, unsigned* out_tinde
#ifdef __cplusplus
} // extern "C"
#endif
+
Review comment:
https://github.com/apache/incubator-mxnet/blob/master/src/c_api/c_api_common.h#L45-L55
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #18956: add signal handler for fpe, bus error
Posted by GitBox <gi...@apache.org>.
samskalicky commented on a change in pull request #18956:
URL: https://github.com/apache/incubator-mxnet/pull/18956#discussion_r473528292
##########
File path: include/mxnet/runtime/c_runtime_api.h
##########
@@ -177,4 +178,43 @@ MXNET_DLL int MXNetObjectTypeKey2Index(const char* type_key, unsigned* out_tinde
#ifdef __cplusplus
} // extern "C"
#endif
+
Review comment:
thanks, only one nit: should it be MX_API_BEGIN instead of API_BEGIN?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #18956: add signal handler for fpe, bus error
Posted by GitBox <gi...@apache.org>.
samskalicky commented on a change in pull request #18956:
URL: https://github.com/apache/incubator-mxnet/pull/18956#discussion_r473528292
##########
File path: include/mxnet/runtime/c_runtime_api.h
##########
@@ -177,4 +178,43 @@ MXNET_DLL int MXNetObjectTypeKey2Index(const char* type_key, unsigned* out_tinde
#ifdef __cplusplus
} // extern "C"
#endif
+
Review comment:
thanks, only one nit: should it be MX_API_BEGIN instead of API_BEGIN, etc?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #18956: add signal handler for fpe, bus error
Posted by GitBox <gi...@apache.org>.
samskalicky commented on a change in pull request #18956:
URL: https://github.com/apache/incubator-mxnet/pull/18956#discussion_r473499784
##########
File path: include/mxnet/runtime/c_runtime_api.h
##########
@@ -177,4 +178,43 @@ MXNET_DLL int MXNetObjectTypeKey2Index(const char* type_key, unsigned* out_tinde
#ifdef __cplusplus
} // extern "C"
#endif
+
Review comment:
Can we copy over the comment too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #18956: add signal handler for fpe, bus error
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #18956:
URL: https://github.com/apache/incubator-mxnet/pull/18956#discussion_r473555803
##########
File path: include/mxnet/runtime/c_runtime_api.h
##########
@@ -177,4 +178,43 @@ MXNET_DLL int MXNetObjectTypeKey2Index(const char* type_key, unsigned* out_tinde
#ifdef __cplusplus
} // extern "C"
#endif
+
Review comment:
good point, removed. thanks for bringing this up
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org