You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/26 22:32:39 UTC
[GitHub] [incubator-superset] ktmud opened a new issue #11434: Suggestion: disable caret changing directions in adhoc filters
ktmud opened a new issue #11434:
URL: https://github.com/apache/incubator-superset/issues/11434
## Screenshot
<img src="https://user-images.githubusercontent.com/335541/97235350-e8542680-179f-11eb-94be-05ac8edd52a6.png" width="300">
## Description
Can we disable the behavior of changing caret directions on adhoc filter/metric popover open/close? It doesn't really add any real benefits to UI clarity but is kind of distracting.
The fact that it changes direction before the popover shows up making it feel even more weird.
## Design input
[describe any input/collaboration you'd like from designers, and
tag accordingly. For design review, add the
label `design:review`. If this includes a design proposal,
include the label `design:suggest`]
Would appreciate inputs from designers and any fellow users!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #11434: Suggestion: disable caret changing directions in adhoc filters
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11434:
URL: https://github.com/apache/incubator-superset/issues/11434#issuecomment-718234784
disabled the rotating. will work on the styling along with other control panel improvements in 1.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #11434: Suggestion: disable caret changing directions in adhoc filters
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #11434:
URL: https://github.com/apache/incubator-superset/issues/11434#issuecomment-716972483
@ktmud I only fixed the icon display in #10123.
I don't feel like they add value either, I support removing them and I don't think we need to replace them with something else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas closed issue #11434: Suggestion: disable caret changing directions in adhoc filters
Posted by GitBox <gi...@apache.org>.
rusackas closed issue #11434:
URL: https://github.com/apache/incubator-superset/issues/11434
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on issue #11434: Suggestion: disable caret changing directions in adhoc filters
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #11434:
URL: https://github.com/apache/incubator-superset/issues/11434#issuecomment-716861283
cc @mistercrunch since you added this behavior in #10123 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #11434: Suggestion: disable caret changing directions in adhoc filters
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #11434:
URL: https://github.com/apache/incubator-superset/issues/11434#issuecomment-716860004
Issue-Label Bot is automatically applying the label `#enhancement` to this issue, with a confidence of 0.83. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #11434: Suggestion: disable caret changing directions in adhoc filters
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11434:
URL: https://github.com/apache/incubator-superset/issues/11434#issuecomment-716958243
Using rotating caret when clicking on a Dropdown is quite common in design, i haven't seen many on Popover though. Different design systems also define popovers differently. Mihir and I can do some more exploration since we will reorganize the control panel fields and see what makes the most sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #11434: Suggestion: disable caret changing directions in adhoc filters
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #11434:
URL: https://github.com/apache/incubator-superset/issues/11434#issuecomment-716997209
The more outrageous thing in this area is the label-within-a-rectangle rendering. We should just use our `<Label />` here and bring the `x` inside of it, get rid of the rectangle container.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org