You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/01/31 12:47:42 UTC
[GitHub] flink pull request #3237: [FLINK-5474] [docs] Extend DC/OS documentation
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/3237
[FLINK-5474] [docs] Extend DC/OS documentation
State where you can find out the job manager's address and how to install the DC/OS CLI.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink extendDCOSDocumentation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3237.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3237
----
commit 304f86b566895ddd18374a4de1afdfca24f0e30f
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-01-31T12:45:45Z
[FLINK-5474] [docs] Extend DC/OS documentation
State where you can find out the job manager's address and how to install the DC/OS CLI.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3237: [FLINK-5474] [docs] Extend DC/OS documentation
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3237
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3237: [FLINK-5474] [docs] Extend DC/OS documentation
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3237#discussion_r99064341
--- Diff: docs/setup/mesos.md ---
@@ -92,18 +92,25 @@ Universe. In the search prompt, just search for Flink.
**Note**: At the time of this writing, Flink was not yet available in the
Unvierse. Please use the following workaround in the meantime:
--- End diff --
This isn't part of your change, but just spotted this typo :-) : "Universe"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3237: [FLINK-5474] [docs] Extend DC/OS documentation
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3237#discussion_r99064919
--- Diff: docs/setup/mesos.md ---
@@ -92,18 +92,25 @@ Universe. In the search prompt, just search for Flink.
**Note**: At the time of this writing, Flink was not yet available in the
Unvierse. Please use the following workaround in the meantime:
-1. Add the Development Universe
+1. [Install the DC/OS CLI](https://dcos.io/docs/1.8/usage/cli/install/)
- `dcos marathon app add https://raw.githubusercontent.com/mesosphere/dcos-flink-service/Makman2/quickstart/universe-server.json`
+2. Add the Development Universe
+
+ `./dcos marathon app add https://raw.githubusercontent.com/mesosphere/dcos-flink-service/Makman2/quickstart/universe-server.json`
-2. Add the local Universe repository:
+3. Add the local Universe repository:
- `dcos package repo add --index=0 dev-universe http://universe.marathon.mesos:8085/repo`
+ `./dcos package repo add --index=0 dev-universe http://universe.marathon.mesos:8085/repo`
-3. Install Flink through the Universe page or using the `dcos` command:
+4. Install Flink through the Universe page or using the `dcos` command:
- `dcos package install flink`
+ `./dcos package install flink`
+
+In order to execute a Flink job on a DC/OS hosted Flink cluster, you first have to find out the address of the launched job manager.
+The job manager address can be found out by opening the Flink service, going to *Job Manager* and then using the address specified under `jobmanager.rpc.address` and `jobmanager.rpc.port`.
--- End diff --
"JobManager"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3237: [FLINK-5474] [docs] Extend DC/OS documentation
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3237#discussion_r99064510
--- Diff: docs/setup/mesos.md ---
@@ -92,18 +92,25 @@ Universe. In the search prompt, just search for Flink.
**Note**: At the time of this writing, Flink was not yet available in the
Unvierse. Please use the following workaround in the meantime:
-1. Add the Development Universe
+1. [Install the DC/OS CLI](https://dcos.io/docs/1.8/usage/cli/install/)
- `dcos marathon app add https://raw.githubusercontent.com/mesosphere/dcos-flink-service/Makman2/quickstart/universe-server.json`
+2. Add the Development Universe
+
+ `./dcos marathon app add https://raw.githubusercontent.com/mesosphere/dcos-flink-service/Makman2/quickstart/universe-server.json`
-2. Add the local Universe repository:
+3. Add the local Universe repository:
- `dcos package repo add --index=0 dev-universe http://universe.marathon.mesos:8085/repo`
+ `./dcos package repo add --index=0 dev-universe http://universe.marathon.mesos:8085/repo`
-3. Install Flink through the Universe page or using the `dcos` command:
+4. Install Flink through the Universe page or using the `dcos` command:
- `dcos package install flink`
+ `./dcos package install flink`
+
+In order to execute a Flink job on a DC/OS hosted Flink cluster, you first have to find out the address of the launched job manager.
--- End diff --
job manager --> I think we mostly use "JobManager" in docs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3237: [FLINK-5474] [docs] Extend DC/OS documentation
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3237#discussion_r99217632
--- Diff: docs/setup/mesos.md ---
@@ -92,18 +92,25 @@ Universe. In the search prompt, just search for Flink.
**Note**: At the time of this writing, Flink was not yet available in the
Unvierse. Please use the following workaround in the meantime:
-1. Add the Development Universe
+1. [Install the DC/OS CLI](https://dcos.io/docs/1.8/usage/cli/install/)
- `dcos marathon app add https://raw.githubusercontent.com/mesosphere/dcos-flink-service/Makman2/quickstart/universe-server.json`
+2. Add the Development Universe
+
+ `./dcos marathon app add https://raw.githubusercontent.com/mesosphere/dcos-flink-service/Makman2/quickstart/universe-server.json`
-2. Add the local Universe repository:
+3. Add the local Universe repository:
- `dcos package repo add --index=0 dev-universe http://universe.marathon.mesos:8085/repo`
+ `./dcos package repo add --index=0 dev-universe http://universe.marathon.mesos:8085/repo`
-3. Install Flink through the Universe page or using the `dcos` command:
+4. Install Flink through the Universe page or using the `dcos` command:
- `dcos package install flink`
+ `./dcos package install flink`
+
+In order to execute a Flink job on a DC/OS hosted Flink cluster, you first have to find out the address of the launched job manager.
--- End diff --
I'll change it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3237: [FLINK-5474] [docs] Extend DC/OS documentation
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3237#discussion_r99217650
--- Diff: docs/setup/mesos.md ---
@@ -92,18 +92,25 @@ Universe. In the search prompt, just search for Flink.
**Note**: At the time of this writing, Flink was not yet available in the
Unvierse. Please use the following workaround in the meantime:
-1. Add the Development Universe
+1. [Install the DC/OS CLI](https://dcos.io/docs/1.8/usage/cli/install/)
- `dcos marathon app add https://raw.githubusercontent.com/mesosphere/dcos-flink-service/Makman2/quickstart/universe-server.json`
+2. Add the Development Universe
+
+ `./dcos marathon app add https://raw.githubusercontent.com/mesosphere/dcos-flink-service/Makman2/quickstart/universe-server.json`
-2. Add the local Universe repository:
+3. Add the local Universe repository:
- `dcos package repo add --index=0 dev-universe http://universe.marathon.mesos:8085/repo`
+ `./dcos package repo add --index=0 dev-universe http://universe.marathon.mesos:8085/repo`
-3. Install Flink through the Universe page or using the `dcos` command:
+4. Install Flink through the Universe page or using the `dcos` command:
- `dcos package install flink`
+ `./dcos package install flink`
+
+In order to execute a Flink job on a DC/OS hosted Flink cluster, you first have to find out the address of the launched job manager.
+The job manager address can be found out by opening the Flink service, going to *Job Manager* and then using the address specified under `jobmanager.rpc.address` and `jobmanager.rpc.port`.
--- End diff --
Same here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3237: [FLINK-5474] [docs] Extend DC/OS documentation
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3237
Thanks for the review @tzulitai. I'll address your comments and will then merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3237: [FLINK-5474] [docs] Extend DC/OS documentation
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3237#discussion_r99217592
--- Diff: docs/setup/mesos.md ---
@@ -92,18 +92,25 @@ Universe. In the search prompt, just search for Flink.
**Note**: At the time of this writing, Flink was not yet available in the
Unvierse. Please use the following workaround in the meantime:
--- End diff --
Will correct it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---