[GitHub] sijie opened a new pull request #1227: Fix AbstractLedgerManagerFactory on handling both shaded class and original class co-exists case

[GitBox <gi...@apache.org>]

sijie opened a new pull request #1227:  Fix AbstractLedgerManagerFactory on handling both shaded class and original class co-exists case
URL: https://github.com/apache/bookkeeper/pull/1227
 
 
   Descriptions of the changes in this PR:
   
   *Problem*
   
   #1217 addresses the issue when using a shaded class accessing a bookkeeper cluster.  However the assumption was made when the classpath only has shaded classes. However, it didn't address the case when shaded class and original class can co-exist. because IOException is thrown instead of ClassNotFoundException at following code:
   
   ```
                   Class<?> theCls = Class.forName(layout.getManagerFactoryClass());
                   if (!LedgerManagerFactory.class.isAssignableFrom(theCls)) {
                       throw new IOException("Wrong ledger manager factory " + layout.getManagerFactoryClass());
                   }
   ```
   
   *Solution*
   
   This change fixes the issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services