You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Alena Prokharchyk <al...@citrix.com> on 2014/03/21 19:35:03 UTC

Re: Review Request 17504: Fix the response names in assign and remove cert from LB

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17504/#review38151
-----------------------------------------------------------


Failed to apply the patch, please recreate

alena@alenas-air: [4.4]~/repos/dr/cloudstack$ git am --signoff < ~/Desktop/respname.patch
Patch does not have a valid e-mail address.

- Alena Prokharchyk


On Jan. 29, 2014, 5:58 p.m., Syed Ahmed wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17504/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2014, 5:58 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Animesh Chaturvedi, and Murali Reddy.
> 
> 
> Bugs: CLOUDSTACK-5982
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5982
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> This patch fixes the response names for the API commands
> 
> assignCertToLoadBalancer
> removeCertFromLoadBalancer
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/AssignCertToLoadBalancerCmd.java 4ea4a58 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/RemoveCertFromLoadBalancerCmd.java e92d208 
> 
> Diff: https://reviews.apache.org/r/17504/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Syed Ahmed
> 
>


Re: Review Request 17504: Fix the response names in assign and remove cert from LB

Posted by Syed Ahmed <sa...@cloudops.com>.
Closed



On Fri 21 Mar 2014 02:35:52 PM EDT, Alena Prokharchyk wrote:
>
>
>> On March 21, 2014, 6:35 p.m., Alena Prokharchyk wrote:
>>> Failed to apply the patch, please recreate
>>>
>>> alena@alenas-air: [4.4]~/repos/dr/cloudstack$ git am --signoff < ~/Desktop/respname.patch
>>> Patch does not have a valid e-mail address.
>
> Syed, please just go ahead and close this ticket as resolved. Looks like I've fixed it myself some time ago.
>
>
> - Alena
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17504/#review38151
> -----------------------------------------------------------
>
>
> On Jan. 29, 2014, 5:58 p.m., Syed Ahmed wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/17504/
>> -----------------------------------------------------------
>>
>> (Updated Jan. 29, 2014, 5:58 p.m.)
>>
>>
>> Review request for cloudstack, Alena Prokharchyk, Animesh Chaturvedi, and Murali Reddy.
>>
>>
>> Bugs: CLOUDSTACK-5982
>>      https://issues.apache.org/jira/browse/CLOUDSTACK-5982
>>
>>
>> Repository: cloudstack-git
>>
>>
>> Description
>> -------
>>
>> This patch fixes the response names for the API commands
>>
>> assignCertToLoadBalancer
>> removeCertFromLoadBalancer
>>
>>
>> Diffs
>> -----
>>
>>    api/src/org/apache/cloudstack/api/command/user/loadbalancer/AssignCertToLoadBalancerCmd.java 4ea4a58
>>    api/src/org/apache/cloudstack/api/command/user/loadbalancer/RemoveCertFromLoadBalancerCmd.java e92d208
>>
>> Diff: https://reviews.apache.org/r/17504/diff/
>>
>>
>> Testing
>> -------
>>
>>
>> Thanks,
>>
>> Syed Ahmed
>>
>>
>
>



Re: Review Request 17504: Fix the response names in assign and remove cert from LB

Posted by Alena Prokharchyk <al...@citrix.com>.

> On March 21, 2014, 6:35 p.m., Alena Prokharchyk wrote:
> > Failed to apply the patch, please recreate
> > 
> > alena@alenas-air: [4.4]~/repos/dr/cloudstack$ git am --signoff < ~/Desktop/respname.patch
> > Patch does not have a valid e-mail address.

Syed, please just go ahead and close this ticket as resolved. Looks like I've fixed it myself some time ago.


- Alena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17504/#review38151
-----------------------------------------------------------


On Jan. 29, 2014, 5:58 p.m., Syed Ahmed wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17504/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2014, 5:58 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Animesh Chaturvedi, and Murali Reddy.
> 
> 
> Bugs: CLOUDSTACK-5982
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5982
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> This patch fixes the response names for the API commands
> 
> assignCertToLoadBalancer
> removeCertFromLoadBalancer
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/AssignCertToLoadBalancerCmd.java 4ea4a58 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/RemoveCertFromLoadBalancerCmd.java e92d208 
> 
> Diff: https://reviews.apache.org/r/17504/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Syed Ahmed
> 
>