You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by Willem Jiang <wi...@gmail.com> on 2009/01/03 15:00:41 UTC
Re: svn commit: r684196 - in /activemq/camel/trunk/components/camel-jetty/src/main/java/org/apache/camel/component/jetty:
JettyHttpEndpoint.java JettyHttpProducer.java
Hi Claus,
I just found this change when I want to merge the patch CAMEL-1217 from
trunk to camel-1.x branch.
Since the JettyHttpEndpoint doesn't create JettyHttpProducer for a long
time. I'd like to remove the JettyHttpProducer from camel-1.x branch.
Of cause, I will update the release note for it.
Is they any thing that I am missing?
Willem
davsclaus@apache.org wrote:
> Author: davsclaus
> Date: Sat Aug 9 01:34:30 2008
> New Revision: 684196
>
> URL: http://svn.apache.org/viewvc?rev=684196&view=rev
> Log:
> Marked JettyHttpProducer as @deprecated
>
> Modified:
> activemq/camel/trunk/components/camel-jetty/src/main/java/org/apache/camel/component/jetty/JettyHttpEndpoint.java
> activemq/camel/trunk/components/camel-jetty/src/main/java/org/apache/camel/component/jetty/JettyHttpProducer.java
>
> Modified: activemq/camel/trunk/components/camel-jetty/src/main/java/org/apache/camel/component/jetty/JettyHttpEndpoint.java
> URL: http://svn.apache.org/viewvc/activemq/camel/trunk/components/camel-jetty/src/main/java/org/apache/camel/component/jetty/JettyHttpEndpoint.java?rev=684196&r1=684195&r2=684196&view=diff
> ==============================================================================
> --- activemq/camel/trunk/components/camel-jetty/src/main/java/org/apache/camel/component/jetty/JettyHttpEndpoint.java (original)
> +++ activemq/camel/trunk/components/camel-jetty/src/main/java/org/apache/camel/component/jetty/JettyHttpEndpoint.java Sat Aug 9 01:34:30 2008
> @@ -26,7 +26,7 @@
> import org.apache.camel.component.http.HttpConsumer;
> import org.apache.camel.component.http.HttpEndpoint;
> import org.apache.camel.component.http.HttpExchange;
> -import org.apache.camel.impl.EventDrivenPollingConsumer;
> +import org.apache.camel.component.http.HttpPollingConsumer;
> import org.apache.commons.httpclient.HttpConnectionManager;
>
> /**
> @@ -44,7 +44,6 @@
> @Override
> public Producer<HttpExchange> createProducer() throws Exception {
> return super.createProducer();
> - // return new JettyHttpProducer(this);
> }
>
> @Override
> @@ -54,7 +53,7 @@
>
> @Override
> public PollingConsumer<HttpExchange> createPollingConsumer() throws Exception {
> - return new EventDrivenPollingConsumer<HttpExchange>(this);
> + return new HttpPollingConsumer(this);
> }
>
> @Override
>
> Modified: activemq/camel/trunk/components/camel-jetty/src/main/java/org/apache/camel/component/jetty/JettyHttpProducer.java
> URL: http://svn.apache.org/viewvc/activemq/camel/trunk/components/camel-jetty/src/main/java/org/apache/camel/component/jetty/JettyHttpProducer.java?rev=684196&r1=684195&r2=684196&view=diff
> ==============================================================================
> --- activemq/camel/trunk/components/camel-jetty/src/main/java/org/apache/camel/component/jetty/JettyHttpProducer.java (original)
> +++ activemq/camel/trunk/components/camel-jetty/src/main/java/org/apache/camel/component/jetty/JettyHttpProducer.java Sat Aug 9 01:34:30 2008
> @@ -39,6 +39,9 @@
> import org.mortbay.jetty.client.HttpClient;
> import org.mortbay.jetty.client.HttpExchange.ContentExchange;
>
> +/**
> + * @deprecated use org.apache.camel.component.http.HttpProducer instead. Will be removed in Camel 2.0.
> + */
> public class JettyHttpProducer extends DefaultProducer<HttpExchange> implements Producer<HttpExchange>, AsyncProcessor {
>
> private final class CamelContentExchange extends ContentExchange {
>
>
>
Re: svn commit: r684196 - in /activemq/camel/trunk/components/camel-jetty/src/main/java/org/apache/camel/component/jetty: JettyHttpEndpoint.java JettyHttpProducer.java
Posted by Claus Ibsen <cl...@gmail.com>.
On Sat, Jan 3, 2009 at 3:00 PM, Willem Jiang <wi...@gmail.com> wrote:
> Hi Claus,
>
> I just found this change when I want to merge the patch CAMEL-1217 from
> trunk to camel-1.x branch.
>
> Since the JettyHttpEndpoint doesn't create JettyHttpProducer for a long
> time. I'd like to remove the JettyHttpProducer from camel-1.x branch.
>
> Of cause, I will update the release note for it.
>
> Is they any thing that I am missing?
Not what I can think of.
I think it's safe to remove it from the 1.x branch as well.
>
> Willem
>
> davsclaus@apache.org wrote:
>> Author: davsclaus
>> Date: Sat Aug 9 01:34:30 2008
>> New Revision: 684196
>>
>> URL: http://svn.apache.org/viewvc?rev=684196&view=rev
>> Log:
>> Marked JettyHttpProducer as @deprecated
>>
>> Modified:
>> activemq/camel/trunk/components/camel-jetty/src/main/java/org/apache/camel/component/jetty/JettyHttpEndpoint.java
>> activemq/camel/trunk/components/camel-jetty/src/main/java/org/apache/camel/component/jetty/JettyHttpProducer.java
>>
>> Modified: activemq/camel/trunk/components/camel-jetty/src/main/java/org/apache/camel/component/jetty/JettyHttpEndpoint.java
>> URL: http://svn.apache.org/viewvc/activemq/camel/trunk/components/camel-jetty/src/main/java/org/apache/camel/component/jetty/JettyHttpEndpoint.java?rev=684196&r1=684195&r2=684196&view=diff
>> ==============================================================================
>> --- activemq/camel/trunk/components/camel-jetty/src/main/java/org/apache/camel/component/jetty/JettyHttpEndpoint.java (original)
>> +++ activemq/camel/trunk/components/camel-jetty/src/main/java/org/apache/camel/component/jetty/JettyHttpEndpoint.java Sat Aug 9 01:34:30 2008
>> @@ -26,7 +26,7 @@
>> import org.apache.camel.component.http.HttpConsumer;
>> import org.apache.camel.component.http.HttpEndpoint;
>> import org.apache.camel.component.http.HttpExchange;
>> -import org.apache.camel.impl.EventDrivenPollingConsumer;
>> +import org.apache.camel.component.http.HttpPollingConsumer;
>> import org.apache.commons.httpclient.HttpConnectionManager;
>>
>> /**
>> @@ -44,7 +44,6 @@
>> @Override
>> public Producer<HttpExchange> createProducer() throws Exception {
>> return super.createProducer();
>> - // return new JettyHttpProducer(this);
>> }
>>
>> @Override
>> @@ -54,7 +53,7 @@
>>
>> @Override
>> public PollingConsumer<HttpExchange> createPollingConsumer() throws Exception {
>> - return new EventDrivenPollingConsumer<HttpExchange>(this);
>> + return new HttpPollingConsumer(this);
>> }
>>
>> @Override
>>
>> Modified: activemq/camel/trunk/components/camel-jetty/src/main/java/org/apache/camel/component/jetty/JettyHttpProducer.java
>> URL: http://svn.apache.org/viewvc/activemq/camel/trunk/components/camel-jetty/src/main/java/org/apache/camel/component/jetty/JettyHttpProducer.java?rev=684196&r1=684195&r2=684196&view=diff
>> ==============================================================================
>> --- activemq/camel/trunk/components/camel-jetty/src/main/java/org/apache/camel/component/jetty/JettyHttpProducer.java (original)
>> +++ activemq/camel/trunk/components/camel-jetty/src/main/java/org/apache/camel/component/jetty/JettyHttpProducer.java Sat Aug 9 01:34:30 2008
>> @@ -39,6 +39,9 @@
>> import org.mortbay.jetty.client.HttpClient;
>> import org.mortbay.jetty.client.HttpExchange.ContentExchange;
>>
>> +/**
>> + * @deprecated use org.apache.camel.component.http.HttpProducer instead. Will be removed in Camel 2.0.
>> + */
>> public class JettyHttpProducer extends DefaultProducer<HttpExchange> implements Producer<HttpExchange>, AsyncProcessor {
>>
>> private final class CamelContentExchange extends ContentExchange {
>>
>>
>>
>
>
--
/Claus Ibsen
Apache Camel Committer
Blog: http://davsclaus.blogspot.com/