[GitHub] [ignite] SammyVimes commented on a change in pull request #7949: IGNITE-13169 Remove Ignite bean name requirement for Spring Data repository

[GitBox <gi...@apache.org>]

SammyVimes commented on a change in pull request #7949:
URL: https://github.com/apache/ignite/pull/7949#discussion_r445649687



##########
File path: modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/support/IgniteRepositoryFactoryBean.java
##########
@@ -64,13 +64,13 @@ protected IgniteRepositoryFactoryBean(Class<? extends T> repositoryInterface) {
     /** {@inheritDoc} */
     @Override protected RepositoryFactorySupport createRepositoryFactory() {
         try {
-            Ignite ignite = (Ignite)ctx.getBean("igniteInstance");
+            Ignite ignite = ctx.getBean(Ignite.class);
 
             return new IgniteRepositoryFactory(ignite);
         }
         catch (BeansException ex) {
             try {
-                IgniteConfiguration cfg = (IgniteConfiguration)ctx.getBean("igniteCfg");

Review comment:
       Do you think users can have multiple beans of IgniteConfiguration? This can break only in that case 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org