You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Sailaja Polavarapu <sp...@hortonworks.com> on 2019/08/07 22:55:31 UTC
Review Request 71245: RANGER-2530: Constant increase in memory usage
by ranger-usersync process and eventually going out of memory
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71245/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-2530
https://issues.apache.org/jira/browse/RANGER-2530
Repository: ranger
Description
-------
Fixed some memory leak issues as well as modified code to re-use jersey client instance instead of creating new one for every request.
Diffs
-----
ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java d451d7acd
ugsync/src/main/java/org/apache/ranger/unixusersync/model/XGroupInfo.java b9e71916f
ugsync/src/main/java/org/apache/ranger/unixusersync/model/XUserInfo.java 5b814378f
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java 24956e013
Diff: https://reviews.apache.org/r/71245/diff/1/
Testing
-------
1. Verified all the exisitng unit tests are run successfully
2. Patched a test cluster and ran some long running tests and some functional tests successfully.
3. Collected few heap dumps during long running tests and verified memory usage.
Thanks,
Sailaja Polavarapu
Re: Review Request 71245: RANGER-2530: Constant increase in memory
usage by ranger-usersync process and eventually going out of memory
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71245/#review217138
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On Aug. 8, 2019, 10:57 p.m., Sailaja Polavarapu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71245/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2019, 10:57 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2530
> https://issues.apache.org/jira/browse/RANGER-2530
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Fixed some memory leak issues as well as modified code to re-use jersey client instance instead of creating new one for every request.
>
>
> Diffs
> -----
>
> ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java d451d7acd
> ugsync/src/main/java/org/apache/ranger/unixusersync/model/XGroupInfo.java b9e71916f
> ugsync/src/main/java/org/apache/ranger/unixusersync/model/XUserInfo.java 5b814378f
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java 24956e013
>
>
> Diff: https://reviews.apache.org/r/71245/diff/2/
>
>
> Testing
> -------
>
> 1. Verified all the exisitng unit tests are run successfully
> 2. Patched a test cluster and ran some long running tests and some functional tests successfully.
> 3. Collected few heap dumps during long running tests and verified memory usage.
>
>
> Thanks,
>
> Sailaja Polavarapu
>
>
Re: Review Request 71245: RANGER-2530: Constant increase in memory
usage by ranger-usersync process and eventually going out of memory
Posted by Sailaja Polavarapu <sp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71245/
-----------------------------------------------------------
(Updated Aug. 8, 2019, 10:57 p.m.)
Review request for ranger.
Changes
-------
Removed unused imports
Bugs: RANGER-2530
https://issues.apache.org/jira/browse/RANGER-2530
Repository: ranger
Description
-------
Fixed some memory leak issues as well as modified code to re-use jersey client instance instead of creating new one for every request.
Diffs (updated)
-----
ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java d451d7acd
ugsync/src/main/java/org/apache/ranger/unixusersync/model/XGroupInfo.java b9e71916f
ugsync/src/main/java/org/apache/ranger/unixusersync/model/XUserInfo.java 5b814378f
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java 24956e013
Diff: https://reviews.apache.org/r/71245/diff/2/
Changes: https://reviews.apache.org/r/71245/diff/1-2/
Testing
-------
1. Verified all the exisitng unit tests are run successfully
2. Patched a test cluster and ran some long running tests and some functional tests successfully.
3. Collected few heap dumps during long running tests and verified memory usage.
Thanks,
Sailaja Polavarapu
Re: Review Request 71245: RANGER-2530: Constant increase in memory
usage by ranger-usersync process and eventually going out of memory
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71245/#review217124
-----------------------------------------------------------
Fix it, then Ship it!
Fix and Ship it!
ugsync/src/main/java/org/apache/ranger/unixusersync/model/XGroupInfo.java
Lines 22 (patched)
<https://reviews.apache.org/r/71245/#comment304391>
Please remove unused import. Generates PMD violation.
ugsync/src/main/java/org/apache/ranger/unixusersync/model/XUserInfo.java
Lines 24 (patched)
<https://reviews.apache.org/r/71245/#comment304390>
Please remove this unused import. Creates PMD violation.
- Velmurugan Periasamy
On Aug. 7, 2019, 10:55 p.m., Sailaja Polavarapu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71245/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2019, 10:55 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2530
> https://issues.apache.org/jira/browse/RANGER-2530
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Fixed some memory leak issues as well as modified code to re-use jersey client instance instead of creating new one for every request.
>
>
> Diffs
> -----
>
> ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java d451d7acd
> ugsync/src/main/java/org/apache/ranger/unixusersync/model/XGroupInfo.java b9e71916f
> ugsync/src/main/java/org/apache/ranger/unixusersync/model/XUserInfo.java 5b814378f
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java 24956e013
>
>
> Diff: https://reviews.apache.org/r/71245/diff/1/
>
>
> Testing
> -------
>
> 1. Verified all the exisitng unit tests are run successfully
> 2. Patched a test cluster and ran some long running tests and some functional tests successfully.
> 3. Collected few heap dumps during long running tests and verified memory usage.
>
>
> Thanks,
>
> Sailaja Polavarapu
>
>