You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by sarutak <gi...@git.apache.org> on 2014/11/13 20:04:02 UTC
[GitHub] incubator-flink pull request: [FLINK-1243] Remove JVM MaxPermSize ...
GitHub user sarutak opened a pull request:
https://github.com/apache/incubator-flink/pull/200
[FLINK-1243] Remove JVM MaxPermSize parameter when we use Java 8
JVM for Java 8 doesn't accept MaxPermSize parameter so let's remove it when we use Java 8.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sarutak/incubator-flink remove-maxpermsize
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-flink/pull/200.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #200
----
commit 5d9dec32575fd8e9d58bf5ffde99d5aef86289b2
Author: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Date: 2014-11-13T19:00:24Z
Removed MaxPermSize parameter for JVM 1.8
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1243] Remove JVM MaxPermSize ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-flink/pull/200
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1243] Remove JVM MaxPermSize ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/incubator-flink/pull/200#issuecomment-63295530
I am a bit confused by the statement `if [ "$JAVA_VERSION" -ge 18 ]; then` - it looks as if it adds the flag only if the java version is greater or equal than Java (= 1.8 = 18).
Is that not the exact opposite of what we are trying to do? Or am I parsing bash wrong here...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1243] Remove JVM MaxPermSize ...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/200#discussion_r20381770
--- Diff: flink-dist/src/main/flink-bin/bin/jobmanager.sh ---
@@ -30,7 +30,12 @@ if [ "$EXECUTIONMODE" = "local" ]; then
FLINK_JM_HEAP=`expr $FLINK_JM_HEAP + $FLINK_TM_HEAP`
fi
-JVM_ARGS="$JVM_ARGS -XX:+UseConcMarkSweepGC -XX:+CMSClassUnloadingEnabled -XX:MaxPermSize=256m"
+JAVA_VERSION=$($RUNNER -version 2>&1 | sed 's/java version "\(.*\)\.\(.*\)\..*"/\1\2/; 1q')
--- End diff --
What is the $RUNNER env variable here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1243] Remove JVM MaxPermSize ...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-flink/pull/200#issuecomment-63127028
To clean up the patch, could you rebase them into one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1243] Remove JVM MaxPermSize ...
Posted by sarutak <gi...@git.apache.org>.
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/200#discussion_r20381999
--- Diff: flink-dist/src/main/flink-bin/bin/jobmanager.sh ---
@@ -30,7 +30,12 @@ if [ "$EXECUTIONMODE" = "local" ]; then
FLINK_JM_HEAP=`expr $FLINK_JM_HEAP + $FLINK_TM_HEAP`
fi
-JVM_ARGS="$JVM_ARGS -XX:+UseConcMarkSweepGC -XX:+CMSClassUnloadingEnabled -XX:MaxPermSize=256m"
+JAVA_VERSION=$($RUNNER -version 2>&1 | sed 's/java version "\(.*\)\.\(.*\)\..*"/\1\2/; 1q')
--- End diff --
Thanks for pointing out it.
It's typo for JAVA_RUN and now I've fixed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1243] Remove JVM MaxPermSize ...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/incubator-flink/pull/200#issuecomment-63453354
Regarding this issue, I've found this: http://openjdk.java.net/jeps/122. If the argument is set anyways, you get a warning. So +1 to add this. @StephanEwen is right, though. It should be lower than (`-lt`). I've tested the version extraction and it works for me.
Will merge this later today with the respective change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---