You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Frédéric Glorieux (JIRA)" <ji...@apache.org> on 2006/03/27 09:41:22 UTC
[jira] Created: (COCOON-1815) CopySourceAction generate NPE
CopySourceAction generate NPE
-----------------------------
Key: COCOON-1815
URL: http://issues.apache.org/jira/browse/COCOON-1815
Project: Cocoon
Type: Bug
Components: * Cocoon Core
Versions: 2.1.8
Reporter: Frédéric Glorieux
Priority: Minor
<http://www.mail-archive.com/users-fr@cocoon.apache.org/msg01586.html>
In some circumstances, with internal sources (cocoon:/), org/apache/cocoon/acting/copySource.java
<http://svn.apache.org/viewcvs.cgi/cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/acting/CopySourceAction.java?rev=30932&view=markup>
copy-source action generate NPE in Console (nothing seems broken)
Source objects needs to be released
Code may be shorter with usage of excalibur SourceUtil to copy sources
try {
org.apache.excalibur.source.SourceUtil.SourceUtil.copy(src, dest);
} finally {
resolver.release(src);
resolver.release(dest);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Reopened: (COCOON-1815) CopySourceAction generate NPE
Posted by "Geurt Wisselink (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1815?page=all ]
Geurt Wisselink reopened COCOON-1815:
-------------------------------------
You forget to add:
resolver.release(src);
resolver.release(dest);
This is really needed, without it cocoon is leaking memory.
> CopySourceAction generate NPE
> -----------------------------
>
> Key: COCOON-1815
> URL: http://issues.apache.org/jira/browse/COCOON-1815
> Project: Cocoon
> Issue Type: Bug
> Components: * Cocoon Core
> Affects Versions: 2.1.8
> Reporter: Frédéric Glorieux
> Assigned To: Antonio Gallardo
> Priority: Minor
> Fix For: 2.2-dev (Current SVN), 2.1.10-dev (current SVN)
>
>
> <http://www.mail-archive.com/users-fr@cocoon.apache.org/msg01586.html>
> In some circumstances, with internal sources (cocoon:/), org/apache/cocoon/acting/copySource.java
> <http://svn.apache.org/viewcvs.cgi/cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/acting/CopySourceAction.java?rev=30932&view=markup>
> copy-source action generate NPE in Console (nothing seems broken)
> Source objects needs to be released
> Code may be shorter with usage of excalibur SourceUtil to copy sources
> try {
> org.apache.excalibur.source.SourceUtil.SourceUtil.copy(src, dest);
> } finally {
> resolver.release(src);
> resolver.release(dest);
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1815) CopySourceAction generate NPE
Posted by "Antonio Gallardo (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1815?page=comments#action_12413689 ]
Antonio Gallardo commented on COCOON-1815:
------------------------------------------
The code was applied to cocon-2.1.10-dev and 2.2.-dev. Would you test it?
> CopySourceAction generate NPE
> -----------------------------
>
> Key: COCOON-1815
> URL: http://issues.apache.org/jira/browse/COCOON-1815
> Project: Cocoon
> Type: Bug
> Components: * Cocoon Core
> Versions: 2.1.8
> Reporter: Frédéric Glorieux
> Priority: Minor
>
> <http://www.mail-archive.com/users-fr@cocoon.apache.org/msg01586.html>
> In some circumstances, with internal sources (cocoon:/), org/apache/cocoon/acting/copySource.java
> <http://svn.apache.org/viewcvs.cgi/cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/acting/CopySourceAction.java?rev=30932&view=markup>
> copy-source action generate NPE in Console (nothing seems broken)
> Source objects needs to be released
> Code may be shorter with usage of excalibur SourceUtil to copy sources
> try {
> org.apache.excalibur.source.SourceUtil.SourceUtil.copy(src, dest);
> } finally {
> resolver.release(src);
> resolver.release(dest);
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1815) CopySourceAction generate NPE
Posted by "Frédéric Glorieux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1815?page=comments#action_12371959 ]
Frédéric Glorieux commented on COCOON-1815:
-------------------------------------------
:o( I can't for different reasons
* no time
* I'm not sure to understand everything in this class (multipart not tested)
* never done
* no clean SVN cocoon tree for the moment
Sorry.
> CopySourceAction generate NPE
> -----------------------------
>
> Key: COCOON-1815
> URL: http://issues.apache.org/jira/browse/COCOON-1815
> Project: Cocoon
> Type: Bug
> Components: * Cocoon Core
> Versions: 2.1.8
> Reporter: Frédéric Glorieux
> Priority: Minor
>
> <http://www.mail-archive.com/users-fr@cocoon.apache.org/msg01586.html>
> In some circumstances, with internal sources (cocoon:/), org/apache/cocoon/acting/copySource.java
> <http://svn.apache.org/viewcvs.cgi/cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/acting/CopySourceAction.java?rev=30932&view=markup>
> copy-source action generate NPE in Console (nothing seems broken)
> Source objects needs to be released
> Code may be shorter with usage of excalibur SourceUtil to copy sources
> try {
> org.apache.excalibur.source.SourceUtil.SourceUtil.copy(src, dest);
> } finally {
> resolver.release(src);
> resolver.release(dest);
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (COCOON-1815) CopySourceAction generate NPE
Posted by "Antonio Gallardo (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1815?page=all ]
Antonio Gallardo closed COCOON-1815.
------------------------------------
Resolution: Fixed
Thanks for raising the issue. Patch applied. Please feel free to reopen agai if needed.
> CopySourceAction generate NPE
> -----------------------------
>
> Key: COCOON-1815
> URL: http://issues.apache.org/jira/browse/COCOON-1815
> Project: Cocoon
> Issue Type: Bug
> Components: * Cocoon Core
> Affects Versions: 2.1.8
> Reporter: Frédéric Glorieux
> Assigned To: Antonio Gallardo
> Priority: Minor
> Fix For: 2.2-dev (Current SVN), 2.1.10-dev (current SVN)
>
>
> <http://www.mail-archive.com/users-fr@cocoon.apache.org/msg01586.html>
> In some circumstances, with internal sources (cocoon:/), org/apache/cocoon/acting/copySource.java
> <http://svn.apache.org/viewcvs.cgi/cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/acting/CopySourceAction.java?rev=30932&view=markup>
> copy-source action generate NPE in Console (nothing seems broken)
> Source objects needs to be released
> Code may be shorter with usage of excalibur SourceUtil to copy sources
> try {
> org.apache.excalibur.source.SourceUtil.SourceUtil.copy(src, dest);
> } finally {
> resolver.release(src);
> resolver.release(dest);
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (COCOON-1815) CopySourceAction generate NPE
Posted by "Antonio Gallardo (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1815?page=all ]
Antonio Gallardo reassigned COCOON-1815:
----------------------------------------
Assignee: Antonio Gallardo
> CopySourceAction generate NPE
> -----------------------------
>
> Key: COCOON-1815
> URL: http://issues.apache.org/jira/browse/COCOON-1815
> Project: Cocoon
> Issue Type: Bug
> Components: * Cocoon Core
> Affects Versions: 2.1.8
> Reporter: Frédéric Glorieux
> Assigned To: Antonio Gallardo
> Priority: Minor
>
> <http://www.mail-archive.com/users-fr@cocoon.apache.org/msg01586.html>
> In some circumstances, with internal sources (cocoon:/), org/apache/cocoon/acting/copySource.java
> <http://svn.apache.org/viewcvs.cgi/cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/acting/CopySourceAction.java?rev=30932&view=markup>
> copy-source action generate NPE in Console (nothing seems broken)
> Source objects needs to be released
> Code may be shorter with usage of excalibur SourceUtil to copy sources
> try {
> org.apache.excalibur.source.SourceUtil.SourceUtil.copy(src, dest);
> } finally {
> resolver.release(src);
> resolver.release(dest);
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (COCOON-1815) CopySourceAction generate NPE
Posted by "Antonio Gallardo (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1815?page=all ]
Antonio Gallardo closed COCOON-1815.
------------------------------------
Fix Version/s: 2.2-dev (Current SVN)
2.1.10-dev (current SVN)
Resolution: Fixed
The patch was applied and no feedback. I assume the issue is fixed. Feel free to reopen if needed.
> CopySourceAction generate NPE
> -----------------------------
>
> Key: COCOON-1815
> URL: http://issues.apache.org/jira/browse/COCOON-1815
> Project: Cocoon
> Issue Type: Bug
> Components: * Cocoon Core
> Affects Versions: 2.1.8
> Reporter: Frédéric Glorieux
> Assigned To: Antonio Gallardo
> Priority: Minor
> Fix For: 2.2-dev (Current SVN), 2.1.10-dev (current SVN)
>
>
> <http://www.mail-archive.com/users-fr@cocoon.apache.org/msg01586.html>
> In some circumstances, with internal sources (cocoon:/), org/apache/cocoon/acting/copySource.java
> <http://svn.apache.org/viewcvs.cgi/cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/acting/CopySourceAction.java?rev=30932&view=markup>
> copy-source action generate NPE in Console (nothing seems broken)
> Source objects needs to be released
> Code may be shorter with usage of excalibur SourceUtil to copy sources
> try {
> org.apache.excalibur.source.SourceUtil.SourceUtil.copy(src, dest);
> } finally {
> resolver.release(src);
> resolver.release(dest);
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1815) CopySourceAction generate NPE
Posted by "Frédéric Glorieux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1815?page=comments#action_12442125 ]
Frédéric Glorieux commented on COCOON-1815:
-------------------------------------------
[[ Old comment, sent by email on Mon, 29 May 2006 11:00:54 +0200 ]]
Thanks for others, but for testing, sorry, I can't find time for now,
I'm on other projects (in PHP :o( )
--
FrC)dC)ric Glorieux (AJLSM, http://ajlsm.com)
> CopySourceAction generate NPE
> -----------------------------
>
> Key: COCOON-1815
> URL: http://issues.apache.org/jira/browse/COCOON-1815
> Project: Cocoon
> Issue Type: Bug
> Components: * Cocoon Core
> Affects Versions: 2.1.8
> Reporter: Frédéric Glorieux
> Assigned To: Antonio Gallardo
> Priority: Minor
> Fix For: 2.2-dev (Current SVN), 2.1.10-dev (current SVN)
>
>
> <http://www.mail-archive.com/users-fr@cocoon.apache.org/msg01586.html>
> In some circumstances, with internal sources (cocoon:/), org/apache/cocoon/acting/copySource.java
> <http://svn.apache.org/viewcvs.cgi/cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/acting/CopySourceAction.java?rev=30932&view=markup>
> copy-source action generate NPE in Console (nothing seems broken)
> Source objects needs to be released
> Code may be shorter with usage of excalibur SourceUtil to copy sources
> try {
> org.apache.excalibur.source.SourceUtil.SourceUtil.copy(src, dest);
> } finally {
> resolver.release(src);
> resolver.release(dest);
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1815) CopySourceAction generate NPE
Posted by "Antonio Gallardo (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1815?page=comments#action_12371956 ]
Antonio Gallardo commented on COCOON-1815:
------------------------------------------
Would you provide a patch?
> CopySourceAction generate NPE
> -----------------------------
>
> Key: COCOON-1815
> URL: http://issues.apache.org/jira/browse/COCOON-1815
> Project: Cocoon
> Type: Bug
> Components: * Cocoon Core
> Versions: 2.1.8
> Reporter: Frédéric Glorieux
> Priority: Minor
>
> <http://www.mail-archive.com/users-fr@cocoon.apache.org/msg01586.html>
> In some circumstances, with internal sources (cocoon:/), org/apache/cocoon/acting/copySource.java
> <http://svn.apache.org/viewcvs.cgi/cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/acting/CopySourceAction.java?rev=30932&view=markup>
> copy-source action generate NPE in Console (nothing seems broken)
> Source objects needs to be released
> Code may be shorter with usage of excalibur SourceUtil to copy sources
> try {
> org.apache.excalibur.source.SourceUtil.SourceUtil.copy(src, dest);
> } finally {
> resolver.release(src);
> resolver.release(dest);
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira