You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/12/28 11:53:13 UTC
[GitHub] [incubator-doris] kangkaisen opened a new pull request #5165: Fix MaterializedView select with CTE bug
kangkaisen opened a new pull request #5165:
URL: https://github.com/apache/incubator-doris/pull/5165
Fix https://github.com/apache/incubator-doris/issues/5164
For different Analyzer scopes, the id for SelectStmt maybe the same, but the Analyzer instance always unique
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on pull request #5165: Fix MaterializedView select with CTE bug
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on pull request #5165:
URL: https://github.com/apache/incubator-doris/pull/5165#issuecomment-753718634
> Hi, @kangkaisen , there are unused imports:
>
> ```
> SingleNodePlanner.java:76:8: Unused import - java.util.UUID. [UnusedImports]
> ```
>
> Please fix it first.
@morningman done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #5165: Fix MaterializedView select with CTE bug
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on a change in pull request #5165:
URL: https://github.com/apache/incubator-doris/pull/5165#discussion_r549913788
##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
##########
@@ -86,7 +86,7 @@
private final PlannerContext ctx_;
private final ArrayList<ScanNode> scanNodes = Lists.newArrayList();
- private Map<UUID, List<ScanNode>> selectStmtToScanNodes = Maps.newHashMap();
+ private Map<Analyzer, List<ScanNode>> selectStmtToScanNodes = Maps.newHashMap();
Review comment:
No.
For SQL
```
select id, t1 from(
select id, a as t1 from t
union all
select id, aaa as t1 from t
) k2;
```
The analyzer instances for `select id, a as t1 from t` and `select id, aaa as t1 from t` are different.
Such as, The analyzer instances for `select id, a as t1 from t` is 6177, which ancestors are[6219,6220,6221],
The analyzer instances for `select id, aaa as t1 from t` is 6225, which ancestors are[6247,6220,6221].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #5165: Fix MaterializedView select with CTE bug
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #5165:
URL: https://github.com/apache/incubator-doris/pull/5165#discussion_r549749243
##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
##########
@@ -86,7 +86,7 @@
private final PlannerContext ctx_;
private final ArrayList<ScanNode> scanNodes = Lists.newArrayList();
- private Map<UUID, List<ScanNode>> selectStmtToScanNodes = Maps.newHashMap();
+ private Map<Analyzer, List<ScanNode>> selectStmtToScanNodes = Maps.newHashMap();
Review comment:
Is the Analyzer of CTE same as outer query?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #5165: Fix MaterializedView select with CTE bug
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #5165:
URL: https://github.com/apache/incubator-doris/pull/5165#issuecomment-753714505
Hi, @kangkaisen , there are unused imports:
```
SingleNodePlanner.java:76:8: Unused import - java.util.UUID. [UnusedImports]
```
Please fix it first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen merged pull request #5165: Fix MaterializedView select with CTE bug
Posted by GitBox <gi...@apache.org>.
kangkaisen merged pull request #5165:
URL: https://github.com/apache/incubator-doris/pull/5165
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org