You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Andrew Lunny (Commented) (JIRA)" <ji...@apache.org> on 2012/01/10 02:47:39 UTC
[jira] [Commented] (CB-147) [PATCH] add support for to res/xml/phonegap.xml
[ https://issues.apache.org/jira/browse/CB-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182997#comment-13182997 ]
Andrew Lunny commented on CB-147:
---------------------------------
created pull request on github - https://github.com/cordova/cordova-android/pull/3
> [PATCH] add support for <preference name="fullscreen"> to res/xml/phonegap.xml
> ------------------------------------------------------------------------------
>
> Key: CB-147
> URL: https://issues.apache.org/jira/browse/CB-147
> Project: Apache Callback
> Issue Type: New Feature
> Components: Android
> Affects Versions: 1.3.0
> Reporter: Andrew Lunny
> Fix For: 1.4.0
>
> Attachments: 0001-reading-preferences-from-phonegap.xml.patch, 0002-using-preference-fullscreen-for-fullscreen-view.patch, 0003-making-preference-reading-code-more-robust.patch
>
>
> Two patch files:
> * 0001 modifies DroidGap.loadConfiguration to look for <preference> tags. Preference tag syntax matches that specified by the W3C config.xml spec (http://www.w3.org/TR/widgets/#the-preference-element-and-its-attributes). Two extra classes - PreferenceNode and PreferenceSet - are created for this purpose. Tests are present for these two classes (depending on an earlier patch - see issue CB-146).
> * 0002 uses the PreferenceNode/PreferenceSet added by 0001 to look for a "fullscreen" preference in res/xml/phonegap.xml. If present and set to "true", the WindowManager.LayoutParams.FLAG_FULLSCREEN flag is set on the main DroidGap window
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira