[bookkeeper] branch master updated: Modules dependencies do not need to be included in checksum Jar

[si...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new 2f73da6  Modules dependencies do not need to be included in checksum Jar
2f73da6 is described below

commit 2f73da607714b622ef5aafbf073d46b55dea89a4
Author: Matteo Merli <mm...@apache.org>
AuthorDate: Thu Oct 25 05:15:18 2018 -0700

    Modules dependencies do not need to be included in checksum Jar
    
    The current assembly configuration is including the jars of the modules dependency inside its own jar.
    
    These jars are completely ignored, but they take up non trivial space.
    
    With this change the size of `circe-checksum.jar` goes from 2.8 MB to 62 KB.
    
    Author: Matteo Merli <mm...@apache.org>
    
    Reviewers: Sijie Guo <si...@apache.org>, Enrico Olivelli <eo...@gmail.com>
    
    This closes #1751 from merlimat/master
---
 circe-checksum/src/main/assembly/assembly.xml | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/circe-checksum/src/main/assembly/assembly.xml b/circe-checksum/src/main/assembly/assembly.xml
index bded0ca..432c1ac 100644
--- a/circe-checksum/src/main/assembly/assembly.xml
+++ b/circe-checksum/src/main/assembly/assembly.xml
@@ -26,15 +26,6 @@
   </formats>
 
   <includeBaseDirectory>false</includeBaseDirectory>
-  <dependencySets>
-    <dependencySet>
-      <excludes>
-        <exclude>org.slf4j:slf4j-api</exclude>
-        <exclude>io.netty</exclude>
-        <exclude>*:nar:*</exclude>
-      </excludes>
-    </dependencySet>
-  </dependencySets>
   <fileSets>
     <fileSet>
       <directory>${project.build.directory}/nar/${project.artifactId}-${project.version}-${os.arch}-MacOSX-gpp-jni/lib/${os.arch}-MacOSX-gpp/jni