[GitHub] [accumulo] ctubbsii commented on pull request #3342: Add RowRange object

["ctubbsii (via GitHub)" <gi...@apache.org>]

ctubbsii commented on PR #3342:
URL: https://github.com/apache/accumulo/pull/3342#issuecomment-1545191860

   It occurs to me that this entire class is basically just Guava's Range with Hadoop's Text as the generic parameter, `Range<Text>`. I don't think we should force users to use Guava's API, but I was thinking if we only cared about using this internally, then we might be able to just use that. I still think there's value in making this available for public API, though, without relying on Guava types in the public API, but this might take the pressure off, if there was any, to get it into the public API to address the internal uses.
   
   This is also another variant of KeyExtent, Tablet, and all those other internal types that maintain a span of row keys, of which there are already several, with slightly different purposes. Then again, making this stable public API might help simplify those others.
   
   Just a thought. I'll probably get a chance to re-review this next week.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org