[GitHub] [shardingsphere-elasticjob-lite] terrymanu commented on a change in pull request #843: Remove JDBC driver dependency for elastic-job-lite-console

[GitBox <gi...@apache.org>]

terrymanu commented on a change in pull request #843:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/843#discussion_r446167830



##########
File path: elastic-job-lite-console/src/main/resources/bin/start.bat
##########
@@ -14,6 +14,7 @@ set PORT=%1
 set CFG_DIR=%~dp0%..
 set CLASSPATH=%CFG_DIR%
 set CLASSPATH=%~dp0..\lib\*;%CLASSPATH%
+set CLASSPATH=$~dp0..\ext-lib\*;%CLASSPATH%

Review comment:
       How about merge `\lib\` and `\ext-lib\` in same line?

##########
File path: elastic-job-lite-console/src/main/resources/bin/start.sh
##########
@@ -29,6 +29,7 @@ cd `dirname $0`
 cd ..
 DEPLOY_DIR=`pwd`
 LIB_DIR=${DEPLOY_DIR}/lib/*
+LIB_DIR=${LIB_DIR}:${DEPLOY_DIR}/ext-lib/*

Review comment:
       How about merge \lib\ and \ext-lib\ in same line?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org